Skip to contentSkip to conversation

ALSA: usb-audio: Add quirks for Dell WD19 dock

PATCH Applied Jan Schär 2 participants 2 messages Oct 29, 2024 – Oct 30, 2024 Sound

lore
Share & tools
lore

Jan Schär

author
#0 lore raw

PATCH 1/1 ALSA: usb-audio: Add quirks for Dell WD19 dock

The WD19 family of docks has the same audio chipset as the WD15. This change enables jack detection on the WD19.

We don't need the dell_dock_mixer_init quirk for the WD19. It is only needed because of the dell_alc4020_map quirk for the WD15 in mixer_maps.c, which disables the volume controls. Even for the WD15, this quirk was apparently only needed when the dock firmware was not updated.

---
 sound/usb/mixer_quirks.c | 3 +++
 1 file changed, 3 insertions(+)
sound/usb/mixer_quirks.c +3 -0
index 2a9594f34dac..6456e87e2f39 100644
@@ -4042,6 +4042,9 @@ int snd_usb_mixer_apply_create_quirk(struct usb_mixer_interface *mixer)
 			break;
 		err = dell_dock_mixer_init(mixer);
 		break;
+	case USB_ID(0x0bda, 0x402e): /* Dell WD19 dock */
+		err = dell_dock_mixer_create(mixer);
+		break;
 
 	case USB_ID(0x2a39, 0x3fd2): /* RME ADI-2 Pro */
 	case USB_ID(0x2a39, 0x3fd3): /* RME ADI-2 DAC */

base-commit: 583e8f76410a5b7e0238426d8e6e1e1d2f4994b0

Signature · 1 line
2.34.1
Applied
#1 lore raw
Quoted 11 lines · Jan Schär

The WD19 family of docks has the same audio chipset as the WD15. This change enables jack detection on the WD19.

We don't need the dell_dock_mixer_init quirk for the WD19. It is only needed because of the dell_alc4020_map quirk for the WD15 in mixer_maps.c, which disables the volume controls. Even for the WD15, this quirk was apparently only needed when the dock firmware was not updated.

Thanks, applied now.

Takashi