Skip to contentSkip to conversation

linux-next: build warning after merge of the ext3 tree

DISCUSSION Stephen Rothwell 3 participants 3 messages Oct 28, 2021 – Nov 1, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the ext3 tree, today's linux-next build (htmldocs) produced this warning:

Documentation/admin-guide/filesystem-monitoring.rst:60: WARNING: Definition list ends without a blank line; unexpected unindent.

Introduced by commit

c0baf9ac0b05 ("docs: Document the FAN_FS_ERROR event")

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 10 lines · Stephen Rothwell

Hi all,

After merging the ext3 tree, today's linux-next build (htmldocs) produced this warning:

Documentation/admin-guide/filesystem-monitoring.rst:60: WARNING: Definition list ends without a blank line; unexpected unindent.

Introduced by commit

c0baf9ac0b05 ("docs: Document the FAN_FS_ERROR event")

Hi Stephen, Jan,

I'd suggest the patch below.

Thank you,

-- >8 --
From: Gabriel Krisman Bertazi <[email protected]>
Date: Thu, 28 Oct 2021 17:17:47 -0300
Subject: [PATCH] docs: Fix formatting of literal sections in fanotify docs

Stephen Rothwell reported the following warning was introduced by commit c0baf9ac0b05 ("docs: Document the FAN_FS_ERROR event").

Documentation/admin-guide/filesystem-monitoring.rst:60: WARNING:
Definition list ends without a blank line; unexpected unindent.

---
 .../admin-guide/filesystem-monitoring.rst     | 20 +++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)
Documentation/admin-guide/filesystem-monitoring.rst +12 -8
index 5a3c84e60095..ab8dba76283c 100644
@@ -35,9 +35,11 @@ notifications is Ext4.
 
 A FAN_FS_ERROR Notification has the following format::
 
-  [ Notification Metadata (Mandatory) ]
-  [ Generic Error Record  (Mandatory) ]
-  [ FID record            (Mandatory) ]
+  ::
+
+     [ Notification Metadata (Mandatory) ]
+     [ Generic Error Record  (Mandatory) ]
+     [ FID record            (Mandatory) ]
 
 The order of records is not guaranteed, and new records might be added
 in the future.  Therefore, applications must not rely on the order and
@@ -53,11 +55,13 @@ providing any additional details about the problem.  This record is
 identified by ``struct fanotify_event_info_header.info_type`` being set
 to FAN_EVENT_INFO_TYPE_ERROR.
 
-  struct fanotify_event_info_error {
-	struct fanotify_event_info_header hdr;
-	__s32 error;
-	__u32 error_count;
-  };
+  ::
+
+     struct fanotify_event_info_error {
+          struct fanotify_event_info_header hdr;
+         __s32 error;
+         __u32 error_count;
+     };
 
 The `error` field identifies the type of error using errno values.
 `error_count` tracks the number of errors that occurred and were
Signature · 1 line
2.33.0
#2 lore raw
Quoted 9 lines · Gabriel Krisman Bertazi
Quoted 7 lines · Stephen Rothwell

Hi all,

After merging the ext3 tree, today's linux-next build (htmldocs) produced this warning:

Documentation/admin-guide/filesystem-monitoring.rst:60: WARNING: Definition list ends without a blank line; unexpected unindent.

Quoted 7 lines
Quoted 3 lines

Introduced by commit

c0baf9ac0b05 ("docs: Document the FAN_FS_ERROR event")

Hi Stephen, Jan,

I'd suggest the patch below.

Thanks. I've added the patch to my tree.

Honza

Quoted 61 lines

Thank you,

-- >8 --
From: Gabriel Krisman Bertazi <[email protected]>
Date: Thu, 28 Oct 2021 17:17:47 -0300
Subject: [PATCH] docs: Fix formatting of literal sections in fanotify docs

Stephen Rothwell reported the following warning was introduced by commit c0baf9ac0b05 ("docs: Document the FAN_FS_ERROR event").

Documentation/admin-guide/filesystem-monitoring.rst:60: WARNING:
Definition list ends without a blank line; unexpected unindent.

---
 .../admin-guide/filesystem-monitoring.rst     | 20 +++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)
Documentation/admin-guide/filesystem-monitoring.rst +12 -8
index 5a3c84e60095..ab8dba76283c 100644
@@ -35,9 +35,11 @@ notifications is Ext4.
 
 A FAN_FS_ERROR Notification has the following format::
 
-  [ Notification Metadata (Mandatory) ]
-  [ Generic Error Record  (Mandatory) ]
-  [ FID record            (Mandatory) ]
+  ::
+
+     [ Notification Metadata (Mandatory) ]
+     [ Generic Error Record  (Mandatory) ]
+     [ FID record            (Mandatory) ]
 
 The order of records is not guaranteed, and new records might be added
 in the future.  Therefore, applications must not rely on the order and
@@ -53,11 +55,13 @@ providing any additional details about the problem.  This record is
 identified by ``struct fanotify_event_info_header.info_type`` being set
 to FAN_EVENT_INFO_TYPE_ERROR.
 
-  struct fanotify_event_info_error {
-	struct fanotify_event_info_header hdr;
-	__s32 error;
-	__u32 error_count;
-  };
+  ::
+
+     struct fanotify_event_info_error {
+          struct fanotify_event_info_header hdr;
+         __s32 error;
+         __u32 error_count;
+     };
 
 The `error` field identifies the type of error using errno values.
 `error_count` tracks the number of errors that occurred and were
Signature · 1 line
2.33.0
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR