Skip to contentSkip to conversation

package/gflags: force Release mode

PATCH New Fabrice Fontaine 4 participants 4 messages Apr 25, 2020 – May 8, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/gflags: force Release mode

Force Release otherwise libraries will be suffixed by _debug which will raise unexpected build failures with packages that use gflags (e.g. rocksdb)

Fixes:
- http://autobuild.buildroot.org/results/3545774258babc3584f69e7d523efdf7fff1acb5

---
 package/gflags/gflags.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
package/gflags/gflags.mk +5 -1
index c4fce45b3e..f32869f70d 100644
@@ -10,8 +10,12 @@ GFLAGS_INSTALL_STAGING = YES
 GFLAGS_LICENSE = BSD-3-Clause
 GFLAGS_LICENSE_FILES = COPYING.txt
 
+# Force Release otherwise libraries will be suffixed by _debug which will raise
+# unexpected build failures with packages that use gflags (e.g. rocksdb)
+GFLAGS_CONF_OPTS = -DCMAKE_BUILD_TYPE=Release
+
 ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)
-GFLAGS_CONF_OPTS = -DBUILD_gflags_LIB=OFF \
+GFLAGS_CONF_OPTS += -DBUILD_gflags_LIB=OFF \
 	-DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -DNO_THREADS"
 endif
 
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 package/gflags: force Release mode

Quoted 10 lines · On Sat, 25 Apr 2020 18:22:44 +0200 Fabrice Fontaine…

Force Release otherwise libraries will be suffixed by _debug which will raise unexpected build failures with packages that use gflags (e.g. rocksdb)

Fixes:
- http://autobuild.buildroot.org/results/3545774258babc3584f69e7d523efdf7fff1acb5

---
 package/gflags/gflags.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/gflags: force Release mode

In reply to Fabrice Fontaine
Quoted 17 lines · Fabrice Fontaine

Force Release otherwise libraries will be suffixed by _debug which will raise unexpected build failures with packages that use gflags (e.g. rocksdb)

Fixes:
- http://autobuild.buildroot.org/results/3545774258babc3584f69e7d523efdf7fff1acb5

---
 package/gflags/gflags.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
package/gflags/gflags.mk +0 -0
index c4fce45b3e..f32869f70d 100644

package/gflags/gflags.mk GFLAGS_INSTALL_STAGING = YES · line 15

Quoted 6 lines
package/gflags/gflags.mk +3 -0
@@ -10,8 +10,12 @@ GFLAGS_INSTALL_STAGING = YES
 GFLAGS_LICENSE = BSD-3-Clause
 GFLAGS_LICENSE_FILES = COPYING.txt
 
+# Force Release otherwise libraries will be suffixed by _debug which will raise
+# unexpected build failures with packages that use gflags (e.g. rocksdb)
+GFLAGS_CONF_OPTS = -DCMAKE_BUILD_TYPE=Release

I think pkgconfig can solve this problem. Rocksdb has CMake support which uses pkgconfig to find gflags.

Regards,
Rahul

Quoted 10 lines
package/gflags/gflags.mk +2 -2
+
 ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)
-GFLAGS_CONF_OPTS = -DBUILD_gflags_LIB=OFF \
+GFLAGS_CONF_OPTS += -DBUILD_gflags_LIB=OFF \
        -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -DNO_THREADS"
 endif
 
--

2.25.1

#3 lore raw

PATCH 1/1 package/gflags: force Release mode

In reply to Fabrice Fontaine
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Force Release otherwise libraries will be suffixed by _debug which will raise unexpected build failures with packages that use gflags (e.g. rocksdb)

Fixes:
- http://autobuild.buildroot.org/results/3545774258babc3584f69e7d523efdf7fff1acb5

Committed to 2020.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard