podman: fix command invocation
PATCH 1/1 podman: fix command invocation
Oops; there's no argv here.
Signed-off-by John Snow <[email protected]>
--- tests/docker/docker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/docker/docker.py +1 -1
@@ -334,7 +334,7 @@ class Docker(object): cmd = [ "-u", str(uid) ] + cmd # podman requires a bit more fiddling if self._command[0] == "podman": - argv.insert(0, '--userns=keep-id') + cmd.insert(0, '--userns=keep-id') ret = self._do_check(["run", "--label", "com.qemu.instance.uuid=" + label] + cmd,
Signature · 1 line
2.21.0
Quoted 1 line · John Snow
Oops; there's no argv here.
Oops indeed. Queued to testing/next, thanks.
Quoted 11 lines
Signed-off-by John Snow <[email protected]>--- tests/docker/docker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/docker/docker.py +0
-0
tests/docker/docker.py class Docker(object): · line 340
Quoted 8 lines
tests/docker/docker.py +1
-1@@ -334,7 +334,7 @@ class Docker(object): cmd = [ "-u", str(uid) ] + cmd # podman requires a bit more fiddling if self._command[0] == "podman": - argv.insert(0, '--userns=keep-id') + cmd.insert(0, '--userns=keep-id') ret = self._do_check(["run", "--label", "com.qemu.instance.uuid=" + label] + cmd,
--
Alex Bennée
Quoted 24 lines · John Snow
Oops; there's no argv here.
Signed-off-by John Snow <[email protected]>--- tests/docker/docker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/docker/docker.py +1
-1@@ -334,7 +334,7 @@ class Docker(object): cmd = [ "-u", str(uid) ] + cmd # podman requires a bit more fiddling if self._command[0] == "podman": - argv.insert(0, '--userns=keep-id') + cmd.insert(0, '--userns=keep-id') ret = self._do_check(["run", "--label", "com.qemu.instance.uuid=" + label] + cmd,Signature · 1 line
2.21.0
Hit it Today while testing your test/docker Python 3 patches.
Reviewed-by Cleber Rosa <[email protected]>
Tested-by Cleber Rosa <[email protected]>