Skip to contentSkip to conversation

package/mesa3d: allow VC4 driver on all ARM platforms

PATCH New Thomas Petazzoni 2 participants 3 messages Aug 19, 2019 – Sep 2, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/mesa3d: allow VC4 driver on all ARM platforms

In commit 3e5926555b59b50210bb7814d176b384f9d554ab ("package/{mesa3d, mesa3d-headers}: bump version to 17.1.2"), the dependency of VC4 on BR2_arm was changed to BR2_ARM_CPU_HAS_NEON, which the reasoning that upstream commit
https://cgit.freedesktop.org/mesa/mesa/commit/?h=17.1&id=4d30024238efa829cabc72c1601beeee18c3dbf2
made NEON mandatory. However, this commit (including its commit log) clearly shows that there is compile-time detection on whether you're using ARMv6 or ARMv7, and simply says there is no runtime detection for that (which usually isn't very important in the context of Buildroot). So, the VC4 driver can be used on ARMv6 RaspberryPis. Therefore, this commit reverts to the BR2_arm dependency.

Note: while there are some ARMv7 without NEONs, all ARMv7 RaspberryPi platforms do have NEON, so the compile-time checks done in the VC4 driver are good enough.

Fixes:

https://bugs.busybox.net/show_bug.cgi?id=12126

---
 package/mesa3d/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/mesa3d/Config.in +1 -1
index 3f44e94229..70067058e6 100644
@@ -180,7 +180,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST
 
 config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4
 	bool "Gallium vc4 driver"
-	depends on BR2_ARM_CPU_HAS_NEON || BR2_aarch64
+	depends on BR2_arm || BR2_aarch64
 	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
 	select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO
 	select BR2_PACKAGE_LIBDRM_VC4
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 package/mesa3d: allow VC4 driver on all ARM platforms

Quoted 19 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

In commit 3e5926555b59b50210bb7814d176b384f9d554ab ("package/{mesa3d, mesa3d-headers}: bump version to 17.1.2"), the dependency of VC4 on BR2_arm was changed to BR2_ARM_CPU_HAS_NEON, which the reasoning that upstream commit
https://cgit.freedesktop.org/mesa/mesa/commit/?h=17.1&id=4d30024238efa829cabc72c1601beeee18c3dbf2
made NEON mandatory. However, this commit (including its commit log) clearly shows that there is compile-time detection on whether you're using ARMv6 or ARMv7, and simply says there is no runtime detection for that (which usually isn't very important in the context of Buildroot). So, the VC4 driver can be used on ARMv6 RaspberryPis. Therefore, this commit reverts to the BR2_arm dependency.

Note: while there are some ARMv7 without NEONs, all ARMv7 RaspberryPi platforms do have NEON, so the compile-time checks done in the VC4 driver are good enough.

Quoted 6 lines

Fixes:

https://bugs.busybox.net/show_bug.cgi?id=12126

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/mesa3d: allow VC4 driver on all ARM platforms

In reply to Thomas Petazzoni
Quoted 19 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

In commit 3e5926555b59b50210bb7814d176b384f9d554ab ("package/{mesa3d, mesa3d-headers}: bump version to 17.1.2"), the dependency of VC4 on BR2_arm was changed to BR2_ARM_CPU_HAS_NEON, which the reasoning that upstream commit
https://cgit.freedesktop.org/mesa/mesa/commit/?h=17.1&id=4d30024238efa829cabc72c1601beeee18c3dbf2
made NEON mandatory. However, this commit (including its commit log) clearly shows that there is compile-time detection on whether you're using ARMv6 or ARMv7, and simply says there is no runtime detection for that (which usually isn't very important in the context of Buildroot). So, the VC4 driver can be used on ARMv6 RaspberryPis. Therefore, this commit reverts to the BR2_arm dependency.

Note: while there are some ARMv7 without NEONs, all ARMv7 RaspberryPi platforms do have NEON, so the compile-time checks done in the VC4 driver are good enough.

Quoted 6 lines

Fixes:

https://bugs.busybox.net/show_bug.cgi?id=12126

Committed to 2019.02.x and 2019.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard