clk: kirkwood: fix refcount leak in kirkwood_clk_init()
Subsystems (2)
PATCH 1/1 clk: kirkwood: fix refcount leak in kirkwood_clk_init()
The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount.
Signed-off-by Yangtao Li <[email protected]>
--- drivers/clk/mvebu/kirkwood.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/clk/mvebu/kirkwood.c +2 -0
@@ -331,6 +331,8 @@ static void __init kirkwood_clk_init(struct device_node *np)if (cgnp) {mvebu_clk_gating_setup (cgnp, kirkwood_gating_desc);kirkwood_clk_muxing_setup (cgnp, kirkwood_mux_desc); + +of_node_put (cgnp); } } CLK_OF_DECLARE(kirkwood_clk, "marvell,kirkwood-core-clock",
Signature · 1 line
2.17.0
Hi Yangtao,
Quoted 3 lines · Yangtao Li
The
of_find_compatible_node()returns a node pointer with refcount incremented, but there is the lack of use of theof_node_put()when done. Add the missingof_node_put()to release the refcount.
Reviewed-by Gregory CLEMENT <[email protected]>
Thanks,
Gregory
Quoted 22 lines
Signed-off-by Yangtao Li <[email protected]>--- drivers/clk/mvebu/kirkwood.c | 2 ++ 1 file changed, 2 insertions(+)drivers/clk/mvebu/kirkwood.c +2
-0@@ -331,6 +331,8 @@ static void __init kirkwood_clk_init(struct device_node *np)if (cgnp) {mvebu_clk_gating_setup (cgnp, kirkwood_gating_desc);kirkwood_clk_muxing_setup (cgnp, kirkwood_mux_desc); + +of_node_put (cgnp); } } CLK_OF_DECLARE(kirkwood_clk, "marvell,kirkwood-core-clock",Signature · 1 line
2.17.0
Signature · 3 lines
Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com
Quoting Yangtao Li (2018-12-26 05:40:19)
Quoted 6 lines
The
of_find_compatible_node()returns a node pointer with refcount incremented, but there is the lack of use of theof_node_put()when done. Add the missingof_node_put()to release the refcount.Signed-off-by Yangtao Li <[email protected]>---
Applied to clk-next