Skip to contentSkip to conversation

gpio: pxa: remove set but not used variable 'gpio_offset'

PATCH Robert Jarzmik 2 participants 2 messages Aug 1, 2018 – Aug 2, 2018 Kernel janitors

lore
Share & tools
lore

Robert Jarzmik

author Acked-by
#0 lore raw
Quoted 5 lines · Wei Yongjun

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpio/gpio-pxa.c: In function ‘pxa_gpio_probe’:
drivers/gpio/gpio-pxa.c:629:35: warning:
variable ‘gpio_offset’ set but not used [-Wunused-but-set-variable]

There are weird characters here : ‘ and ’

Quoted 3 lines
  int irq0 = 0, irq1 = 0, irq_mux, gpio_offset = 0;
Signed-off-by Wei Yongjun <[email protected]>

Once that is fixed,

Acked-by Robert Jarzmik <[email protected]>

Cheers.

--
Robert

#1 lore raw
Quoted 9 lines · Wei Yongjun

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpio/gpio-pxa.c: In function ‘pxa_gpio_probe’:
drivers/gpio/gpio-pxa.c:629:35: warning:
variable ‘gpio_offset’ set but not used [-Wunused-but-set-variable]

  int irq0 = 0, irq1 = 0, irq_mux, gpio_offset = 0;
                                   ^
Signed-off-by Wei Yongjun <[email protected]>

Fixed up the funny characters and applied with Robert's ACK!

Yours,
Linus Walleij