Skip to contentSkip to conversation

board/atmel: use correct sam-ba binary in flasher.sh script

PATCH New Joshua Henderson 3 participants 3 messages Apr 5, 2018 – Apr 8, 2018 Arm/Microchip (AT91) SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board/atmel: use correct sam-ba binary in flasher.sh script

Instead of using the install of sam-ba under host/opt directly, use the symlink created in host/bin. The side effect of doing this instead allows the correct sam-ba binary to be used based on the host arch being 32 bit or 64 bit.

---
 board/atmel/flasher.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
board/atmel/flasher.sh +2 -3
index bbdb199..c122760 100755
@@ -130,7 +130,6 @@ if [[ $BOARD == "*pda4" ]]; then
 	video_mode="video=LVDS-1:480x272-16"
 fi
 
-echo "Executing: ${!F} O=$1/images $1/host/opt/sam-ba/sam-ba $TTY ${!M} $(dirname $0)/nandflash.tcl -- ${!F} ${!D} $video_mode"
+echo "Executing: ${!F} O=$1/images $1/host/bin/sam-ba $TTY ${!M} $(dirname $0)/nandflash.tcl -- ${!F} ${!D} $video_mode"
 export O=$1/images
-$1/host/opt/sam-ba/sam-ba $TTY ${!M} $(dirname $0)/nandflash.tcl -- ${!F} ${!D} $video_mode
-
+$1/host/bin/sam-ba $TTY ${!M} $(dirname $0)/nandflash.tcl -- ${!F} ${!D} $video_mode
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 board/atmel: use correct sam-ba binary in flasher.sh script

Hello,

Quoted 8 lines · Joshua Henderson

Instead of using the install of sam-ba under host/opt directly, use the symlink created in host/bin. The side effect of doing this instead allows the correct sam-ba binary to be used based on the host arch being 32 bit or 64 bit.

---
 board/atmel/flasher.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 board/atmel: use correct sam-ba binary in flasher.sh script

In reply to Joshua Henderson
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Joshua" == Joshua Henderson <[email protected]> writes:

Instead of using the install of sam-ba under host/opt directly, use the symlink created in host/bin. The side effect of doing this instead allows the correct sam-ba binary to be used based on the host arch being 32 bit or 64 bit.

Committed to 2018.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard