Skip to contentSkip to conversation

drm/i915: Fix non static symbol warning

PATCH In review Wei Yongjun 2 participants 2 messages Sep 17, 2016 – Sep 19, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Fix non static symbol warning

From: Wei Yongjun <[email protected]>

Fixes the following sparse warning:

drivers/gpu/drm/i915/intel_dp.c:1527:5: warning:
symbol 'intel_dp_compute_bpp' was not declared. Should it be static?

---
 drivers/gpu/drm/i915/intel_dp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +2 -2
index 69cee9b..acd0c51 100644
@@ -1524,8 +1524,8 @@ void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock,
 	}
 }
 
-int intel_dp_compute_bpp(struct intel_dp *intel_dp,
-			 struct intel_crtc_state *pipe_config)
+static int intel_dp_compute_bpp(struct intel_dp *intel_dp,
+				struct intel_crtc_state *pipe_config)
 {
 	int bpp, bpc;
 

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#1 lore raw
Quoted 17 lines · Wei Yongjun

From: Wei Yongjun <[email protected]>

Fixes the following sparse warning:

drivers/gpu/drm/i915/intel_dp.c:1527:5: warning:
symbol 'intel_dp_compute_bpp' was not declared. Should it be static?

---
 drivers/gpu/drm/i915/intel_dp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +0 -0
index 69cee9b..acd0c51 100644

drivers/gpu/drm/i915/intel_dp.c void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock, · line 1528

Quoted 7 lines
drivers/gpu/drm/i915/intel_dp.c +2 -2
@@ -1524,8 +1524,8 @@ void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock,
 	}
 }
 
-int intel_dp_compute_bpp(struct intel_dp *intel_dp,
-			 struct intel_crtc_state *pipe_config)
+static int intel_dp_compute_bpp(struct intel_dp *intel_dp,
+				struct intel_crtc_state *pipe_config)

Already fixed upstream.

BR,
Jani.

Signature · 1 line
Jani Nikula, Intel Open Source Technology Center