ARM: dts: Kirkwood: Fix QNAP TS219 power-off
PATCH 1/1 ARM: dts: Kirkwood: Fix QNAP TS219 power-off
From: Helmut Klein <[email protected]>
The "reg" entry in the "poweroff" section of "kirkwood-ts219.dtsi" addressed the wrong uart (0 = console). This patch changes the address to select uart 1, which is the uart connected to the pic microcontroller, which can switch the device off.
---
Hi Helmut
I made a few minor changes to your patch:
1) Made subject line consistent with other patches to kirkwood-ts219.dtsi
2) Added a Fixes: tag, so that it gets backported to stable
3) Put comments after the ---, so they don't land in the change log.
Hi Gregory
This is a fix, i guess too late for this merge window, so please could you send it after -rc1 is out?
--- arch/arm/boot/dts/kirkwood-ts219.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/kirkwood-ts219.dtsi +1 -1
@@ -40,7 +40,7 @@ }; poweroff at 12100 { compatible = "qnap,power-off"; - reg = <0x12000 0x100>; + reg = <0x12100 0x100>; clocks = <&gate_clk 7>; }; spi at 10600 {
Signature · 1 line
2.6.1
PATCH 1/1 ARM: dts: Kirkwood: Fix QNAP TS219 power-off
Hi Andrew and Helmut,
Quoted 11 lines · Andrew Lunn
From: Helmut Klein <[email protected]>
The "reg" entry in the "poweroff" section of "
kirkwood-ts219.dtsi" addressed the wrong uart (0 = console). This patch changes the address to select uart 1, which is the uart connected to the pic microcontroller, which can switch the device off.Signed-off-by Helmut Klein <[email protected]>Signed-off-by Andrew Lunn <[email protected]>Fixes 4350a47bbac3 ("ARM: Kirkwood: Make use of the QNAP Power offdriver.")
Applied on mvebu/fixes
Thanks,
Gregory
Quoted 34 lines
---
Hi Helmut
I made a few minor changes to your patch:
1) Made subject line consistent with other patches to
kirkwood-ts219.dtsi
2) Added a Fixes: tag, so that it gets backported to stable
3) Put comments after the ---, so they don't land in the change log.Hi Gregory
This is a fix, i guess too late for this merge window, so please could you send it after -rc1 is out?
--- arch/arm/boot/dts/kirkwood-ts219.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/kirkwood-ts219.dtsi +1
-1@@ -40,7 +40,7 @@ }; poweroff at 12100 { compatible = "qnap,power-off"; - reg = <0x12000 0x100>; + reg = <0x12100 0x100>; clocks = <&gate_clk 7>; }; spi at 10600 {Signature · 1 line
2.6.1
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com