Skip to contentSkip to conversation

infozip: fix $(AS) behavior

PATCH New Romain Naour 2 participants 2 messages Jan 30, 2014 – Feb 2, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 infozip: fix $(AS) behavior

infozip's Makefile expect $(AS) to output by default to <basename>.o but when called from Buildroot, the value for $(AS) is set to to invoke the toolchain's $(AS) directly, and the output of it goes to a.out.

So, define $(AS) with $(CC -c)

---
 package/infozip/infozip.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/infozip/infozip.mk +1 -1
index d73edd4..cc2bd34 100644
@@ -11,7 +11,7 @@ INFOZIP_LICENSE = Info-ZIP
 INFOZIP_LICENSE_FILES = LICENSE
 
 define INFOZIP_BUILD_CMDS
-	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile generic
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) AS="$(TARGET_CC) -c" -f unix/Makefile generic
 endef
 
 define INFOZIP_INSTALL_TARGET_CMDS
Signature · 1 line
1.8.5.3
#1 lore raw

PATCH 1/3 infozip: fix $(AS) behavior

Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

infozip's Makefile expect $(AS) to output by default to <basename>.o but when called from Buildroot, the value for $(AS) is set to to invoke the toolchain's $(AS) directly, and the output of it goes to a.out.

So, define $(AS) with $(CC -c)

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard