Skip to contentSkip to conversation

libvpx: needs thread support

PATCH New Thomas Petazzoni 4 participants 5 messages Nov 2, 2013 – Nov 4, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libvpx: needs thread support

Fixes:

http://autobuild.buildroot.org/results/8de/8def7e54e4fecb7df350443824c00b53d1c61c01/build-end.log

---
 package/gstreamer1/gst1-plugins-good/Config.in | 4 ++++
 package/libvpx/Config.in                       | 4 ++++
 2 files changed, 8 insertions(+)
package/gstreamer1/gst1-plugins-good/Config.in +4 -0
index 3342208..a9308c7 100644
@@ -335,9 +335,13 @@ comment "taglib needs a toolchain w/ C++"
 config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_VPX
 	bool "vpx (webm)"
 	select BR2_PACKAGE_LIBVPX
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libvpx
 	help
 	  VP8 plugin
 
+comment "libvpx needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
+
 config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_WAVPACK
 	bool "wavpack (*.wv audio)"
 	select BR2_PACKAGE_WAVPACK
package/libvpx/Config.in +4 -0
index 1332c56..0ed3e1a 100644
@@ -1,7 +1,11 @@
 config BR2_PACKAGE_LIBVPX
 	bool "libvpx"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  A high-quality, open video format that's freely available to
 	  everyone.
 
 	  http://webmproject.org
+
+comment "libvpx needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 libvpx: needs thread support

Thomas, All,

On 2013-11-02 17:04 +0100, Thomas Petazzoni spake thusly:

Quoted 5 lines

Fixes:

http://autobuild.buildroot.org/results/8de/8def7e54e4fecb7df350443824c00b53d1c61c01/build-end.log

Quoted 46 lines
---
 package/gstreamer1/gst1-plugins-good/Config.in | 4 ++++
 package/libvpx/Config.in                       | 4 ++++
 2 files changed, 8 insertions(+)
package/gstreamer1/gst1-plugins-good/Config.in +4 -0
index 3342208..a9308c7 100644
@@ -335,9 +335,13 @@ comment "taglib needs a toolchain w/ C++"
 config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_VPX
 	bool "vpx (webm)"
 	select BR2_PACKAGE_LIBVPX
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libvpx
 	help
 	  VP8 plugin
 
+comment "libvpx needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
+
 config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_WAVPACK
 	bool "wavpack (*.wv audio)"
 	select BR2_PACKAGE_WAVPACK
package/libvpx/Config.in +4 -0
index 1332c56..0ed3e1a 100644
@@ -1,7 +1,11 @@
 config BR2_PACKAGE_LIBVPX
 	bool "libvpx"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  A high-quality, open video format that's freely available to
 	  everyone.
 
 	  http://webmproject.org
+
+comment "libvpx needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 6 lines
1.8.1.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 libvpx: needs thread support

In reply to Thomas Petazzoni

2013/11/2 Thomas Petazzoni <[email protected]>

Quoted 7 lines

Fixes:

http://autobuild.buildroot.org/results/8de/8def7e54e4fecb7df350443824c00b53d1c61c01/build-end.log

Regards,

Signature · 4 lines
Samuel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131102/6ff8e678/attachment-0001.html>
#3 lore raw

PATCH 1/1 libvpx: needs thread support

In reply to Thomas Petazzoni

Dear Thomas Petazzoni,

Quoted 9 lines · Thomas Petazzoni

Fixes:

http://autobuild.buildroot.org/results/8de/8def7e54e4fecb7df350443824c00b53d1c61c01/build-end.log

---
 package/gstreamer1/gst1-plugins-good/Config.in | 4 ++++
 package/libvpx/Config.in                       | 4 ++++
 2 files changed, 8 insertions(+)

Committed to for-peter-2013.11, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 libvpx: needs thread support

In reply to Thomas Petazzoni
Quoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Fixes:
http://autobuild.buildroot.org/results/8de/8def7e54e4fecb7df350443824c00b53d1c61c01/build-end.log

---
 package/gstreamer1/gst1-plugins-good/Config.in | 4 ++++
 package/libvpx/Config.in                       | 4 ++++
 2 files changed, 8 insertions(+)
package/gstreamer1/gst1-plugins-good/Config.in +0 -0
index 3342208..a9308c7 100644

package/gstreamer1/gst1-plugins-good/Config.in comment "taglib needs a toolchain w/ C++" · line 344

Quoted 10 lines
package/gstreamer1/gst1-plugins-good/Config.in +4 -0
@@ -335,9 +335,13 @@ comment "taglib needs a toolchain w/ C++"
 config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_VPX
 	bool "vpx (webm)"
 	select BR2_PACKAGE_LIBVPX
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libvpx
 	help
 	  VP8 plugin
 
+comment "libvpx needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
+

Gstreamer1 itself is a heavy user of threads (and therefor depends on BR2_TOOLCHAIN_HAS_THREADS), so this comment is never going to be visible, but ok.

Signature · 1 line
Bye, Peter Korsgaard