OMAP3+: sr_device: include pm header
Subsystems (3)
PATCH 1/1 OMAP3+: sr_device: include pm header
omap_enable_smartreflex_on_init is meant to be used by boards which would like to have SR enabled by default on the platform, while omap_devinit_smartreflex is used by pm code, the protos are defined in pm.h. This header should be included to ensure that sr_device function definitions match the prototypes.
including pm.h fixes the sparse warnings (with CONFIG_OMAP_SMARTREFLEX=y):arch/arm/mach-omap2/sr_device.c:138:13: warning: symbol 'omap_enable_smartreflex_on_init' was not declared. Should it be static? arch/arm/mach-omap2/sr_device.c:143:12: warning: symbol 'omap_devinit_smartreflex' was not declared. Should it be static?
---
Based on:git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git
branch: omap-for-linus
arch/arm/mach-omap2/sr_device.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/sr_device.c +1 -0
@@ -27,6 +27,7 @@#include <plat/voltage.h> #include "control.h" +#include "pm.h" static bool sr_enable_on_init;
Signature · 1 line
1.6.3.3
PATCH 1/1 OMAP3+: sr_device: include pm header
Quoted 11 lines · Nishanth Menon
omap_enable_smartreflex_on_initis meant to be used by boards which would like to have SR enabled by default on the platform, whileomap_devinit_smartreflexis used by pm code, the protos are defined inpm.h. This header should be included to ensure thatsr_devicefunction definitions match the prototypes.including
pm.hfixes the sparse warnings (withCONFIG_OMAP_SMARTREFLEX=y):arch/arm/mach-omap2/sr_device.c:138:13: warning: symbol 'omap_enable_smartreflex_on_init' was not declared. Should it be static?arch/arm/mach-omap2/sr_device.c:143:12: warning: symbol 'omap_devinit_smartreflex' was not declared. Should it be static?Signed-off-by Nishanth Menon <[email protected]>
Thanks, will queue as a fix for 2.6.38-rc cycle.
Kevin
Quoted 18 lines
Based on:
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git
branch: omap-for-linusarch/arm/mach-omap2/sr_device.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)arch/arm/mach-omap2/sr_device.c +1
-0@@ -27,6 +27,7 @@#include <plat/voltage.h> #include "control.h" +#include "pm.h" static bool sr_enable_on_init;