Skip to contentSkip to conversation

Makefile.in: correct distclean rule

PATCH New Jim Meyering 1 participant 1 message Jun 12, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile.in: correct distclean rule

[resending, with "From " escaped to avoid triggering the mailman bug
that would otherwise elide any patch produced by "git format-patch"]

Currently, "make distclean" gets lots of errors, because none of the directories test/mm, test/device, ... exist any more (they've been moved to old-tests/). And even those latter never have a Makefile, so the only sensible thing to do is remove those old subdirs from the list in Makefile.in.

The change below does that as well as adding "test" so that "make distclean" traverses into that subdirectory. Before, "make check" would create test/bin,
but a top-level "make distclean" would not remove it.

FYI, initially I thought it was an oversight that "make clean" did not remove artifacts from subdirectories, so I made this additional change:

  diff --git a/Makefile.in b/Makefile.in
  ...
  -ifeq ($(MAKECMDGOALS),distclean)
  +ifneq ($(strip $(filter %clean,$(MAKECMDGOALS))),)

However, it could also be a policy decision, so I left it.

I'll commit the following shortly.