Skip to contentSkip to conversation

package/rlwrap: use the github helper

PATCH In review Matt Silva 2 participants 2 messages Apr 10, 2025

lore
Share & tools
lore

Matt Silva

author
#0 lore raw

PATCH 1/1 package/rlwrap: use the github helper

Currently, rlwrap just downloads directly from the hardcoded URL to its Github releases. However, we have a github helper function to streamline this and handle if Github changes its download mechanisms in the future.

Signed-off-by Matt Silva <[email protected]>
---
 package/rlwrap/rlwrap.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/rlwrap/rlwrap.mk +1 -1
index e3973e841b..3d3d4fab92 100644
@@ -5,7 +5,7 @@
 ################################################################################
 
 RLWRAP_VERSION = 0.46.1
-RLWRAP_SITE = https://github.com/hanslub42/rlwrap/releases/download/$(RLWRAP_VERSION)
+RLWRAP_SITE = $(call github,hanslub42,rlwrap,v$(RLWRAP_VERSION))
 RLWRAP_LICENSE = GPL-2.0+
 RLWRAP_LICENSE_FILES = AUTHORS COPYING
Signature · 6 lines
2.47.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hi Matt,

Quoted 14 lines · Matt Silva

Currently, rlwrap just downloads directly from the hardcoded URL to its Github releases. However, we have a github helper function to streamline this and handle if Github changes its download mechanisms in the future.

Signed-off-by Matt Silva <[email protected]>
---
 package/rlwrap/rlwrap.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/rlwrap/rlwrap.mk +0 -0
index e3973e841b..3d3d4fab92 100644

package/rlwrap/rlwrap.mk line 8

Quoted 5 lines
package/rlwrap/rlwrap.mk +1 -1
@@ -5,7 +5,7 @@
 ################################################################################
 
 RLWRAP_VERSION = 0.46.1
-RLWRAP_SITE = https://github.com/hanslub42/rlwrap/releases/download/$(RLWRAP_VERSION)
+RLWRAP_SITE = $(call github,hanslub42,rlwrap,v$(RLWRAP_VERSION))

We prefer to use release tarball when the package maintainer provides one. See the relevant section in the Buildroot manual:

https://buildroot.org/downloads/manual/manual.html#github-download-url

baruch

Quoted 2 lines
package/rlwrap/rlwrap.mk +0 -0
 RLWRAP_LICENSE = GPL-2.0+
 RLWRAP_LICENSE_FILES = AUTHORS COPYING
Signature · 7 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot