Skip to contentSkip to conversation

package/perftest: fix unmet direct dependencies

PATCH Applied Waldemar Brodkorb 3 participants 3 messages Aug 14, 2023 – Sep 12, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/perftest: fix unmet direct dependencies

rdma-core selects perftest and needs NPTL.
Should be backported to stable branches, because the problem exist since the addition of the package.

Fixes:
- http://autobuild.buildroot.net/results/00c/00ce19a1589c6028ee77c333ed9107e2c8c8d6de

---
 package/perftest/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/perftest/Config.in +1 -1
index 25cd1a9b8d..0a4114015b 100644
@@ -20,7 +20,7 @@ config BR2_PACKAGE_PERFTEST_ARCH_SUPPORTS
 config BR2_PACKAGE_PERFTEST
 	bool "perftest"
 	depends on BR2_PACKAGE_PERFTEST_ARCH_SUPPORTS
-	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # rdma-core
 	depends on !BR2_STATIC_LIBS # rdma-core
 	# musl does not define sysconf(_SC_LEVEL1_DCACHE_LINESIZE)
 	depends on !BR2_TOOLCHAIN_USES_MUSL
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Waldemar, All,

On 2023-08-14 09:16 +0200, Waldemar Brodkorb spake thusly:

Quoted 17 lines

rdma-core selects perftest and needs NPTL.
Should be backported to stable branches, because the problem exist since the addition of the package.

Fixes:
- http://autobuild.buildroot.net/results/00c/00ce19a1589c6028ee77c333ed9107e2c8c8d6de

---
 package/perftest/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/perftest/Config.in +0 -0
index 25cd1a9b8d..0a4114015b 100644

package/perftest/Config.in config BR2_PACKAGE_PERFTEST_ARCH_SUPPORTS · line 23

Quoted 5 lines
package/perftest/Config.in +1 -1
@@ -20,7 +20,7 @@ config BR2_PACKAGE_PERFTEST_ARCH_SUPPORTS
 config BR2_PACKAGE_PERFTEST
 	bool "perftest"
 	depends on BR2_PACKAGE_PERFTEST_ARCH_SUPPORTS
-	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # rdma-core

You also missed propagating the dependency on the kernel headers version, so I've done that.

I also expanded the commit log to explain when the two issues were introduced.

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/perftest/Config.in +0 -0
 	depends on !BR2_STATIC_LIBS # rdma-core
 	# musl does not define sysconf(_SC_LEVEL1_DCACHE_LINESIZE)
 	depends on !BR2_TOOLCHAIN_USES_MUSL
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to Waldemar Brodkorb
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Waldemar" == Waldemar Brodkorb <[email protected]> writes:

rdma-core selects perftest and needs NPTL.
Should be backported to stable branches, because the problem exist since the addition of the package.

Fixes:
- http://autobuild.buildroot.net/results/00c/00ce19a1589c6028ee77c333ed9107e2c8c8d6de

Committed to 2023.02.x and 2023.05.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot