wireless: ath: remove unused-but-set parameter
Subsystems (3)
PATCH 1/1 wireless: ath: remove unused-but-set parameter
From: Arnd Bergmann <[email protected]>
This has never been used since the driver was merged, but it now causes a W=1 warning in recent clang versions
drivers/net/wireless/ath/ath9k/main.c:1566:21: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter] drivers/net/wireless/ath/ath9k/htc_drv_main.c:1258:25: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter] drivers/net/wireless/ath/ath5k/mac80211-ops.c:367:62: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
Remove the bit manipulation on the otherwise unused parameter.
--- drivers/net/wireless/ath/ath12k/mac.c | 5 ++--- drivers/net/wireless/ath/ath5k/mac80211-ops.c | 1 - drivers/net/wireless/ath/ath9k/htc_drv_main.c | 1 - drivers/net/wireless/ath/ath9k/main.c | 1 - 4 files changed, 2 insertions(+), 6 deletions(-)
drivers/net/wireless/ath/ath12k/mac.c +2 -3
@@ -5666,7 +5666,6 @@ static void ath12k_mac_op_configure_filter(struct ieee80211_hw *hw,mutex_lock (&ar->conf_mutex); - changed_flags &=SUPPORTED_FILTERS ; *total_flags &=SUPPORTED_FILTERS ; ar->filter_flags = *total_flags;
@@ -5684,8 +5683,8 @@ static void ath12k_mac_op_configure_filter(struct ieee80211_hw *hw, "fail to set monitor filter: %d\n", ret); }ath12k_dbg (ar->ab,ATH12K_DBG_MAC , -"changed_flags:0x%x, total_flags:0x%x, reset_flag:%d\n" , - changed_flags, *total_flags, reset_flag); +"total_flags:0x%x, reset_flag:%d\n" , + *total_flags, reset_flag);mutex_unlock (&ar->conf_mutex); }
drivers/net/wireless/ath/ath5k/mac80211-ops.c +0 -1
@@ -382,7 +382,6 @@ ath5k_configure_filter(struct ieee80211_hw *hw, unsigned int changed_flags, mfilt[1 ] = multicast >>32 ;/* Only deal with supported flags */ - changed_flags &=SUPPORTED_FIF_FLAGS ; *new_flags &=SUPPORTED_FIF_FLAGS ;/* If HW detects any phy or radar errors, leave those filters on.
drivers/net/wireless/ath/ath9k/htc_drv_main.c +0 -1
@@ -1264,7 +1264,6 @@ static void ath9k_htc_configure_filter(struct ieee80211_hw *hw,u32 rfilt;mutex_lock (&priv->mutex); - changed_flags &=SUPPORTED_FILTERS ; *total_flags &=SUPPORTED_FILTERS ;if (test_bit (ATH_OP_INVALID , &common->op_flags)) {
drivers/net/wireless/ath/ath9k/main.c +0 -1
@@ -1571,7 +1571,6 @@ static void ath9k_configure_filter(struct ieee80211_hw *hw,struct ath_chanctx *ctx;u32 rfilt; - changed_flags &=SUPPORTED_FILTERS ; *total_flags &=SUPPORTED_FILTERS ;spin_lock_bh (&sc->chan_lock);
Signature · 1 line
2.39.2
Quoted 5 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This has never been used since the driver was merged, but it now causes a W=1 warning in recent clang versions
Quoted 7 lines
drivers/net/wireless/ath/ath9k/main.c:1566:21: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]drivers/net/wireless/ath/ath9k/htc_drv_main.c:1258:25: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]drivers/net/wireless/ath/ath5k/mac80211-ops.c:367:62: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]Remove the bit manipulation on the otherwise unused parameter.
Signed-off-by Arnd Bergmann <[email protected]>
I'm wondering if the ath12k change should be separated into its own patch because 1) it is the most current driver with a dedicated list, and 2) it actually doesn't generate a warning because changed_flags is used, just not in a meaningful way. But I'll let Kalle make the call on that when he returns from holiday.
Signature · 3 lines
ath12k mailing list [email protected] https://lists.infradead.org/mailman/listinfo/ath12k
Quoted 5 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This has never been used since the driver was merged, but it now causes a W=1 warning in recent clang versions
Quoted 7 lines
drivers/net/wireless/ath/ath9k/main.c:1566:21: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]drivers/net/wireless/ath/ath9k/htc_drv_main.c:1258:25: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]drivers/net/wireless/ath/ath5k/mac80211-ops.c:367:62: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]Remove the bit manipulation on the otherwise unused parameter.
Signed-off-by Arnd Bergmann <[email protected]>
For ath9k:
Signature · 3 lines
ath12k mailing list [email protected] https://lists.infradead.org/mailman/listinfo/ath12k
Quoted 7 lines · Arnd Bergmann
This has never been used since the driver was merged, but it now causes a W=1 warning in recent clang versions
drivers/net/wireless/ath/ath9k/main.c:1566:21: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]drivers/net/wireless/ath/ath9k/htc_drv_main.c:1258:25: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]drivers/net/wireless/ath/ath5k/mac80211-ops.c:367:62: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
Quoted 6 lines
Remove the bit manipulation on the otherwise unused parameter.
Signed-off-by Arnd Bergmann <[email protected]>Reviewed-by Jeff Johnson <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
3b86f86d0f16 wifi: ath: remove unused-but-set parameter
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches