Skip to contentSkip to conversation

tools/intel_vbt_decode: Dump mode backlight data

PATCH In review Ville Syrjala 5 participants 5 messages Feb 20, 2023 – Mar 2, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/intel_vbt_decode: Dump mode backlight data

From: Ville Syrjälä <[email protected]>

Dump the new stuff from the backlight block:
- brightness_level
- brightness_min_level
- brightness_precision_bits
- hdr_dpcd_refresh_timeout

---
 tools/intel_vbt_decode.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
tools/intel_vbt_decode.c +15 -0
index 8f707c1f822a..7caa71dac793 100644
@@ -626,6 +626,21 @@ static void dump_backlight_info(struct context *context,
 
 		printf("\t\tControl type: %u\n", control->type);
 		printf("\t\tController: %u\n", control->controller);
+
+		if (context->bdb->version >= 234) {
+			printf("\t\tBrightness level: %u\n",
+			       backlight->brightness_level[i].level);
+			printf("\t\tBrightness min level: %u\n",
+			       backlight->brightness_min_level[i].level);
+		}
+
+		if (context->bdb->version >= 236)
+			printf("\t\tBrigthness precision bits: %u\n",
+			       backlight->brightness_precision_bits[i]);
+
+		if (context->bdb->version >= 239)
+			printf("\t\tHDR DPCD refresh timeout: %.2f ms\n",
+			       backlight->hdr_dpcd_refresh_timeout[i] / 100.0);
 	}
 }
 
Signature · 1 line
2.39.2
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tools/intel_vbt_decode: Dump mode backlight data

== Series Details ==

== Series Details ==

Series: tools/intel_vbt_decode: Dump mode backlight data
URL : https://patchwork.freedesktop.org/series/114197/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12762 -> IGTPW_8511
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_8511 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_8511, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/index.html

Participating hosts (40 -> 37)
------------------------------

Missing (3): bat-kbl-2 bat-dg1-6 fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_8511:

### IGT changes ###

#### Possible regressions ####

* igt@kms_cursor_legacy@basic-flip-before-cursor@atomic:
- fi-kbl-soraka: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/fi-kbl-soraka/igt@kms_cursor_legacy@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/fi-kbl-soraka/igt@kms_cursor_legacy@[email protected]

Known issues
------------

Here are the changes found in IGTPW_8511 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][3] -> [FAIL][4] ([i915#7229])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/fi-pnv-d510/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/fi-pnv-d510/igt@[email protected]

* igt@i915_selftest@live@gt_lrc:
- bat-rpls-1: [PASS][5] -> [INCOMPLETE][6] ([i915#4983])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/bat-rpls-1/igt@i915_selftest@live@gt_lrc.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/bat-rpls-1/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@hangcheck:
- fi-kbl-soraka: [PASS][7] -> [INCOMPLETE][8] ([i915#7913])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/fi-kbl-soraka/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/fi-kbl-soraka/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- bat-rpls-2: [PASS][9] -> [ABORT][10] ([i915#7982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/bat-rpls-2/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/bat-rpls-2/igt@i915_selftest@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][11] ([i915#5354]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/bat-dg2-11/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][12] ([i915#5334] / [i915#7872]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html

[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7166 -> IGTPW_8511

CI-20190529: 20190529
CI_DRM_12762: 7db509313c2f676ff22df731c0e8b1acb4a3d2ba @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8511: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/index.html
IGT_7166: 73a66b9f4418cd14b0c0d20d50cdd4d41053f78c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/index.html

#2 lore raw

Re: [igt-dev] ✗ Fi.CI.BAT: failure for tools/intel_vbt_decode: Dump mode backlight data

Hi,

these are unrelated to change in tools.

Regards,
Kamil

Quoted 110 lines · Patchwork

== Series Details ==

Series: tools/intel_vbt_decode: Dump mode backlight data
URL : https://patchwork.freedesktop.org/series/114197/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12762 -> IGTPW_8511
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_8511 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_8511, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/index.html

Participating hosts (40 -> 37)
------------------------------

Missing (3): bat-kbl-2 bat-dg1-6 fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_8511:

### IGT changes ###

#### Possible regressions ####

* igt@kms_cursor_legacy@basic-flip-before-cursor@atomic:
- fi-kbl-soraka: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/fi-kbl-soraka/igt@kms_cursor_legacy@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/fi-kbl-soraka/igt@kms_cursor_legacy@[email protected]

Known issues
------------

Here are the changes found in IGTPW_8511 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][3] -> [FAIL][4] ([i915#7229])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/fi-pnv-d510/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/fi-pnv-d510/igt@[email protected]

* igt@i915_selftest@live@gt_lrc:
- bat-rpls-1: [PASS][5] -> [INCOMPLETE][6] ([i915#4983])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/bat-rpls-1/igt@i915_selftest@live@gt_lrc.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/bat-rpls-1/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@hangcheck:
- fi-kbl-soraka: [PASS][7] -> [INCOMPLETE][8] ([i915#7913])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/fi-kbl-soraka/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/fi-kbl-soraka/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- bat-rpls-2: [PASS][9] -> [ABORT][10] ([i915#7982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/bat-rpls-2/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/bat-rpls-2/igt@i915_selftest@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][11] ([i915#5354]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/bat-dg2-11/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][12] ([i915#5334] / [i915#7872]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html

[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7166 -> IGTPW_8511

CI-20190529: 20190529
CI_DRM_12762: 7db509313c2f676ff22df731c0e8b1acb4a3d2ba @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8511: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/index.html
IGT_7166: 73a66b9f4418cd14b0c0d20d50cdd4d41053f78c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/index.html

#3 lore raw

Re: [igt-dev] ✗ Fi.CI.BAT: failure for tools/intel_vbt_decode: Dump mode backlight data

Hi @Kamil Konieczny,

Can you re run the PW series since CI_DRM_12762 has become old and will fail to re-report.

Thanks,
Y Sai Nandan

-----Original Message-----
From: Kamil Konieczny <[email protected]>
Sent: Wednesday, March 1, 2023 1:44 AM
To: [email protected]
Cc: Ville Syrjala <[email protected]>; Vudum, Lakshminarayana <[email protected]>; Yedireswarapu, SaiX Nandan <[email protected]>
Subject: Re: [igt-dev] ✗ Fi.CI.BAT: failure for tools/intel_vbt_decode: Dump mode backlight data

Hi,

these are unrelated to change in tools.

Regards,
Kamil

Quoted 127 lines · Patchwork

== Series Details ==

Series: tools/intel_vbt_decode: Dump mode backlight data
URL : https://patchwork.freedesktop.org/series/114197/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12762 -> IGTPW_8511
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_8511 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_8511, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/index.html

Participating hosts (40 -> 37)
------------------------------

Missing (3): bat-kbl-2 bat-dg1-6 fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_8511:

### IGT changes ###

#### Possible regressions ####

* igt@kms_cursor_legacy@basic-flip-before-cursor@atomic:
- fi-kbl-soraka: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/fi-kbl-soraka/igt@kms_cursor_legacy@[email protected]
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/fi-kbl-soraka/igt@
kms_cursor_legacy@[email protected]

Known issues
------------

Here are the changes found in IGTPW_8511 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][3] -> [FAIL][4] ([i915#7229])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/fi-pnv-d510/igt@[email protected]
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/fi-pnv-d510/igt@ge
[email protected]

* igt@i915_selftest@live@gt_lrc:
- bat-rpls-1: [PASS][5] -> [INCOMPLETE][6] ([i915#4983])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/bat-rpls-1/igt@i915_selftest@live@gt_lrc.html
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/bat-rpls-1/igt@i91
5_selftest@live@gt_lrc.html

* igt@i915_selftest@live@hangcheck:
- fi-kbl-soraka: [PASS][7] -> [INCOMPLETE][8] ([i915#7913])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/fi-kbl-soraka/igt@i915_selftest@[email protected]
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/fi-kbl-soraka/igt@
i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- bat-rpls-2: [PASS][9] -> [ABORT][10] ([i915#7982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/bat-rpls-2/igt@i915_selftest@[email protected]
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/bat-rpls-2/igt@i91
5_selftest@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][11] ([i915#5354]) +2 similar issues
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/bat-dg2-11/igt@kms
[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][12] ([i915#5334] / [i915#7872]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12762/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/fi-kbl-soraka/igt@
i915_selftest@live@gt_heartbeat.html

[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7166 -> IGTPW_8511

CI-20190529: 20190529
CI_DRM_12762: 7db509313c2f676ff22df731c0e8b1acb4a3d2ba @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8511: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/index.html
IGT_7166: 73a66b9f4418cd14b0c0d20d50cdd4d41053f78c @
https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8511/index.html

Reviewed-by on v1 1/1
#4 lore raw
In reply to Ville Syrjala
Quoted 9 lines · Ville Syrjala

From: Ville Syrjälä <[email protected]>

Dump the new stuff from the backlight block:
- brightness_level
- brightness_min_level
- brightness_precision_bits
- hdr_dpcd_refresh_timeout

Quoted 29 lines
---
 tools/intel_vbt_decode.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
tools/intel_vbt_decode.c +15 -0
index 8f707c1f822a..7caa71dac793 100644
@@ -626,6 +626,21 @@ static void dump_backlight_info(struct context *context,
 
 		printf("\t\tControl type: %u\n", control->type);
 		printf("\t\tController: %u\n", control->controller);
+
+		if (context->bdb->version >= 234) {
+			printf("\t\tBrightness level: %u\n",
+			       backlight->brightness_level[i].level);
+			printf("\t\tBrightness min level: %u\n",
+			       backlight->brightness_min_level[i].level);
+		}
+
+		if (context->bdb->version >= 236)
+			printf("\t\tBrigthness precision bits: %u\n",
+			       backlight->brightness_precision_bits[i]);
+
+		if (context->bdb->version >= 239)
+			printf("\t\tHDR DPCD refresh timeout: %.2f ms\n",
+			       backlight->hdr_dpcd_refresh_timeout[i] / 100.0);
 	}
 }
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center