Fixes bc2c23549ccd ("ALSA: hda/realtek: Add pincfg for ASUS G533Z HP jack")
PATCH 1/1 Fixes bc2c23549ccd ("ALSA: hda/realtek: Add pincfg for ASUS G533Z HP jack")
The initial fix for ASUS G533Z was based on faulty information. This fixes the pincfg to values that have been verified with no existing module options or other hacks enabled.
Enables headphone jack, and 5.1 surround.
--- sound/pci/hda/patch_realtek.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
sound/pci/hda/patch_realtek.c +6 -4
@@ -8449,11 +8449,13 @@ static const struct hda_fixup alc269_fixups[] = { [ALC285_FIXUP_ASUS_G533Z_PINS] = { .type = HDA_FIXUP_PINS, .v.pins = (const struct hda_pintbl []) { - {0x14 ,0x90170120 }, - { } + {0x14 ,0x90170152 },/* Speaker Surround Playback Switch */ + {0x19 ,0x03a19020 },/* Mic Boost Volume */ + {0x1a ,0x03a11c30 },/* Mic Boost Volume */ + {0x1e ,0x90170151 },/* Rear jack, IN OUT EAPD Detect */ + {0x21 ,0x03211420 }, + { } }, - .chained = true, - .chain_id = ALC294_FIXUP_ASUS_G513_PINS, }, [ALC294_FIXUP_ASUS_COEF_1B] = { .type = HDA_FIXUP_VERBS,
Signature · 1 line
2.37.3
Quoted 8 lines · Luke D. Jones
The initial fix for ASUS G533Z was based on faulty information. This fixes the pincfg to values that have been verified with no existing module options or other hacks enabled.
Enables headphone jack, and 5.1 surround.
Signed-off-by Luke D. Jones <[email protected]>
The changes look OK, but the subject line should be rather describing what about the patch is about. I corrected the subject and put the proper Fixes tag (as well as Cc-to-stable).
Also, the indent level wasn't right, so I corrected it locally, too.
thanks,
Takashi
Quoted 10 lines · Takashi Iwai
Quoted 8 lines · Luke D. Jones
The initial fix for ASUS G533Z was based on faulty information. This
fixes the pincfg to values that have been verified with no existing module options or other hacks enabled.Enables headphone jack, and 5.1 surround.
Quoted 7 lines
Quoted 1 line
Signed-off-by Luke D. Jones <[email protected]>The changes look OK, but the subject line should be rather describing what about the patch is about. I corrected the subject and put the proper Fixes tag (as well as Cc-to-stable).
Also, the indent level wasn't right, so I corrected it locally, too.
Oh... Sorry about the hassle there, I could have sworn it was correct. Thanks for accepting regardless :)
Quoted 4 lines
thanks,
Takashi