Skip to contentSkip to conversation

package/directfb: disable on riscv32

PATCH New Fabrice Fontaine 3 participants 3 messages May 27, 2021 – Jun 10, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/directfb: disable on riscv32

directfb unconditionally uses __NR_futex which will raise the following build failure on riscv32:

system.c:242:21: error: '__NR_futex' undeclared (first use in this function)

  242 |      ret = syscall( __NR_futex, uaddr, op, val, timeout, uaddr2, val3 );
      |                     ^~~~~~~~~~

Fixes:
- http://autobuild.buildroot.org/results/c0f4168575fa85af933539441eea95a3b10dac91

---
 package/directfb/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/directfb/Config.in +2 -0
index 20481f56da..f4d6b8cbd1 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_DIRECTFB
 	bool "directfb"
+	depends on !BR2_RISCV_32
 	depends on !BR2_STATIC_LIBS # static link issues
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_INSTALL_LIBSTDCPP
@@ -161,6 +162,7 @@ config BR2_PACKAGE_DIRECTFB_TESTS
 endif # BR2_PACKAGE_DIRECTFB
 
 comment "directfb needs a glibc or uClibc toolchain w/ C++, NPTL, gcc >= 4.5, dynamic library"
+	depends on !BR2_RISCV_32
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 || BR2_TOOLCHAIN_USES_MUSL || \
Signature · 1 line
2.30.2
#1 lore raw

PATCH 1/1 package/directfb: disable on riscv32

Quoted 5 lines · Fabrice Fontaine

directfb unconditionally uses __NR_futex which will raise the following build failure on riscv32:

system.c:242:21: error: '__NR_futex' undeclared (first use in this function)
242 | ret = syscall( __NR_futex, uaddr, op, val, timeout, uaddr2, val3 );

This could probably be fixed by using __NR_futex64, but directfb is pretty dead
anyway.

Applied to master, thanks.

Regards,
Arnout

Quoted 30 lines
      |                     ^~~~~~~~~~

Fixes:
- http://autobuild.buildroot.org/results/c0f4168575fa85af933539441eea95a3b10dac91

---
 package/directfb/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/directfb/Config.in +2 -0
index 20481f56da..f4d6b8cbd1 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_DIRECTFB
 	bool "directfb"
+	depends on !BR2_RISCV_32
 	depends on !BR2_STATIC_LIBS # static link issues
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_INSTALL_LIBSTDCPP
@@ -161,6 +162,7 @@ config BR2_PACKAGE_DIRECTFB_TESTS
 endif # BR2_PACKAGE_DIRECTFB
 
 comment "directfb needs a glibc or uClibc toolchain w/ C++, NPTL, gcc >= 4.5, dynamic library"
+	depends on !BR2_RISCV_32
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 || BR2_TOOLCHAIN_USES_MUSL || \
#2 lore raw

PATCH 1/1 package/directfb: disable on riscv32

In reply to Fabrice Fontaine
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

directfb unconditionally uses __NR_futex which will raise the following build failure on riscv32:

Quoted 8 lines

system.c:242:21: error: '__NR_futex' undeclared (first use in this function)

  242 |      ret = syscall( __NR_futex, uaddr, op, val, timeout, uaddr2, val3 );
      |                     ^~~~~~~~~~

Fixes:
- http://autobuild.buildroot.org/results/c0f4168575fa85af933539441eea95a3b10dac91

Committed to 2021.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard