Skip to contentSkip to conversation

linux: don't check hashes for user-supplied patches

PATCH New Yann E. MORIN 3 participants 3 messages Feb 16, 2019 – Feb 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 linux: don't check hashes for user-supplied patches

We have virtually no way to know the hashes for user-supplied patches, so we should just ignore them.

Cc Thomas Petazzoni <[email protected]>
Cc Arnout Vandecappelle <[email protected]>
Cc Peter Korsgaard <[email protected]>

---
Peter: this is a candidate for backporting to 2018.11.x and 2018.02.x

---
 linux/linux.mk | 3 +++
 1 file changed, 3 insertions(+)
linux/linux.mk +3 -0
index 8c21bad067..2b5d096e14 100644
@@ -55,6 +55,9 @@ endif
 
 LINUX_PATCHES = $(call qstrip,$(BR2_LINUX_KERNEL_PATCH))
 
+# We have no way to know the hashes for user-supplied patches.
+BR_NO_CHECK_HASH_FOR += $(notdir $(LINUX_PATCHES))
+
 # We rely on the generic package infrastructure to download and apply
 # remote patches (downloaded from ftp, http or https). For local
 # patches, we can't rely on that infrastructure, because there might
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 linux: don't check hashes for user-supplied patches

Quoted 6 lines · Yann E. MORIN

We have virtually no way to know the hashes for user-supplied patches, so we should just ignore them.

Quoted 25 lines
Cc Thomas Petazzoni <[email protected]>
Cc Arnout Vandecappelle <[email protected]>
Cc Peter Korsgaard <[email protected]>

---
Peter: this is a candidate for backporting to 2018.11.x and 2018.02.x

---
 linux/linux.mk | 3 +++
 1 file changed, 3 insertions(+)
linux/linux.mk +3 -1
index 8c21bad067..2b5d096e14 100644
@@ -55,6 +55,9 @@ endif
 
 LINUX_PATCHES = $(call qstrip,$(BR2_LINUX_KERNEL_PATCH))
 
+# We have no way to know the hashes for user-supplied patches.
+BR_NO_CHECK_HASH_FOR += $(notdir $(LINUX_PATCHES))
+
 # We rely on the generic package infrastructure to download and apply
 # remote patches (downloaded from ftp, http or https). For local
 # patches, we can't rely on that infrastructure, because there might
--
Quoted 2 lines

2.14.1

Did a test build with this patch applied and the kernel patches are now correctly applied without failing the hash check :) Thanks for the quick fix!

Simon

#2 lore raw

PATCH 1/1 linux: don't check hashes for user-supplied patches

In reply to Yann E. MORIN
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

We have virtually no way to know the hashes for user-supplied patches, so we should just ignore them.

Quoted 8 lines
Cc Thomas Petazzoni <[email protected]>
Cc Arnout Vandecappelle <[email protected]>
Cc Peter Korsgaard <[email protected]>

---
Peter: this is a candidate for backporting to 2018.11.x and 2018.02.x

Committed to 2018.02.x and 2018.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard