Skip to contentSkip to conversation

fs/common.mk: Fix show-build-order

PATCH New Serj Kalichev 3 participants 5 messages Nov 15, 2018 – Nov 26, 2018 VFS

lore
Share & tools
lore

Serj Kalichev

author
#0 lore raw

PATCH 1/1 fs/common.mk: Fix show-build-order

The command "make show-build-order" doesn't show dependencies of rootfs-common target.

This patch adds $(ROOTFS_COMMON_DEPENDENCIES) to PACKAGES variable.

Signed-off-by Serj Kalichev <[email protected]>
---
 fs/common.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/common.mk +1 -1
index 358801d44f..e4a6a4897b 100644
@@ -148,7 +148,7 @@ rootfs-$(1): $$(BINARIES_DIR)/rootfs.$(1)
 
 ifeq ($$(BR2_TARGET_ROOTFS_$(2)),y)
 TARGETS_ROOTFS += rootfs-$(1)
-PACKAGES += $$(filter-out rootfs-%,$$(ROOTFS_$(2)_DEPENDENCIES))
+PACKAGES += $$(filter-out rootfs-%,$$(ROOTFS_$(2)_DEPENDENCIES) $$(ROOTFS_COMMON_DEPENDENCIES))
 endif
 
 # Check for legacy POST_TARGETS rules
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 fs/common.mk: Fix show-build-order

Serj, All,

On 2018-11-15 18:25 +0300, Serj Kalichev spake thusly:

Quoted 5 lines

The command "make show-build-order" doesn't show dependencies of rootfs-common target.

This patch adds $(ROOTFS_COMMON_DEPENDENCIES) to PACKAGES variable.

Signed-off-by Serj Kalichev <[email protected]>
Reviewed-by "Yann E. MORIN" <[email protected]>

(I would still have preferred they be added to the _DEPENDENCIES list, but others disagreed, so...)

Regards,
Yann E. MORIN.

Quoted 24 lines
---
 fs/common.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/common.mk +1 -1
index 358801d44f..e4a6a4897b 100644
@@ -148,7 +148,7 @@ rootfs-$(1): $$(BINARIES_DIR)/rootfs.$(1)
 
 ifeq ($$(BR2_TARGET_ROOTFS_$(2)),y)
 TARGETS_ROOTFS += rootfs-$(1)
-PACKAGES += $$(filter-out rootfs-%,$$(ROOTFS_$(2)_DEPENDENCIES))
+PACKAGES += $$(filter-out rootfs-%,$$(ROOTFS_$(2)_DEPENDENCIES) $$(ROOTFS_COMMON_DEPENDENCIES))
 endif
 
 # Check for legacy POST_TARGETS rules
Signature · 6 lines
2.17.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 fs/common.mk: Fix show-build-order

Serj, All,

On 2018-11-15 17:35 +0100, Yann E. MORIN spake thusly:

Quoted 11 lines

On 2018-11-15 18:25 +0300, Serj Kalichev spake thusly:

Quoted 5 lines

The command "make show-build-order" doesn't show dependencies of rootfs-common target.

This patch adds $(ROOTFS_COMMON_DEPENDENCIES) to PACKAGES variable.

Signed-off-by Serj Kalichev <[email protected]>
Reviewed-by "Yann E. MORIN" <[email protected]>

(I would still have preferred they be added to the _DEPENDENCIES list, but others disagreed, so...)

I somehow got confused to see that patch pop up on the list, wen Thomas said he had integrated it in his PPS series.

It turns out that the previous thread was started by Andreas:

    http://lists.busybox.net/pipermail/buildroot/2018-November/thread.html#235256

This patch by Serj confused me because the reason for that same change is totally different (but as valid).

My Reviewed-by tag still stands, obviously.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/1 fs/common.mk: Fix show-build-order

In reply to Serj Kalichev
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Serj" == Serj Kalichev <[email protected]> writes:

The command "make show-build-order" doesn't show dependencies of rootfs-common target. This patch adds $(ROOTFS_COMMON_DEPENDENCIES) to PACKAGES variable.

Signed-off-by Serj Kalichev <[email protected]>

Committed to 2018.02.x and 2018.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard