Skip to contentSkip to conversation

This patch is to add NVME tool support in petitboot

PATCH New Mamatha 2 participants 3 messages Jan 11, 2016 – Jan 12, 2016

lore
Share & tools
lore

Mamatha

author
#0 lore raw

PATCH 1/1 This patch is to add NVME tool support in petitboot

Enable NVME block device and nvme tool support in petitboot After enabling NVME device and tool in op-build this will increase the size of rootfs.tar by 92KB and zImage.epapr by 41KB.

Signed-off-by Mamatha <[email protected]>
---
 package/Config.in      |    1 +
 package/nvme/Config.in |    6 ++++++
 package/nvme/nvme.mk   |   23 +++++++++++++++++++++++
 3 files changed, 30 insertions(+)
 create mode 100755 package/nvme/Config.in
 create mode 100755 package/nvme/nvme.mk
package/Config.in +1 -0
index e0c2e2a..014debd 100644
@@ -1399,6 +1399,7 @@ endif
 	source "package/openvmtools/Config.in"
 	source "package/polkit/Config.in"
 	source "package/powerpc-utils/Config.in"
+	source "package/nvme/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	source "package/procps-ng/Config.in"
 	source "package/psmisc/Config.in"
package/nvme/Config.in new file +6 -0
new file mode 100755
index 0000000..8b5d37d
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_NVME
+	bool "nvme"
+	help
+	  System utilities for IBM Power NVME devices
+
+	  https://github.com/linux-nvme/nvme-cli
package/nvme/nvme.mk new file +23 -0
new file mode 100755
index 0000000..214e879
@@ -0,0 +1,23 @@
+################################################################################
+#
+# nvme
+#
+################################################################################
+
+NVME_VERSION = 798812627467a9999682176ade631ee5b6ea4785
+NVME_SITE = https://github.com/linux-nvme/nvme-cli.git
+NVME_SITE_METHOD = git
+NVME_LICENSE = GPLv2
+NVME_LICENSE_FILES = COPYING
+
+define NVME_BUILD_CMDS
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
+		INCLUDEDIR="-I." all
+endef
+
+define NVME_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/nvme $(TARGET_DIR)/sbin/nvme
+endef
+
+$(eval $(generic-package))
+
#1 lore raw

PATCH 1/1 This patch is to add NVME tool support in petitboot

(background for others: petitboot is the bootloader on OpenPower machines - it's a linux+initramfs in flash from buildroot on top of OPAL firmware. You can exit from the petitboot UI into a shell, where a variety of utilities are available to help rescue a system)

Quoted 3 lines · Mamatha

Enable NVME block device and nvme tool support in petitboot After enabling NVME device and tool in op-build this will increase the size of rootfs.tar by 92KB and zImage.epapr by 41KB.

I think this should read more like:

"Add support for building NVME utility - a utility for interacting with standard NVM Express (optimized PCI Express SSD interface) devices."

Quoted 28 lines
Signed-off-by Mamatha <[email protected]>
---
 package/Config.in      |    1 +
 package/nvme/Config.in |    6 ++++++
 package/nvme/nvme.mk   |   23 +++++++++++++++++++++++
 3 files changed, 30 insertions(+)
 create mode 100755 package/nvme/Config.in
 create mode 100755 package/nvme/nvme.mk
package/Config.in +1 -0
index e0c2e2a..014debd 100644
@@ -1399,6 +1399,7 @@ endif
 	source "package/openvmtools/Config.in"
 	source "package/polkit/Config.in"
 	source "package/powerpc-utils/Config.in"
+	source "package/nvme/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	source "package/procps-ng/Config.in"
 	source "package/psmisc/Config.in"
package/nvme/Config.in new file +0 -0
new file mode 100755
index 0000000..8b5d37d

package/nvme/Config.in line 6

Quoted 6 lines
package/nvme/Config.in new file +6 -0
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_NVME
+	bool "nvme"
+	help
+	  System utilities for IBM Power NVME devices
+
+	  https://github.com/linux-nvme/nvme-cli

Is it POWER specific? It doesn't look like it...

package/nvme/nvme.mk line 7

Quoted 13 lines
package/nvme/nvme.mk new file +7 -0
new file mode 100755
index 0000000..214e879
@@ -0,0 +1,23 @@
+################################################################################
+#
+# nvme
+#
+################################################################################
+
+NVME_VERSION = 798812627467a9999682176ade631ee5b6ea4785

Is this the 0.2 tag? If not, why not? It would seem sensible to include the most recent released version, or get them to release one with the support we need.

Also,

package/nvme/nvme.mk line 8

Quoted 1 line
package/nvme/nvme.mk new file +1 -0
+NVME_SITE = https://github.com/linux-nvme/nvme-cli.git

I wonder why this utility isn't mentioned on
http://nvmexpress.org/resources/linux-driver-information/ ?

Signature · 2 lines
Stewart Smith
OPAL Architect, IBM.
author
#2 lore raw

PATCH 1/1 This patch is to add NVME tool support in petitboot

Thanks for reviewing the patch.

Quoted 40 lines · Stewart Smith

(background for others: petitboot is the bootloader on OpenPower machines - it's a linux+initramfs in flash from buildroot on top of OPAL firmware. You can exit from the petitboot UI into a shell, where a variety of utilities are available to help rescue a system)

Quoted 3 lines · Mamatha

Enable NVME block device and nvme tool support in petitboot After enabling NVME device and tool in op-build this will increase the size of rootfs.tar by 92KB and zImage.epapr by 41KB.

I think this should read more like:

"Add support for building NVME utility - a utility for interacting with standard NVM Express (optimized PCI Express SSD interface) devices.

Quoted 26 lines
Signed-off-by Mamatha <[email protected]>
---
  package/Config.in      |    1 +
  package/nvme/Config.in |    6 ++++++
  package/nvme/nvme.mk   |   23 +++++++++++++++++++++++
  3 files changed, 30 insertions(+)

create mode 100755 package/nvme/Config.in
create mode 100755 package/nvme/nvme.mk

package/Config.in +1 -0
index e0c2e2a..014debd 100644
@@ -1399,6 +1399,7 @@ endif
  	source "package/openvmtools/Config.in"
  	source "package/polkit/Config.in"
  	source "package/powerpc-utils/Config.in"
+	source "package/nvme/Config.in"
  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
  	source "package/procps-ng/Config.in"
  	source "package/psmisc/Config.in"
package/nvme/Config.in new file +0 -0
new file mode 100755
index 0000000..8b5d37d
Quoted 8 lines

package/nvme/Config.in line 6

Quoted 7 lines
package/nvme/Config.in new file +6 -0
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_NVME
+	bool "nvme"
+	help
+	  System utilities for IBM Power NVME devices
+
+	  https://github.com/linux-nvme/nvme-cli

Is it POWER specific? It doesn't look like it...

ok, I will update this

Quoted 17 lines
Quoted 7 lines
package/nvme/nvme.mk new file +0 -0
new file mode 100755
index 0000000..214e879

package/nvme/nvme.mk line 7

Quoted 7 lines
package/nvme/nvme.mk new file +7 -0
@@ -0,0 +1,23 @@
+################################################################################
+#
+# nvme
+#
+################################################################################
+
+NVME_VERSION = 798812627467a9999682176ade631ee5b6ea4785

Is this the 0.2 tag? If not, why not? It would seem sensible to include the most recent released version, or get them to release one with the support we need

I have updated the NVME version in V2 patch, which I have sent yesterday.

Quoted 7 lines

Also,

package/nvme/nvme.mk line 8

Quoted 1 line
package/nvme/nvme.mk new file +1 -0
+NVME_SITE = https://github.com/linux-nvme/nvme-cli.git

I wonder why this utility isn't mentioned on
http://nvmexpress.org/resources/linux-driver-information/ ?