Skip to contentSkip to conversation

package/rt-tests: fix Kconfig syntax

PATCH New Yann E. MORIN 3 participants 3 messages Feb 23, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/rt-tests: fix Kconfig syntax

From: "Yann E. MORIN" <[email protected]>

Fixes:

    $ make menuconfig
    [...]
    package/rt-tests/Config.in:10: syntax error
    package/rt-tests/Config.in:9: invalid option
    package/rt-tests/Config.in:36: syntax error
    package/rt-tests/Config.in:35: invalid option
    make[1]: *** [oldconfig] Error 1
    make: *** [_all] Error 2
---
 package/rt-tests/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/rt-tests/Config.in +3 -3
index ff4284e..605635c 100644
@@ -6,8 +6,8 @@ config BR2_PACKAGE_RT_TESTS
 	# no NPTL for these archs
 	depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc && !BR2_bfin
 	# no _tid field in 'struct sigevent'
-	depends on !BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
-		BR2_mips64 || BR2_mips64el)
+	depends on ! ( BR2_TOOLCHAIN_USES_UCLIBC && (BR2_mips || BR2_mipsel || \
+		BR2_mips64 || BR2_mips64el) )
 	help
 	  Set of utilities for testing the real-time behaviour of a
 	  Linux system.
@@ -32,5 +32,5 @@ comment "rt-tests needs a toolchain w/ threads"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
 
 comment "rt-tests needs an (e)glibc toolchain"
-	depends on BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
+	depends on BR2_TOOLCHAIN_USES_UCLIBC && (BR2_mips || BR2_mipsel || \
 		BR2_mips64 || BR2_mips64el)
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 package/rt-tests: fix Kconfig syntax

Dear Yann E. MORIN,

package/rt-tests/Config.in config BR2_PACKAGE_RT_TESTS · line 10

Quoted 12 lines · Yann E. MORIN
package/rt-tests/Config.in +2 -2
index ff4284e..605635c 100644
@@ -6,8 +6,8 @@ config BR2_PACKAGE_RT_TESTS
 	# no NPTL for these archs
 	depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc && !BR2_bfin
 	# no _tid field in 'struct sigevent'
-	depends on !BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
-		BR2_mips64 || BR2_mips64el)
+	depends on ! ( BR2_TOOLCHAIN_USES_UCLIBC && (BR2_mips || BR2_mipsel || \
+		BR2_mips64 || BR2_mips64el) )

I know it's nitpicking, but I must say I personally dislike these spaces between !, parenthesis and the rest. I very much prefer:

	depends on !(BR2_TOOLCHAIN_USES_UCLIBC && (BR2_mips || BR2_mipsel || \
		BR2_mips64 || BR2_mips64el))

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 package/rt-tests: fix Kconfig syntax

In reply to Yann E. MORIN
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

From: "Yann E. MORIN" <[email protected]>
Fixes:

    $ make menuconfig
    [...]
    package/rt-tests/Config.in:10: syntax error
    package/rt-tests/Config.in:9: invalid option
    package/rt-tests/Config.in:36: syntax error
    package/rt-tests/Config.in:35: invalid option
    make[1]: *** [oldconfig] Error 1
    make: *** [_all] Error 2
Quoted 2 lines

Sorry, I already fixed it myself (in the same way) before I saw your patch.

Signature · 1 line
Bye, Peter Korsgaard