Skip to contentSkip to conversation

mmc: dw_mmc: fix fifo access for 64-bit

PATCH RESEND In review Seungwon Jeon 3 participants 3 messages Mar 25, 2013 – Apr 4, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 mmc: dw_mmc: fix fifo access for 64-bit

mci_writew causes a failure of fifo access for 64-bit. mci_writeq is correct.

---
 drivers/mmc/host/dw_mmc.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/mmc/host/dw_mmc.c +2 -1
index a443820..753c55c 100644
@@ -1373,8 +1373,9 @@ static void dw_mci_push_data64(struct dw_mci *host, void *buf, int cnt)
 		int len = dw_mci_push_part_bytes(host, buf, cnt);
 		buf += len;
 		cnt -= len;
+
 		if (host->part_buf_count == 8) {
-			mci_writew(host, DATA(host->data_offset),
+			mci_writeq(host, DATA(host->data_offset),
 					host->part_buf);
 			host->part_buf_count = 0;
 		}
Signature · 1 line
1.7.0.4
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 24 lines · Seungwon Jeon

mci_writew causes a failure of fifo access for 64-bit. mci_writeq is correct.

---
 drivers/mmc/host/dw_mmc.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/mmc/host/dw_mmc.c +2 -1
index a443820..753c55c 100644
@@ -1373,8 +1373,9 @@ static void dw_mci_push_data64(struct dw_mci *host, void *buf, int cnt)
 		int len = dw_mci_push_part_bytes(host, buf, cnt);
 		buf += len;
 		cnt -= len;
+
 		if (host->part_buf_count == 8) {
-			mci_writew(host, DATA(host->data_offset),
+			mci_writeq(host, DATA(host->data_offset),
 					host->part_buf);
 			host->part_buf_count = 0;
 		}
#2 lore raw
In reply to Seungwon Jeon

Hi,

Quoted 13 lines · Seungwon Jeon

mci_writew causes a failure of fifo access for 64-bit. mci_writeq is correct.

---
 drivers/mmc/host/dw_mmc.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/mmc/host/dw_mmc.c +0 -0
index a443820..753c55c 100644

drivers/mmc/host/dw_mmc.c static void dw_mci_push_data64(struct dw_mci *host, void *buf, int cnt) · line 1381

Quoted 10 lines
drivers/mmc/host/dw_mmc.c +2 -1
@@ -1373,8 +1373,9 @@ static void dw_mci_push_data64(struct dw_mci *host, void *buf, int cnt)
 		int len = dw_mci_push_part_bytes(host, buf, cnt);
 		buf += len;
 		cnt -= len;
+
 		if (host->part_buf_count == 8) {
-			mci_writew(host, DATA(host->data_offset),
+			mci_writeq(host, DATA(host->data_offset),
 					host->part_buf);
 			host->part_buf_count = 0;
 		}

Thanks, pushed to mmc-next for 3.10.

- Chris.

Signature · 2 lines
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child