Skip to contentSkip to conversation

fbdump: only build VGA16 support on x86/x86-64

PATCH New Thomas Petazzoni 2 participants 2 messages Sep 18, 2012 – Sep 20, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fbdump: only build VGA16 support on x86/x86-64

The VGA16 dumping feature probably doesn't make much sense on anything else than x86 and x86-64, as it is accessing I/O ports that seem PC-specific.

Moreover, some architectures such as SH4, do not have an implementation of outw() in uClibc, but we quite certainly don't care about VGA16 support for such architectures.

Fixes:

http://autobuild.buildroot.org/results/e1c860830dd585830cf5ca5f935b81856e992334/build-end.log

---
 package/fbdump/fbdump.mk |    9 +++++++++
 1 file changed, 9 insertions(+)
package/fbdump/fbdump.mk +9 -0
index 3ca10bf..820ae96 100644
@@ -9,4 +9,13 @@ FBDUMP_SITE:=http://www.rcdrummond.net/fbdump
 FBDUMP_LICENSE = GPLv2
 FBDUMP_LICENSE_FILES = COPYING
 
+# The VGA16 specific feature of fbdump doesn't make much sense outside
+# of the x86/x86-64 architectures, and causes build problems on some
+# architectures as outw() is not always available.
+ifeq ($(BR2_i386)$(BR2_x86_64),y)
+FBDUMP_CONF_OPT += --enable-vga16fb
+else
+FBDUMP_CONF_OPT += --disable-vga16fb
+endif
+
 $(eval $(autotools-package))
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 fbdump: only build VGA16 support on x86/x86-64

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> The VGA16 dumping feature probably doesn't make much sense on anything Thomas> else than x86 and x86-64, as it is accessing I/O ports that seem Thomas> PC-specific.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard