Skip to contentSkip to conversation

ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data

PATCH New Vaibhav Hiremath 4 participants 6 messages May 11, 2012 – Jun 18, 2012

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Vaibhav Hiremath

author
#0 lore raw

PATCH 1/1 ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data

From: Kevin Hilman <[email protected]>

There are certain fields inside 'struct dpll_data' which are included under ARCH_OMAP3 and ARCH_OMAP4 option, which makes it difficult to use it for new devices like, am33xx, ti81xx, etc...

So remove the ifdef completely, this will add few fields to the struct unused, but it improves readability and maintainability of the code.

Signed-off-by Kevin Hilman <[email protected]>
Signed-off-by Vaibhav Hiremath <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Santosh Shilimkar <[email protected]>
Cc R Sricharan <[email protected]>

---
Since Kevin had provided this idea and code change, making this patch under his authorship.

 arch/arm/plat-omap/include/plat/clock.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/arm/plat-omap/include/plat/clock.h +0 -2
index d0ef57c..656b986 100644
@@ -156,7 +156,6 @@ struct dpll_data {
 	u8			min_divider;
 	u16			max_divider;
 	u8			modes;
-#if defined(CONFIG_ARCH_OMAP3) || defined(CONFIG_ARCH_OMAP4)
 	void __iomem		*autoidle_reg;
 	void __iomem		*idlest_reg;
 	u32			autoidle_mask;

@@ -167,7 +166,6 @@ struct dpll_data {
 	u8			auto_recal_bit;
 	u8			recal_en_bit;
 	u8			recal_st_bit;
-#  endif
 	u8			flags;
 };

--
1.7.0.4

#1 lore raw

PATCH 1/1 ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data

Quoted 9 lines · Vaibhav Hiremath

From: Kevin Hilman <[email protected]>

There are certain fields inside 'struct dpll_data' which are included under ARCH_OMAP3 and ARCH_OMAP4 option, which makes it difficult to use it for new devices like, am33xx, ti81xx, etc...

So remove the ifdef completely, this will add few fields to the struct unused, but it improves readability and maintainability of the code.

Quoted 7 lines
Signed-off-by Kevin Hilman <[email protected]>
Signed-off-by Vaibhav Hiremath <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Santosh Shilimkar <[email protected]>
Cc R Sricharan <[email protected]>

---

Acked-by Santosh Shilimkar <[email protected]>
#2 lore raw

PATCH 1/1 ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data

In reply to Vaibhav Hiremath
Quoted 15 lines · Vaibhav Hiremath

From: Kevin Hilman <[email protected]>

There are certain fields inside 'struct dpll_data' which are included under ARCH_OMAP3 and ARCH_OMAP4 option, which makes it difficult to use it for new devices like, am33xx, ti81xx, etc...

So remove the ifdef completely, this will add few fields to the struct unused, but it improves readability and maintainability of the code.

Signed-off-by Kevin Hilman <[email protected]>
Signed-off-by Vaibhav Hiremath <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Santosh Shilimkar <[email protected]>
Cc R Sricharan <[email protected]>
Quoted 3 lines

---
Since Kevin had provided this idea and code change, making this patch under his authorship.

Be sure to give yourself credit for writing the changelog. Normally, if you make changes/additions to patch, you can add a line just before your signoff. Something like:

[hvaibhav at ti.com: wrote detailed changelog]

Kevin

author
#3 lore raw

PATCH 1/1 ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data

Quoted 21 lines · Kevin
Quoted 15 lines · Vaibhav Hiremath

From: Kevin Hilman <[email protected]>

There are certain fields inside 'struct dpll_data' which are included under ARCH_OMAP3 and ARCH_OMAP4 option, which makes it difficult to use it for new devices like, am33xx, ti81xx, etc...

So remove the ifdef completely, this will add few fields to the struct unused, but it improves readability and maintainability of the code.

Signed-off-by Kevin Hilman <[email protected]>
Signed-off-by Vaibhav Hiremath <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Santosh Shilimkar <[email protected]>
Cc R Sricharan <[email protected]>
Quoted 3 lines

---
Since Kevin had provided this idea and code change, making this patch under his authorship.

Quoted 6 lines

Be sure to give yourself credit for writing the changelog. Normally, if you make changes/additions to patch, you can add a line just before your signoff. Something like:

[hvaibhav at ti.com: wrote detailed changelog]

Ok...

Paul,
Can you please add above statement, when you merge it into your repo?

Thanks,
Vaibhav

#4 lore raw

PATCH 1/1 ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data

Quoted 2 lines · Vaibhav

Paul,
Can you please add above statement, when you merge it into your repo?

Added this, and added Santosh's ack, and queued for 3.6.

- Paul

author
#5 lore raw

PATCH 1/1 ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data

In reply to Kevin Hilman
Quoted 11 lines · Kevin
Quoted 9 lines · Vaibhav Hiremath

From: Kevin Hilman <[email protected]>

There are certain fields inside 'struct dpll_data' which are included under ARCH_OMAP3 and ARCH_OMAP4 option, which makes it difficult to use it for new devices like, am33xx, ti81xx, etc...

So remove the ifdef completely, this will add few fields to the struct unused, but it improves readability and maintainability of the code.

Quoted 7 lines
Quoted 7 lines
Signed-off-by Kevin Hilman <[email protected]>
Signed-off-by Vaibhav Hiremath <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Santosh Shilimkar <[email protected]>
Cc R Sricharan <[email protected]>

---

Tony,

Ping on this as well???

Thanks,
Vaibhav

Quoted 1 line