Skip to contentSkip to conversation

Add gst-av package

PATCH New Felipe Contreras 3 participants 8 messages Feb 11, 2012 – Feb 12, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add gst-av package

---
 package/multimedia/Config.in        |    1 +
 package/multimedia/gst-av/Config.in |   12 ++++++++++++
 package/multimedia/gst-av/gst-av.mk |   19 +++++++++++++++++++
 3 files changed, 32 insertions(+), 0 deletions(-)
 create mode 100644 package/multimedia/gst-av/Config.in
 create mode 100644 package/multimedia/gst-av/gst-av.mk
package/multimedia/Config.in +1 -0
index a05d1d9..b9209da 100644
@@ -7,6 +7,7 @@ source "package/multimedia/flac/Config.in"
 source "package/multimedia/ffmpeg/Config.in"
 source "package/multimedia/gstreamer/Config.in"
 source "package/multimedia/gst-ffmpeg/Config.in"
+source "package/multimedia/gst-av/Config.in"
 source "package/multimedia/gst-dsp/Config.in"
 source "package/multimedia/gst-omapfb/Config.in"
 source "package/multimedia/gst-plugins-base/Config.in"
package/multimedia/gst-av/Config.in new file +12 -0
new file mode 100644
index 0000000..d43269e
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_GST_AV
+	bool "gst-av"
+	depends on BR2_PACKAGE_GSTREAMER
+	select BR2_PACKAGE_GST_PLUGINS_BASE
+	select BR2_PACKAGE_FFMPEG
+	help
+	  GStreamer plug-in to provide support for libav (fork of FFmpeg), it
+	  is similar to gst-ffmpeg, but all libav codecs are supported, even if
+	  there are native GStreamer alternatives; VP8, MP3, Ogg, Vorbis, AAC,
+	  etc.
+
+	  http://code.google.com/p/gst-av/
package/multimedia/gst-av/gst-av.mk new file +19 -0
new file mode 100644
index 0000000..cb47ac6
@@ -0,0 +1,19 @@
+GST_AV_VERSION = 0.6.0
+GST_AV_SOURCE = gst-av-$(GST_AV_VERSION).tar.gz
+GST_AV_SITE = http://gst-av.googlecode.com/files/
+
+define GST_AV_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) -e
+endef
+
+define GST_AV_INSTALL_TARGET_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) -e DESTDIR=$(TARGET_DIR) install
+endef
+
+define GST_AV_UNINSTALL_TARGET_CMDS
+	$(RM) $(TARGET_DIR)/usr/lib/gstreamer-0.10/libgstav.so
+endef
+
+GST_AV_DEPENDENCIES = gstreamer gst-plugins-base ffmpeg host-pkg-config
+
+$(eval $(call GENTARGETS))
Signature · 1 line
1.7.9.1.g97f7d
#1 lore raw

PATCH 1/1 Add gst-av package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

Felipe> Signed-off-by: Felipe Contreras <[email protected]>

A more detailed commit message would be good. How does this differ from gst-ffmpeg? I see you depend on ffmpeg and not libav (which we currently don't have in BR).

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 Add gst-av package

Quoted 7 lines · On Saturday 11 February 2012 16:58:12 Peter Korsgaard wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

Felipe> Signed-off-by: Felipe Contreras <[email protected]>

A more detailed commit message would be good. How does this differ from gst-ffmpeg? I see you depend on ffmpeg and not libav (which we currently don't have in BR).

To be honest, I find it redundant to repeat the help text of Config.in in
the commit message when adding a new package. When you look at the project history, you will probably already have looked at the package's files first.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 1/1 Add gst-av package

Quoted 5 lines · On Saturday 11 February 2012 17:14:27 Arnout Vandecappelle wrote:
Quoted 4 lines · On Saturday 11 February 2012 16:58:12 Peter Korsgaard wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

Felipe> Signed-off-by: Felipe Contreras <[email protected]>

Quoted 7 lines
Quoted 3 lines

A more detailed commit message would be good. How does this differ from gst-ffmpeg? I see you depend on ffmpeg and not libav (which we currently don't have in BR).

To be honest, I find it redundant to repeat the help text of Config.in in
the commit message when adding a new package. When you look at the project history, you will probably already have looked at the package's files first.

That said, an explanation why it depends on ffmpeg instead of libav would be
good. But then in the mk-file, not in the commit message.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#4 lore raw

PATCH 1/1 Add gst-av package

In reply to Peter Korsgaard
Quoted 7 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

?Felipe> Signed-off-by: Felipe Contreras <[email protected]>

A more detailed commit message would be good. How does this differ from gst-ffmpeg? I see you depend on ffmpeg and not libav (which we currently don't have in BR).

I thought the help text explained that: gst-ffmpeg disables certain codecs, like MP3, Vorbis, Theora, etc. IOW. It has political baggage from GStreamer developers; they don't want people to use FFmpeg, they want people to use native elements: vorbisdec, theoradec, maddec, etc.

And gst-av works for both libav, and FFmpeg. Obviously, I wrote it for libav, but FFmpeg is simply an old version of the same API.

Cheers.

Signature · 1 line
Felipe Contreras
#5 lore raw

PATCH 1/1 Add gst-av package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

Hi,

Felipe> I thought the help text explained that: gst-ffmpeg disables certain Felipe> codecs, like MP3, Vorbis, Theora, etc. IOW. It has political baggage Felipe> from GStreamer developers; they don't want people to use FFmpeg, they Felipe> want people to use native elements: vorbisdec, theoradec, maddec, etc.

But how does (more-or-less) reimplementing gst-ffmpeg change this political baggage?

Signature · 1 line
Bye, Peter Korsgaard
#6 lore raw

PATCH 1/1 Add gst-av package

Quoted 8 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

?Felipe> I thought the help text explained that: gst-ffmpeg disables certain ?Felipe> codecs, like MP3, Vorbis, Theora, etc. IOW. It has political baggage ?Felipe> from GStreamer developers; they don't want people to use FFmpeg, they ?Felipe> want people to use native elements: vorbisdec, theoradec, maddec, etc.

But how does (more-or-less) reimplementing gst-ffmpeg change this political baggage?

I don't have to convince GStreamer developers--I know many of them, and I doubt they would allow such a change.

Plus, here's another important part of the description[1]:

---
In addition, it is much simpler (2654 vs 16575 LOC), has better performance, and has a bit of extra features (such as less latency), and doesn?t use deprecated API?s. In a previous post I measured exactly how much improvement compared to gst-ffmpeg there is; it?s not much, but it?s some.
---

Yes, I have actually measured the power usage[2].

But the main reason is the complexity of the code. If you quickly skim through both code-bases, you would see what I mean :)

Cheers.

[1] http://felipec.wordpress.com/2011/05/19/gst-av-0-5-released-now-with-video-encoding-and-decoding-support/
[2] http://felipec.wordpress.com/2010/09/14/gst-av-0-3-better-performance-for-vorbis-and-mp3/

Signature · 1 line
Felipe Contreras
#7 lore raw

PATCH 1/1 Add gst-av package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

Hi,

Felipe> ---
Felipe> In addition, it is much simpler (2654 vs 16575 LOC), has better Felipe> performance, and has a bit of extra features (such as less latency), Felipe> and doesn?t use deprecated API?s. In a previous post I measured Felipe> exactly how much improvement compared to gst-ffmpeg there is; it?s not Felipe> much, but it?s some.
Felipe> ---

Felipe> Yes, I have actually measured the power usage[2].

Felipe> But the main reason is the complexity of the code. If you Felipe> quickly skim through both code-bases, you would see what I mean Felipe> :)

Ok, I get it now - Thanks.

Signature · 1 line
Bye, Peter Korsgaard