Skip to contentSkip to conversation

Why chmod ug+rw?

Buildroot Arnout Vandecappelle 2 participants 2 messages Jul 6, 2011 – Jul 7, 2011

lore
Share & tools
lore
#0 lore raw

Hoi all,

Why does buildroot make the sources group-writable?

A bit of context: I'm using Thomas Petazzoni's patch to have a custom package
extract function that rsyncs the source code into the build directory. I noticed that rsync always goes through the whole tree, because it needs to update permissions. This is because of the below:

	$($(PKG)_EXTRACT_CMDS)
# some packages have messed up permissions inside
	$(Q)chmod -R ug+rw $(@D)

Now I agree that some packages have messed up permissions, but why does the
group need read and write permission? Especially since in buildroot everything is owned by the user and no su-ing is done.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43
#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Arnout> Hoi all,
Arnout> Why does buildroot make the sources group-writable?

Arnout> A bit of context: I'm using Thomas Petazzoni's patch to have a Arnout> custom package extract function that rsyncs the source code Arnout> into the build directory. I noticed that rsync always goes Arnout> through the whole tree, because it needs to update permissions. Arnout> This is because of the below:

Arnout> $($(PKG)_EXTRACT_CMDS)
Arnout> # some packages have messed up permissions inside
Arnout> $(Q)chmod -R ug+rw $(@D)

Arnout> Now I agree that some packages have messed up permissions, but Arnout> why does the group need read and write permission? Especially Arnout> since in buildroot everything is owned by the user and no Arnout> su-ing is done.

I don't see any reason for it either. The ug+rw dates back from the original AUTOTARGETS work (2008, pre-git) by John Voltz who we haven't heard from for several years:

commit de54a6ebc8f54f01eebd78723003a2f809873030

Author: John Voltz <[email protected]>
Date:   Thu Mar 6 18:39:42 2008 +0000

fixed nasty makefile bugs

I'll change it to chmod -R +rw instead.

Signature · 1 line
Bye, Peter Korsgaard