Add target EDOSK2674
cover Add target EDOSK2674
Hi lists,
This patches added new target EDOSK2674.
Please comments.
Thanks.
Yoshinori Sato (5):
Add h8300 architecture part1 - core
Add h8300 architecture part2 - headers
Add h8300 architecture part3 - misc
standard SCI support
Add target edosk2674
arch/h8300/config.mk | 35 +++++++ arch/h8300/cpu/h8300s/Makefile | 53 ++++++++++ arch/h8300/cpu/h8300s/config.mk | 26 +++++ arch/h8300/cpu/h8300s/cpu.c | 83 +++++++++++++++ arch/h8300/cpu/h8300s/interrupts.c | 38 +++++++ arch/h8300/cpu/h8300s/start.S | 87 ++++++++++++++++ arch/h8300/cpu/h8300s/watchdog.c | 36 +++++++ arch/h8300/include/asm/bitops.h | 186 ++++++++++++++++++++++++++++++++++ arch/h8300/include/asm/byteorder.h | 6 + arch/h8300/include/asm/config.h | 26 +++++ arch/h8300/include/asm/global_data.h | 55 ++++++++++ arch/h8300/include/asm/io.h | 178 ++++++++++++++++++++++++++++++++ arch/h8300/include/asm/posix_types.h | 123 ++++++++++++++++++++++ arch/h8300/include/asm/processor.h | 4 + arch/h8300/include/asm/ptrace.h | 64 ++++++++++++ arch/h8300/include/asm/string.h | 41 ++++++++ arch/h8300/include/asm/types.h | 62 +++++++++++ arch/h8300/include/asm/u-boot.h | 41 ++++++++ arch/h8300/include/asm/unaligned.h | 10 ++ arch/h8300/lib/Makefile | 43 ++++++++ arch/h8300/lib/board.c | 158 +++++++++++++++++++++++++++++ arch/h8300/lib/bootm.c | 70 +++++++++++++ arch/h8300/lib/time.c | 87 ++++++++++++++++ board/edosk2674/Makefile | 48 +++++++++ board/edosk2674/config.mk | 25 +++++ board/edosk2674/edosk2674.c | 63 ++++++++++++ board/edosk2674/lowlevel_init.S | 84 +++++++++++++++ board/edosk2674/u-boot.lds | 84 +++++++++++++++ boards.cfg | 1 + common/cmd_bdinfo.c | 20 ++++ common/cmd_bootm.c | 2 + drivers/net/lan91c96.h | 21 ++++ drivers/serial/serial_sh.c | 74 ++++++++++++-- drivers/serial/serial_sh.h | 93 ++++++----------- examples/standalone/Makefile | 3 +- examples/standalone/stubs.c | 20 ++++- include/configs/edosk2674.h | 104 +++++++++++++++++++ include/image.h | 5 + 38 files changed, 2086 insertions(+), 73 deletions(-) create mode 100644 arch/h8300/config.mk create mode 100644 arch/h8300/cpu/h8300s/Makefile create mode 100644 arch/h8300/cpu/h8300s/config.mk create mode 100644 arch/h8300/cpu/h8300s/cpu.c create mode 100644 arch/h8300/cpu/h8300s/interrupts.c create mode 100644 arch/h8300/cpu/h8300s/start.S create mode 100644 arch/h8300/cpu/h8300s/watchdog.c create mode 100644 arch/h8300/include/asm/bitops.h create mode 100644 arch/h8300/include/asm/byteorder.h create mode 100644 arch/h8300/include/asm/config.h create mode 100644 arch/h8300/include/asm/global_data.h create mode 100644 arch/h8300/include/asm/io.h create mode 100644 arch/h8300/include/asm/posix_types.h create mode 100644 arch/h8300/include/asm/processor.h create mode 100644 arch/h8300/include/asm/ptrace.h create mode 100644 arch/h8300/include/asm/string.h create mode 100644 arch/h8300/include/asm/types.h create mode 100644 arch/h8300/include/asm/u-boot.h create mode 100644 arch/h8300/include/asm/unaligned.h create mode 100644 arch/h8300/lib/Makefile create mode 100644 arch/h8300/lib/board.c create mode 100644 arch/h8300/lib/bootm.c create mode 100644 arch/h8300/lib/time.c create mode 100644 board/edosk2674/Makefile create mode 100644 board/edosk2674/config.mk create mode 100644 board/edosk2674/edosk2674.c create mode 100644 board/edosk2674/lowlevel_init.S create mode 100644 board/edosk2674/u-boot.lds create mode 100644 include/configs/edosk2674.h
Signature · 1 line
1.7.2.3
cover Add target EDOSK2674
Dear Yoshinori Sato,
Quoted 5 lines · In message <87zkpe9dj9.wl%[email protected]> you wrote:
Hi lists,
This patches added new target EDOSK2674.
Please comments.
Thanks.
As a general note, it would be a good idea to include some comments about hwat sort this CPU is, why it is implemented here as a new architecture, where one can find related documentation, etc.
Quoted 6 lines
Yoshinori Sato (5):
Add h8300 architecture part1 - core
Add h8300 architecture part2 - headers
Add h8300 architecture part3 - misc
standard SCI support
Add target edosk2674
This split is artifical and makes no sense. Please keep in ind that commits shall implement atomic changes, always resulting in some sort of sane state. So adding code without the needed headers is a strict no-no.
Finally, these changes have a number of style issues. In a first step I recommend to clean up checkpatch errors and warnings:
[U-Boot] [PATCH 1/5] Add h8300 architecture part1 - core
total: 6 errors, 9 warnings, 716 lines checked [U-Boot] [PATCH 2/5] Add h8300 architecture part2 - headers
total: 84 errors, 84 warnings, 796 lines checked [U-Boot] [PATCH 3/5] Add h8300 architecture part3 - misc
total: 1 errors, 11 warnings, 104 lines checked [U-Boot] [PATCH 4/5] standard SCI support
total: 9 errors, 3 warnings, 273 lines checked [U-Boot] [PATCH 5/5] Add target edosk2674
total: 8 errors, 11 warnings, 442 lines checked
Thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Q: Why do PCs have a reset button on the front? A: Because they are expected to run Microsoft operating systems.