Skip to contentSkip to conversation

OMAP3: I2C: hwmod: Fix PRCM module offset

PATCH New G, Manjunath Kondaiah 2 participants 2 messages Nov 8, 2010 – Nov 9, 2010

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OMAP3: I2C: hwmod: Fix PRCM module offset

The commit '311225e6' is missing '.module_offs' in prcm structure in omap3 hwmod data base which results in accessing wrong register for I2Cx IDLEST bit monitoring.

Added module offsets for accessing register CM_IDLEST1_CORE.

Patch tested on Zoom3 using omap2plus_defconfig

Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Rajendra Nayak <[email protected]>
Cc Benoit Cousson <[email protected]>
---
 arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c +3 -0
index d0d8030..22831e9 100644
@@ -642,6 +642,7 @@ static struct omap_hwmod omap3xxx_i2c1_hwmod = {
 	.main_clk	= "i2c1_fck",
 	.prcm		= {
 		.omap2 = {
+			.module_offs = CORE_MOD,
 			.prcm_reg_id = 1,
 			.module_bit = OMAP3430_EN_I2C1_SHIFT,
 			.idlest_reg_id = 1,
@@ -683,6 +684,7 @@ static struct omap_hwmod omap3xxx_i2c2_hwmod = {
 	.main_clk	= "i2c2_fck",
 	.prcm		= {
 		.omap2 = {
+			.module_offs = CORE_MOD,
 			.prcm_reg_id = 1,
 			.module_bit = OMAP3430_EN_I2C2_SHIFT,
 			.idlest_reg_id = 1,
@@ -724,6 +726,7 @@ static struct omap_hwmod omap3xxx_i2c3_hwmod = {
 	.main_clk	= "i2c3_fck",
 	.prcm		= {
 		.omap2 = {
+			.module_offs = CORE_MOD,
 			.prcm_reg_id = 1,
 			.module_bit = OMAP3430_EN_I2C3_SHIFT,
 			.idlest_reg_id = 1,
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 OMAP3: I2C: hwmod: Fix PRCM module offset

Quoted 7 lines · Manjunath Kondaiah

The commit '311225e6' is missing '.module_offs' in prcm structure in omap3 hwmod data base which results in accessing wrong register for I2Cx IDLEST bit monitoring.

Added module offsets for accessing register CM_IDLEST1_CORE.

Patch tested on Zoom3 using omap2plus_defconfig

Thanks, will fold this into original series.

Kevin

Quoted 38 lines
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Rajendra Nayak <[email protected]>
Cc Benoit Cousson <[email protected]>
---
 arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c +3 -0
index d0d8030..22831e9 100644
@@ -642,6 +642,7 @@ static struct omap_hwmod omap3xxx_i2c1_hwmod = {
 	.main_clk	= "i2c1_fck",
 	.prcm		= {
 		.omap2 = {
+			.module_offs = CORE_MOD,
 			.prcm_reg_id = 1,
 			.module_bit = OMAP3430_EN_I2C1_SHIFT,
 			.idlest_reg_id = 1,
@@ -683,6 +684,7 @@ static struct omap_hwmod omap3xxx_i2c2_hwmod = {
 	.main_clk	= "i2c2_fck",
 	.prcm		= {
 		.omap2 = {
+			.module_offs = CORE_MOD,
 			.prcm_reg_id = 1,
 			.module_bit = OMAP3430_EN_I2C2_SHIFT,
 			.idlest_reg_id = 1,
@@ -724,6 +726,7 @@ static struct omap_hwmod omap3xxx_i2c3_hwmod = {
 	.main_clk	= "i2c3_fck",
 	.prcm		= {
 		.omap2 = {
+			.module_offs = CORE_MOD,
 			.prcm_reg_id = 1,
 			.module_bit = OMAP3430_EN_I2C3_SHIFT,
 			.idlest_reg_id = 1,