Fix "usb part" command
PATCH 1/1 Fix "usb part" command
From: Christian Eggers <[email protected]>
Only print partition for selected device if user supplied the <dev> arg with the "usb part [dev]" command.
--- common/cmd_usb.c | 19 +++++++++++++++---- 1 files changed, 15 insertions(+), 4 deletions(-)
common/cmd_usb.c +15 -4
@@ -553,13 +553,24 @@ int do_usb (cmd_tbl_t *cmdtp, int flag, }if (strncmp (argv[1 ],"part" ,4 ) ==0 ) { -int devno, ok; -for (ok=0 , devno=0 ; devno<USB_MAX_STOR_DEV ; ++devno) { +int devno, ok =0 ; +if (argc==2 ) { +for (devno=0 ; devno<USB_MAX_STOR_DEV ; ++devno) { + stor_dev=usb_stor_get_dev (devno); +if (stor_dev->type!=DEV_TYPE_UNKNOWN ) { + ok++; +if (devno) +printf ("\n" ); +printf ("print_part of %x\n" ,devno); +print_part (stor_dev); + } + } + } +else { + devno=simple_strtoul (argv[2 ],NULL ,16 ); stor_dev=usb_stor_get_dev (devno);if (stor_dev->type!=DEV_TYPE_UNKNOWN ) { ok++; -if (devno) -printf ("\n" );printf ("print_part of %x\n" ,devno);print_part (stor_dev); }
Signature · 1 line
1.4.3.4
PATCH 1/1 Fix "usb part" command
Quoted 3 lines · In message <[email protected]> you wrote:
From: Christian Eggers <[email protected]>
Only print partition for selected device if user supplied the <dev> arg with the "usb part [dev]" command.
What is the rationale of this modification, i. e. which bug are you fixing?
I think current behaviour is consistent between "ide part", "scsi part", "usb part" etc. so if there is a problem here this might need to be changed elsewhere, too ?
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Behind every great man, there is a woman -- urging him on. -- Harry Mudd, "I, Mudd", stardate 4513.3
PATCH 1/1 Fix "usb part" command
Quoted 7 lines · Wolfgang Denk
Quoted 3 lines · In message <[email protected]> you wrote:
From: Christian Eggers <[email protected]>
Only print partition for selected device if user supplied the <dev> arg with the "usb part [dev]" command.
What is the rationale of this modification, i. e. which bug are you fixing?
I think this fix is correct. If I do
usb part
U-Boot (correcly) prints the partitions of all devices. If I type
usb part 0
i only want the partitions on device 0. Without this patch I still get all partitions on all devices. This is wrong.
Quoted 3 lines
I think current behaviour is consistent between "ide part", "scsi part", "usb part" etc. so if there is a problem here this might need to be changed elsewhere, too ?
I just took a look at cmd_ide, and AFAICS it does exactly what USB will do with this patch.
Best regards
Markus Klotzbuecher
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
PATCH 1/1 Fix "usb part" command
Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 5 lines
Quoted 2 lines
Only print partition for selected device if user supplied the <dev> arg with the "usb part [dev]" command.
What is the rationale of this modification, i. e. which bug are you fixing?
I think this fix is correct. If I do
I see. Thanks.
Best regards,
Wolfgang Denk
Signature · 8 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Many companies that have made themselves dependent on [the equipment
of a certain major manufacturer] (and in doing so have sold their
soul to the devil) will collapse under the sheer weight of the un-
mastered complexity of their data processing systems.
-- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5PATCH 1/1 Fix "usb part" command
In reply to Christian EggersQuoted 5 lines · Christian Eggers
From: Christian Eggers <[email protected]>
Only print partition for selected device if user supplied the <dev> arg with the "usb part [dev]" command.
Signed-off-by Christian Eggers <[email protected]>
Wolfgang, please apply!
Best regards
Markus Klotzbuecher
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
PATCH 1/1 Fix "usb part" command
Quoted 10 lines · In message <[email protected]> you wrote:
Quoted 5 lines · Christian Eggers
From: Christian Eggers <[email protected]>
Only print partition for selected device if user supplied the <dev> arg with the "usb part [dev]" command.
Signed-off-by Christian Eggers <[email protected]>Wolfgang, please apply!
Done. Thanks.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de What's the sound a name makes when it's dropped?
Wolfgang Denk
AppliedPATCH 1/1 Fix "usb part" command
In reply to Christian EggersQuoted 8 lines · In message <[email protected]> you wrote:
From: Christian Eggers <[email protected]>
Only print partition for selected device if user supplied the <dev> arg with the "usb part [dev]" command.
Signed-off-by Christian Eggers <[email protected]>--- common/cmd_usb.c | 19 +++++++++++++++---- 1 files changed, 15 insertions(+), 4 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I find this a nice feature but it is not according to the documen-
tation. Or is it a BUG?" "Let's call it an accidental feature. :-)"
- Larry Wall in <[email protected]>