irqchip: add support for BCM6345 interrupt controller
cover irqchip: add support for BCM6345 interrupt controller
This interrupt controller is present on bcm63xx SoCs in order to generate interrupts based on GPIO status changes.
Álvaro Fernández Rojas (2):
dt-bindings: interrupt-controller: document BCM6345 external interrupt
controller
irqchip: add support for BCM6345 interrupt controller
.../brcm,bcm6345-ext-intc.yaml | 61 ++++ drivers/irqchip/Kconfig | 4 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-bcm6345-ext.c | 271 ++++++++++++++++++ 4 files changed, 337 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml create mode 100644 drivers/irqchip/irq-bcm6345-ext.c
Signature · 1 line
2.20.1
PATCH 1/2 dt-bindings: interrupt-controller: document BCM6345 external interrupt controller
Document the binding for the BCM6345 external interrupt controller.
--- .../brcm,bcm6345-ext-intc.yaml | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file +61 -0
@@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interrupt-controller/brcm,brcm6345-ext-intc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom BCM6345 external interrupt controller + +maintainers: + - Álvaro Fernández Rojas <[email protected]> + - Jonas Gorski <[email protected]> + +properties: + compatible: + enum: + - brcm,bcm6318-ext-intc + - brcm,bcm6345-ext-intc + + interrupt-parent: + description: Specifies the phandle to the parent interrupt controller + this one is cascaded from. + + "#interrupt-cells": + const: 2 + + reg: + maxItems: 1 + + "#address-cells": + const: 0 + + interrupt-controller: true + + interrupts: + description: Specifies the interrupt line(s) in the interrupt-parent + controller node, valid values depend on the type of parent interrupt + controller. + maxItems: 4 + +required: + - compatible + - interrupt-parent + - "#interrupt-cells" + - reg + - "#address-cells" + - interrupt-controller + - interrupts + +additionalProperties: false + +examples: + - | + ext_intc: interrupt-controller@10000018 { + compatible = "brcm,bcm6345-ext-intc"; + interrupt-parent = <&periph_intc>; + #interrupt-cells = <2>; + reg = <0x10000018 0x4>; + #address-cells = <0>; + interrupt-controller; + interrupts = <24>, <25>, <26>, <27>; + };
Signature · 1 line
2.20.1
Rob Herring
maintainerRe: [PATCH 1/2] dt-bindings: interrupt-controller: document BCM6345 external interrupt controller
Quoted 9 lines · Álvaro Fernández Rojas
Document the binding for the BCM6345 external interrupt controller.
Signed-off-by Álvaro Fernández Rojas <[email protected]>Signed-off-by Jonas Gorski <[email protected]>--- .../brcm,bcm6345-ext-intc.yaml | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml: properties:interrupt-parent: False schema does not allow {'description': 'Specifies the phandle to the parent interrupt controller this one is cascaded from.'} ./Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/interrupt-controller/brcm,bcm6345-ext-intc.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml: ignoring, error in schema: properties: interrupt-parent
warning: no schema found in file: ./Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
See https://patchwork.ozlabs.org/patch/1443597
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
kernel test robot
build botRe: [PATCH 1/2] dt-bindings: interrupt-controller: document BCM6345 external interrupt controller
In reply to Álvaro Fernández RojasThank you for the patch! Perhaps something to improve:
Hi "Álvaro,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/irq/core]
[also build test WARNING on robh/for-next v5.11 next-20210224] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/lvaro-Fern-ndez-Rojas/irqchip-add-support-for-BCM6345-interrupt-controller/20210224-021254 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 0b6d70e571a1c764ab079e5c31d4156feee4b06b reproduce: make dtbs_check
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
warning: no schema found in file: Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
PATCH 2/2 irqchip: add support for BCM6345 interrupt controller
In reply to Álvaro Fernández RojasThis interrupt controller is present on bcm63xx SoCs in order to generate interrupts based on GPIO status changes.
--- drivers/irqchip/Kconfig | 4 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-bcm6345-ext.c | 271 ++++++++++++++++++++++++++++++ 3 files changed, 276 insertions(+) create mode 100644 drivers/irqchip/irq-bcm6345-ext.c
drivers/irqchip/Kconfig +4 -0
@@ -113,6 +113,10 @@ config I8259 bool select IRQ_DOMAIN +config BCM6345_EXT_IRQ + bool "BCM6345 External IRQ Controller" + select IRQ_DOMAIN + config BCM6345_L1_IRQ bool select GENERIC_IRQ_CHIP
drivers/irqchip/Makefile +1 -0
@@ -62,6 +62,7 @@ obj-$(CONFIG_XTENSA_MX) += irq-xtensa-mx.o obj-$(CONFIG_XILINX_INTC) += irq-xilinx-intc.o obj-$(CONFIG_IRQ_CROSSBAR) += irq-crossbar.o obj-$(CONFIG_SOC_VF610) += irq-vf610-mscm-ir.o +obj-$(CONFIG_BCM6345_EXT_IRQ) += irq-bcm6345-ext.o obj-$(CONFIG_BCM6345_L1_IRQ) += irq-bcm6345-l1.o obj-$(CONFIG_BCM7038_L1_IRQ) += irq-bcm7038-l1.o obj-$(CONFIG_BCM7120_L2_IRQ) += irq-bcm7120-l2.o
drivers/irqchip/irq-bcm6345-ext.c new file +271 -0
271 lines not on this page · raw message
Signature · 1 line
2.20.1
kernel test robot
build botThank you for the patch! Yet something to improve:
Hi "Álvaro,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/irq/core]
[also build test ERROR on v5.11 next-20210223]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/lvaro-Fern-ndez-Rojas/irqchip-add-support-for-BCM6345-interrupt-controller/20210224-021254 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 0b6d70e571a1c764ab079e5c31d4156feee4b06b config: s390-allmodconfig (attached as .config) compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/b150214898982b67d7c34b848b445e5e557691c6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review lvaro-Fern-ndez-Rojas/irqchip-add-support-for-BCM6345-interrupt-controller/20210224-021254 git checkout b150214898982b67d7c34b848b445e5e557691c6
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
s390-linux-ld: kernel/dma/coherent.o: in function `dma_init_coherent_memory':
coherent.c:(.text+0x4f0): undefined reference to `memremap'
s390-linux-ld: coherent.c:(.text+0x702): undefined reference to `memunmap'
s390-linux-ld: kernel/dma/coherent.o: in function `dma_declare_coherent_memory':
coherent.c:(.text+0xf36): undefined reference to `memunmap'
s390-linux-ld: drivers/irqchip/irq-al-fic.o: in function `al_fic_init_dt':
irq-al-fic.c:(.init.text+0xc8): undefined reference to `of_iomap'
s390-linux-ld: irq-al-fic.c:(.init.text+0x814): undefined reference to `iounmap'
s390-linux-ld: drivers/irqchip/irq-bcm6345-ext.o: in function `bcm6345_ext_intc_of_init':
>> irq-bcm6345-ext.c:(.init.text+0x3bc): undefined reference to `of_iomap' >> s390-linux-ld: irq-bcm6345-ext.c:(.init.text+0x7b4): undefined reference to `iounmap'
s390-linux-ld: drivers/clk/clk-fixed-mmio.o: in function `fixed_mmio_clk_setup':
clk-fixed-mmio.c:(.text+0xaa): undefined reference to `of_iomap'
s390-linux-ld: clk-fixed-mmio.c:(.text+0x146): undefined reference to `iounmap'
s390-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_init':
timer-of.c:(.init.text+0x1d2): undefined reference to `of_iomap'
s390-linux-ld: timer-of.c:(.init.text+0xce4): undefined reference to `iounmap'
s390-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_cleanup':
timer-of.c:(.init.text+0x103e): undefined reference to `iounmap'
s390-linux-ld: drivers/clocksource/timer-microchip-pit64b.o: in function `mchp_pit64b_dt_init_timer':
timer-microchip-pit64b.c:(.init.text+0x3aa): undefined reference to `of_iomap'
s390-linux-ld: timer-microchip-pit64b.c:(.init.text+0x1196): undefined reference to `iounmap'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
v2 cover irqchip: add support for BCM6345 interrupt controller
In reply to Álvaro Fernández RojasThis interrupt controller is present on bcm63xx SoCs in order to generate interrupts based on GPIO status changes.
v2: fix documentation title typo.
Álvaro Fernández Rojas (2):
dt-bindings: interrupt-controller: document BCM6345 external interrupt
controller
irqchip: add support for BCM6345 interrupt controller
.../brcm,bcm6345-ext-intc.yaml | 61 ++++ drivers/irqchip/Kconfig | 4 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-bcm6345-ext.c | 271 ++++++++++++++++++ 4 files changed, 337 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml create mode 100644 drivers/irqchip/irq-bcm6345-ext.c
Signature · 1 line
2.20.1
PATCH v2 1/2 dt-bindings: interrupt-controller: document BCM6345 external interrupt controller
Document the binding for the BCM6345 external interrupt controller.
---
v2: fix title typo.
.../brcm,bcm6345-ext-intc.yaml | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file +61 -0
@@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm6345-ext-intc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom BCM6345 external interrupt controller + +maintainers: + - Álvaro Fernández Rojas <[email protected]> + - Jonas Gorski <[email protected]> + +properties: + compatible: + enum: + - brcm,bcm6318-ext-intc + - brcm,bcm6345-ext-intc + + interrupt-parent: + description: Specifies the phandle to the parent interrupt controller + this one is cascaded from. + + "#interrupt-cells": + const: 2 + + reg: + maxItems: 1 + + "#address-cells": + const: 0 + + interrupt-controller: true + + interrupts: + description: Specifies the interrupt line(s) in the interrupt-parent + controller node, valid values depend on the type of parent interrupt + controller. + maxItems: 4 + +required: + - compatible + - interrupt-parent + - "#interrupt-cells" + - reg + - "#address-cells" + - interrupt-controller + - interrupts + +additionalProperties: false + +examples: + - | + ext_intc: interrupt-controller@10000018 { + compatible = "brcm,bcm6345-ext-intc"; + interrupt-parent = <&periph_intc>; + #interrupt-cells = <2>; + reg = <0x10000018 0x4>; + #address-cells = <0>; + interrupt-controller; + interrupts = <24>, <25>, <26>, <27>; + };
Signature · 1 line
2.20.1
Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: document BCM6345 external interrupt controller
Quoted 4 lines · Álvaro Fernández Rojas
Document the binding for the BCM6345 external interrupt controller.
Signed-off-by Álvaro Fernández Rojas <[email protected]>Signed-off-by Jonas Gorski <[email protected]>
Signature · 1 line
Florian
Rob Herring
maintainerRe: [PATCH v2 1/2] dt-bindings: interrupt-controller: document BCM6345 external interrupt controller
In reply to Álvaro Fernández RojasQuoted 11 lines · Álvaro Fernández Rojas
Document the binding for the BCM6345 external interrupt controller.
Signed-off-by Álvaro Fernández Rojas <[email protected]>Signed-off-by Jonas Gorski <[email protected]>---
v2: fix title typo..../brcm,bcm6345-ext-intc.yaml | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml: properties:interrupt-parent: False schema does not allow {'description': 'Specifies the phandle to the parent interrupt controller this one is cascaded from.'} /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml: ignoring, error in schema: properties: interrupt-parent
warning: no schema found in file: ./Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
See https://patchwork.ozlabs.org/patch/1443622
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
PATCH v2 2/2 irqchip: add support for BCM6345 external interrupt controller
In reply to Álvaro Fernández RojasThis interrupt controller is present on bcm63xx SoCs in order to generate interrupts based on GPIO status changes.
---
v2: no changes.
drivers/irqchip/Kconfig | 4 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-bcm6345-ext.c | 271 ++++++++++++++++++++++++++++++ 3 files changed, 276 insertions(+) create mode 100644 drivers/irqchip/irq-bcm6345-ext.c
drivers/irqchip/Kconfig +4 -0
@@ -113,6 +113,10 @@ config I8259 bool select IRQ_DOMAIN +config BCM6345_EXT_IRQ + bool "BCM6345 External IRQ Controller" + select IRQ_DOMAIN + config BCM6345_L1_IRQ bool select GENERIC_IRQ_CHIP
drivers/irqchip/Makefile +1 -0
@@ -62,6 +62,7 @@ obj-$(CONFIG_XTENSA_MX) += irq-xtensa-mx.o obj-$(CONFIG_XILINX_INTC) += irq-xilinx-intc.o obj-$(CONFIG_IRQ_CROSSBAR) += irq-crossbar.o obj-$(CONFIG_SOC_VF610) += irq-vf610-mscm-ir.o +obj-$(CONFIG_BCM6345_EXT_IRQ) += irq-bcm6345-ext.o obj-$(CONFIG_BCM6345_L1_IRQ) += irq-bcm6345-l1.o obj-$(CONFIG_BCM7038_L1_IRQ) += irq-bcm7038-l1.o obj-$(CONFIG_BCM7120_L2_IRQ) += irq-bcm7120-l2.o
drivers/irqchip/irq-bcm6345-ext.c new file +271 -0
271 lines not on this page · raw message
Signature · 1 line
2.20.1
Re: [PATCH v2 2/2] irqchip: add support for BCM6345 external interrupt controller
Quoted 6 lines · Álvaro Fernández Rojas
This interrupt controller is present on bcm63xx SoCs in order to generate interrupts based on GPIO status changes.
Signed-off-by Álvaro Fernández Rojas <[email protected]>Signed-off-by Jonas Gorski <[email protected]>---
[snip]
Quoted 7 lines
drivers/irqchip/irq-bcm6345-ext.c new file +7
-0+static int __init bcm6345_ext_intc_of_init (struct device_node *node, +struct device_node *parent) +{ +int num_irqs, ret = -EINVAL ; +unsigned i; +void __iomem *base; +int irqs[MAX_IRQS ] = {0 };
drivers/irqchip/irq-bcm6345-ext.c line 239
Quoted 10 lines
drivers/irqchip/irq-bcm6345-ext.c new file +10
-0+u32 shift; +bool toggle_clear_on_ack = false; + + num_irqs =of_irq_count (node); + +if (!num_irqs || num_irqs >MAX_IRQS ) +return -EINVAL ; + +if (of_property_read_u32 (node,"brcm,field-width" , &shift)) + shift =4 ;
This property is not documented in the binding, other than that:
Signature · 1 line
Florian
Re: [PATCH v2 2/2] irqchip: add support for BCM6345 external interrupt controller
Hi Florian,
Quoted 24 lines · Florian Fainelli
Quoted 6 lines · Álvaro Fernández Rojas
This interrupt controller is present on bcm63xx SoCs in order to generate interrupts based on GPIO status changes.
Signed-off-by Álvaro Fernández Rojas <[email protected]>Signed-off-by Jonas Gorski <[email protected]>---
[snip]
Quoted 11 lines
drivers/irqchip/irq-bcm6345-ext.c new file +11
-0+static int __init bcm6345_ext_intc_of_init (struct device_node *node, +struct device_node *parent) +{ +int num_irqs, ret = -EINVAL ; +unsigned i; +void __iomem *base; +int irqs[MAX_IRQS ] = {0 }; +u32 shift; +bool toggle_clear_on_ack = false; + + num_irqs =of_irq_count (node);
Quoted 8 lines
drivers/irqchip/irq-bcm6345-ext.c line 239
Quoted 6 lines
drivers/irqchip/irq-bcm6345-ext.c new file +6
-0+ +if (!num_irqs || num_irqs >MAX_IRQS ) +return -EINVAL ; + +if (of_property_read_u32 (node,"brcm,field-width" , &shift)) + shift =4 ;This property is not documented in the binding, other than that:
Nice catch, I will add it in next version.
Quoted 4 lines
Reviewed-by Florian Fainelli <[email protected]>Signature · 1 line
Florian
v2 cover irqchip: add support for BCM6345 interrupt controller
In reply to Álvaro Fernández RojasThis interrupt controller is present on bcm63xx SoCs in order to generate interrupts based on GPIO status changes.
v3: pass dt_binding_check.
v2: fix documentation title typo.
Álvaro Fernández Rojas (2):
dt-bindings: interrupt-controller: document BCM6345 external interrupt
controller
irqchip: add support for BCM6345 external interrupt controller
.../brcm,bcm6345-ext-intc.yaml | 78 +++++ drivers/irqchip/Kconfig | 4 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-bcm6345-ext.c | 271 ++++++++++++++++++ 4 files changed, 354 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml create mode 100644 drivers/irqchip/irq-bcm6345-ext.c
Signature · 1 line
2.20.1
PATCH v2 1/2 dt-bindings: interrupt-controller: document BCM6345 external interrupt controller
Document the binding for the BCM6345 external interrupt controller.
---
v3: pass dt_binding_check.
v2: fix title typo.
.../brcm,bcm6345-ext-intc.yaml | 78 +++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file +78 -0
@@ -0,0 +1,78 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm6345-ext-intc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom BCM6345 external interrupt controller + +maintainers: + - Álvaro Fernández Rojas <[email protected]> + - Jonas Gorski <[email protected]> + +properties: + compatible: + enum: + - brcm,bcm6318-ext-intc + - brcm,bcm6345-ext-intc + + "#interrupt-cells": + const: 2 + + reg: + maxItems: 1 + + "#address-cells": + const: 0 + + interrupt-controller: true + + interrupts: + description: Specifies the interrupt line(s) in the interrupt-parent + controller node. Valid values depend on the type of parent interrupt + controller. + maxItems: 4 + + brcm,field-width: + description: Interrupt controller field width (the default is 4). + maxItems: 1 + $ref: /schemas/types.yaml#/definitions/uint32 + +required: + - "#address-cells" + - compatible + - reg + - "#interrupt-cells" + - interrupt-controller + - interrupts + +additionalProperties: false + +examples: + - | + interrupt-controller@10000018 { + #address-cells = <0>; + compatible = "brcm,bcm6345-ext-intc"; + reg = <0x10000018 0x4>; + + interrupt-parent = <&periph_intc>; + #interrupt-cells = <2>; + + interrupt-controller; + interrupts = <24>, <25>, <26>, <27>; + }; + + - | + interrupt-controller@fffe0014 { + #address-cells = <0>; + compatible = "brcm,bcm6345-ext-intc"; + reg = <0xfffe0014 0x4>; + + interrupt-controller; + #interrupt-cells = <2>; + + interrupt-parent = <&cpu_intc>; + interrupts = <3>, <4>, <5>, <6>; + + brcm,field-width = <5>; + };
Signature · 1 line
2.20.1
Rob Herring
maintainerRe: [PATCH v2 1/2] dt-bindings: interrupt-controller: document BCM6345 external interrupt controller
Quoted 46 lines · Álvaro Fernández Rojas
Document the binding for the BCM6345 external interrupt controller.
Signed-off-by Álvaro Fernández Rojas <[email protected]>Signed-off-by Jonas Gorski <[email protected]>Reviewed-by Florian Fainelli <[email protected]>---
v3: passdt_binding_check.
v2: fix title typo..../brcm,bcm6345-ext-intc.yaml | 78 +++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yamlDocumentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file +27
-0@@ -0,0 +1,78 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm6345-ext-intc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom BCM6345 external interrupt controller + +maintainers: + - Álvaro Fernández Rojas <[email protected]> + - Jonas Gorski <[email protected]> + +properties: + compatible: + enum: + - brcm,bcm6318-ext-intc + - brcm,bcm6345-ext-intc + + "#interrupt-cells": + const: 2 + + reg: + maxItems: 1 + + "#address-cells": + const: 0 +
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml line 37
Quoted 10 lines
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file +10
-0+ interrupt-controller: true + + interrupts: + description: Specifies the interrupt line(s) in the interrupt-parent + controller node. Valid values depend on the type of parent interrupt + controller. + maxItems: 4 + + brcm,field-width: + description: Interrupt controller field width (the default is 4).
default: 4
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml line 38
Quoted 1 line
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file +1
-0+ maxItems: 1
All uint32's are 1 item.
What's the set or range of values?
Quoted 43 lines
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file +40
-0+ $ref: /schemas/types.yaml#/definitions/uint32 + +required: + - "#address-cells" + - compatible + - reg + - "#interrupt-cells" + - interrupt-controller + - interrupts + +additionalProperties: false + +examples: + - | + interrupt-controller@10000018 { + #address-cells = <0>; + compatible = "brcm,bcm6345-ext-intc"; + reg = <0x10000018 0x4>; + + interrupt-parent = <&periph_intc>; + #interrupt-cells = <2>; + + interrupt-controller; + interrupts = <24>, <25>, <26>, <27>; + }; + + - | + interrupt-controller@fffe0014 { + #address-cells = <0>; + compatible = "brcm,bcm6345-ext-intc"; + reg = <0xfffe0014 0x4>; + + interrupt-controller; + #interrupt-cells = <2>; + + interrupt-parent = <&cpu_intc>; + interrupts = <3>, <4>, <5>, <6>; + + brcm,field-width = <5>; + };Signature · 1 line
2.20.1
Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: document BCM6345 external interrupt controller
Hi Rob,
Quoted 60 lines · Rob Herring
Quoted 46 lines · Álvaro Fernández Rojas
Document the binding for the BCM6345 external interrupt controller.
Signed-off-by Álvaro Fernández Rojas <[email protected]>Signed-off-by Jonas Gorski <[email protected]>Reviewed-by Florian Fainelli <[email protected]>---
v3: passdt_binding_check.
v2: fix title typo..../brcm,bcm6345-ext-intc.yaml | 78 +++++++++++++++++++ 1 file changed, 78 insertions(+)create mode 100644
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yamlDocumentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file +27
-0@@ -0,0 +1,78 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm6345-ext-intc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom BCM6345 external interrupt controller + +maintainers: + - Álvaro Fernández Rojas <[email protected]> + - Jonas Gorski <[email protected]> + +properties: + compatible: + enum: + - brcm,bcm6318-ext-intc + - brcm,bcm6345-ext-intc + + "#interrupt-cells": + const: 2 + + reg: + maxItems: 1 + + "#address-cells": + const: 0 +Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml line 37
Quoted 10 lines
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file +10
-0+ interrupt-controller: true + + interrupts: + description: Specifies the interrupt line(s) in the interrupt-parent + controller node. Valid values depend on the type of parent interrupt + controller. + maxItems: 4 + + brcm,field-width: + description: Interrupt controller field width (the default is 4).default: 4
Quoted 3 lines
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml line 38
Quoted 1 line
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file +1
-0+ maxItems: 1All uint32's are 1 item.
Ok, so I should remove this :)
Quoted 2 lines
What's the set or range of values?
Only BCM6348 needs to set this value to 5, other BCM63xx use the default value of 4 (BCM3368, BCM6318, BCM6328, BCM6338, BCM6345, BCM6358, BCM6362, BCM6368, BCM63268).
Quoted 36 lines
Quoted 36 lines
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file +35
-0+ $ref: /schemas/types.yaml#/definitions/uint32 + +required: + - "#address-cells" + - compatible + - reg + - "#interrupt-cells" + - interrupt-controller + - interrupts + +additionalProperties: false + +examples: + - | + interrupt-controller@10000018 { + #address-cells = <0>; + compatible = "brcm,bcm6345-ext-intc"; + reg = <0x10000018 0x4>; + + interrupt-parent = <&periph_intc>; + #interrupt-cells = <2>; + + interrupt-controller; + interrupts = <24>, <25>, <26>, <27>; + }; + + - | + interrupt-controller@fffe0014 { + #address-cells = <0>; + compatible = "brcm,bcm6345-ext-intc"; + reg = <0xfffe0014 0x4>; + + interrupt-controller; + #interrupt-cells = <2>; +
Quoted 8 lines
Quoted 8 lines
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file +5
-0+ interrupt-parent = <&cpu_intc>; + interrupts = <3>, <4>, <5>, <6>; + + brcm,field-width = <5>; + };Signature · 1 line
2.20.1
Best regards,
Álvaro.
Rob Herring
maintainerRe: [PATCH v2 1/2] dt-bindings: interrupt-controller: document BCM6345 external interrupt controller
Quoted 68 lines · Álvaro Fernández Rojas
Hi Rob,
Quoted 60 lines · Rob Herring
Quoted 46 lines · Álvaro Fernández Rojas
Document the binding for the BCM6345 external interrupt controller.
Signed-off-by Álvaro Fernández Rojas <[email protected]>Signed-off-by Jonas Gorski <[email protected]>Reviewed-by Florian Fainelli <[email protected]>---
v3: passdt_binding_check.
v2: fix title typo..../brcm,bcm6345-ext-intc.yaml | 78 +++++++++++++++++++ 1 file changed, 78 insertions(+)create mode 100644
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yamlDocumentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file +27
-0@@ -0,0 +1,78 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm6345-ext-intc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom BCM6345 external interrupt controller + +maintainers: + - Álvaro Fernández Rojas <[email protected]> + - Jonas Gorski <[email protected]> + +properties: + compatible: + enum: + - brcm,bcm6318-ext-intc + - brcm,bcm6345-ext-intc + + "#interrupt-cells": + const: 2 + + reg: + maxItems: 1 + + "#address-cells": + const: 0 +Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml line 37
Quoted 10 lines
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file +10
-0+ interrupt-controller: true + + interrupts: + description: Specifies the interrupt line(s) in the interrupt-parent + controller node. Valid values depend on the type of parent interrupt + controller. + maxItems: 4 + + brcm,field-width: + description: Interrupt controller field width (the default is 4).default: 4
Quoted 3 lines
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml line 38
Quoted 1 line
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file +1
-0+ maxItems: 1All uint32's are 1 item.
Quoted 8 lines
Ok, so I should remove this :)
Quoted 2 lines
What's the set or range of values?
Only BCM6348 needs to set this value to 5, other BCM63xx use the default value of 4 (BCM3368, BCM6318, BCM6328, BCM6338, BCM6345, BCM6358, BCM6362, BCM6368, BCM63268).
So:
enum: [ 4, 5 ]
PATCH v2 2/2 irqchip: add support for BCM6345 external interrupt controller
In reply to Álvaro Fernández RojasThis interrupt controller is present on bcm63xx SoCs in order to generate interrupts based on GPIO status changes.
---
v3: no changes.
v2: no changes.
drivers/irqchip/Kconfig | 4 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-bcm6345-ext.c | 271 ++++++++++++++++++++++++++++++ 3 files changed, 276 insertions(+) create mode 100644 drivers/irqchip/irq-bcm6345-ext.c
drivers/irqchip/Kconfig +4 -0
@@ -113,6 +113,10 @@ config I8259 bool select IRQ_DOMAIN +config BCM6345_EXT_IRQ + bool "BCM6345 External IRQ Controller" + select IRQ_DOMAIN + config BCM6345_L1_IRQ bool select GENERIC_IRQ_CHIP
drivers/irqchip/Makefile +1 -0
@@ -62,6 +62,7 @@ obj-$(CONFIG_XTENSA_MX) += irq-xtensa-mx.o obj-$(CONFIG_XILINX_INTC) += irq-xilinx-intc.o obj-$(CONFIG_IRQ_CROSSBAR) += irq-crossbar.o obj-$(CONFIG_SOC_VF610) += irq-vf610-mscm-ir.o +obj-$(CONFIG_BCM6345_EXT_IRQ) += irq-bcm6345-ext.o obj-$(CONFIG_BCM6345_L1_IRQ) += irq-bcm6345-l1.o obj-$(CONFIG_BCM7038_L1_IRQ) += irq-bcm7038-l1.o obj-$(CONFIG_BCM7120_L2_IRQ) += irq-bcm7120-l2.o
drivers/irqchip/irq-bcm6345-ext.c new file +271 -0
271 lines not on this page · raw message
Signature · 1 line
2.20.1
Re: [PATCH v2 2/2] irqchip: add support for BCM6345 external interrupt controller
Quoted 77 lines · Álvaro Fernández Rojas
This interrupt controller is present on bcm63xx SoCs in order to generate interrupts based on GPIO status changes.
Signed-off-by Álvaro Fernández Rojas <[email protected]>Signed-off-by Jonas Gorski <[email protected]>Reviewed-by Florian Fainelli <[email protected]>---
v3: no changes.
v2: no changes.drivers/irqchip/Kconfig | 4 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-bcm6345-ext.c | 271 ++++++++++++++++++++++++++++++ 3 files changed, 276 insertions(+) create mode 100644 drivers/irqchip/irq-bcm6345-ext.cdrivers/irqchip/Kconfig +4
-0@@ -113,6 +113,10 @@ config I8259 bool select IRQ_DOMAIN +config BCM6345_EXT_IRQ + bool "BCM6345 External IRQ Controller" + select IRQ_DOMAIN + config BCM6345_L1_IRQ bool select GENERIC_IRQ_CHIPdrivers/irqchip/Makefile +1
-0@@ -62,6 +62,7 @@ obj-$(CONFIG_XTENSA_MX) += irq-xtensa-mx.o obj-$(CONFIG_XILINX_INTC) += irq-xilinx-intc.o obj-$(CONFIG_IRQ_CROSSBAR) += irq-crossbar.o obj-$(CONFIG_SOC_VF610) += irq-vf610-mscm-ir.o +obj-$(CONFIG_BCM6345_EXT_IRQ) += irq-bcm6345-ext.o obj-$(CONFIG_BCM6345_L1_IRQ) += irq-bcm6345-l1.o obj-$(CONFIG_BCM7038_L1_IRQ) += irq-bcm7038-l1.o obj-$(CONFIG_BCM7120_L2_IRQ) += irq-bcm7120-l2.odrivers/irqchip/irq-bcm6345-ext.c new file +27
-0@@ -0,0 +1,271 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Broadcom BCM6345 style external interrupt controller driver +* +* Copyright (C) 2021 Álvaro Fernández Rojas <[email protected]> +* Copyright (C) 2014 Jonas Gorski <[email protected]> +*/ + +#include <linux/ioport.h> +#include <linux/irq.h> +#include <linux/irqchip.h> +#include <linux/irqchip/chained_irq.h> +#include <linux/kernel.h> +#include <linux/of.h> +#include <linux/of_irq.h> +#include <linux/of_address.h> +#include <linux/slab.h> +#include <linux/spinlock.h> + +#define MAX_IRQS 4 + +#define EXTIRQ_CFG_SENSE 0 +#define EXTIRQ_CFG_STAT 1 +#define EXTIRQ_CFG_CLEAR 2 +#define EXTIRQ_CFG_MASK 3 +#define EXTIRQ_CFG_BOTHEDGE 4 +#define EXTIRQ_CFG_LEVELSENSE 5
drivers/irqchip/irq-bcm6345-ext.c line 37
Quoted 10 lines
drivers/irqchip/irq-bcm6345-ext.c new file +10
-0+ +struct intc_data { +struct irq_chip chip; +struct irq_domain *domain; +raw_spinlock_t lock; + +int parent_irq[MAX_IRQS ]; +void __iomem *reg; +int shift; +unsigned int toggle_clear_on_ack:1 ;
Please use the bool type.
Quoted 6 lines
drivers/irqchip/irq-bcm6345-ext.c new file +6
-0+}; + +static void bcm6345_ext_intc_irq_handle (struct irq_desc *desc) +{ +struct intc_data *data =irq_desc_get_handler_data (desc); +struct irq_chip *chip =irq_desc_get_chip (desc);
drivers/irqchip/irq-bcm6345-ext.c line 53
Quoted 10 lines
drivers/irqchip/irq-bcm6345-ext.c new file +10
-0+unsigned int irq =irq_desc_get_irq (desc); +unsigned int idx; + +chained_irq_enter (chip, desc); + +for (idx =0 ; idx <MAX_IRQS ; idx++) { +if (data->parent_irq[idx] != irq) +continue ; + +generic_handle_irq (irq_find_mapping (data->domain, idx));
One parent IRQ per input? Why isn't this a hierarchical interrupt controller? Even *if* this really has to be a chained interrupt controller, I'm sure there are better ways to identify the input then this loop (offset from a base, for example).
Quoted 6 lines
drivers/irqchip/irq-bcm6345-ext.c new file +6
-0+ } + +chained_irq_exit (chip, desc); +} + +static void bcm6345_ext_intc_irq_ack (struct irq_data *data)
drivers/irqchip/irq-bcm6345-ext.c line 69
Quoted 10 lines
drivers/irqchip/irq-bcm6345-ext.c new file +10
-0+{ +struct intc_data *priv = data->domain->host_data; +irq_hw_number_t hwirq =irqd_to_hwirq (data); +u32 reg; + +raw_spin_lock (&priv->lock); + reg =__raw_readl (priv->reg); +__raw_writel (reg | (1 << (hwirq +EXTIRQ_CFG_CLEAR * priv->shift)), + priv->reg); +if (priv->toggle_clear_on_ack)
Under what condition do you need this?
Quoted 31 lines
drivers/irqchip/irq-bcm6345-ext.c new file +31
-0+__raw_writel (reg, priv->reg); +raw_spin_unlock (&priv->lock); +} + +static void bcm6345_ext_intc_irq_mask (struct irq_data *data) +{ +struct intc_data *priv = data->domain->host_data; +irq_hw_number_t hwirq =irqd_to_hwirq (data); +u32 reg; + +raw_spin_lock (&priv->lock); + reg =__raw_readl (priv->reg); + reg &= ~(1 << (hwirq +EXTIRQ_CFG_MASK * priv->shift)); +__raw_writel (reg, priv->reg); +raw_spin_unlock (&priv->lock); +} + +static void bcm6345_ext_intc_irq_unmask (struct irq_data *data) +{ +struct intc_data *priv = data->domain->host_data; +irq_hw_number_t hwirq =irqd_to_hwirq (data); +u32 reg; + +raw_spin_lock (&priv->lock); + reg =__raw_readl (priv->reg); + reg |=1 << (hwirq +EXTIRQ_CFG_MASK * priv->shift); +__raw_writel (reg, priv->reg); +raw_spin_unlock (&priv->lock); +} + +static int bcm6345_ext_intc_set_type(struct irq_data *data,
drivers/irqchip/irq-bcm6345-ext.c line 110
Quoted 10 lines
drivers/irqchip/irq-bcm6345-ext.c new file +10
-0+ unsigned int flow_type) +{ +struct intc_data *priv = data->domain->host_data; +irq_hw_number_t hwirq =irqd_to_hwirq (data); +bool levelsense =0 , sense =0 , bothedge =0 ; +u32 reg; + + flow_type &=IRQ_TYPE_SENSE_MASK ; + +if (flow_type ==IRQ_TYPE_NONE )
You should never get NONE. If you have that value here, that's probably a bug somewhere else.
Quoted 16 lines
drivers/irqchip/irq-bcm6345-ext.c new file +16
-0+ flow_type =IRQ_TYPE_LEVEL_LOW ; + +switch (flow_type) { +case IRQ_TYPE_EDGE_BOTH : + bothedge =1 ; +break ; + +case IRQ_TYPE_EDGE_RISING : + sense =1 ; +break ; + +case IRQ_TYPE_EDGE_FALLING : +break ; + +case IRQ_TYPE_LEVEL_HIGH : + levelsense =1 ;
drivers/irqchip/irq-bcm6345-ext.c line 136
Quoted 10 lines
drivers/irqchip/irq-bcm6345-ext.c new file +10
-0+ sense =1 ; +break ; + +case IRQ_TYPE_LEVEL_LOW : + levelsense =1 ; +break ; + +default : +pr_err ("bogus flow type combination given!\n" ); +return -EINVAL ;
How can this happen?
Quoted 7 lines
drivers/irqchip/irq-bcm6345-ext.c new file +7
-0+ } + +raw_spin_lock (&priv->lock); + reg =__raw_readl (priv->reg); + +if (levelsense) + reg |=1 << (hwirq +EXTIRQ_CFG_LEVELSENSE * priv->shift);
drivers/irqchip/irq-bcm6345-ext.c line 153
Quoted 10 lines
drivers/irqchip/irq-bcm6345-ext.c new file +10
-0+else + reg &= ~(1 << (hwirq +EXTIRQ_CFG_LEVELSENSE * priv->shift)); +if (sense) + reg |=1 << (hwirq +EXTIRQ_CFG_SENSE * priv->shift); +else + reg &= ~(1 << (hwirq +EXTIRQ_CFG_SENSE * priv->shift)); +if (bothedge) + reg |=1 << (hwirq +EXTIRQ_CFG_BOTHEDGE * priv->shift); +else + reg &= ~(1 << (hwirq +EXTIRQ_CFG_BOTHEDGE * priv->shift));
So all these levelsense, sense and bothedge variables are already contained in flow_type. Why the need to reinvent the wheel?
Quoted 51 lines
drivers/irqchip/irq-bcm6345-ext.c new file +51
-0+ +__raw_writel (reg, priv->reg); +raw_spin_unlock (&priv->lock); + +irqd_set_trigger_type (data, flow_type); +if (flow_type & (IRQ_TYPE_LEVEL_LOW |IRQ_TYPE_LEVEL_HIGH )) +irq_set_handler_locked (data, handle_level_irq); +else +irq_set_handler_locked (data, handle_edge_irq); + +return 0 ; +} + +static int bcm6345_ext_intc_map (struct irq_domain *d,unsigned int irq, +irq_hw_number_t hw) +{ +struct intc_data *priv = d->host_data; + +irq_set_chip_and_handler (irq, &priv->chip, handle_level_irq); + +return 0 ; +} + +static const struct irq_domain_ops bcm6345_ext_domain_ops = { + .xlate = irq_domain_xlate_twocell, + .map = bcm6345_ext_intc_map, +}; + +static int __init bcm6345_ext_intc_init (struct device_node *node, +int num_irqs,int *irqs, +void __iomem *reg,int shift, +bool toggle_clear_on_ack) +{ +struct intc_data *data; +unsigned int i; + + data =kzalloc (sizeof (*data),GFP_KERNEL ); +if (!data) +return -ENOMEM ; + +raw_spin_lock_init (&data->lock); + +for (i =0 ; i < num_irqs; i++) { + data->parent_irq[i] = irqs[i]; + +irq_set_handler_data (irqs[i], data); +irq_set_chained_handler (irqs[i], bcm6345_ext_intc_irq_handle); + } + + data->reg = reg; + data->shift = shift;
drivers/irqchip/irq-bcm6345-ext.c line 214
Quoted 10 lines
drivers/irqchip/irq-bcm6345-ext.c new file +10
-0+ data->toggle_clear_on_ack = toggle_clear_on_ack; + + data->chip.name ="bcm6345-ext-intc" ; + data->chip.irq_ack = bcm6345_ext_intc_irq_ack; + data->chip.irq_mask = bcm6345_ext_intc_irq_mask; + data->chip.irq_unmask = bcm6345_ext_intc_irq_unmask; + data->chip.irq_set_type = bcm6345_ext_intc_set_type; + + data->domain =irq_domain_add_simple (node, num_irqs,0 , + &bcm6345_ext_domain_ops, data);
Consider using irq_domain_add_linear(), given that you don't seem to care about the first interrupt number.
drivers/irqchip/irq-bcm6345-ext.c line 218
Quoted 4 lines
drivers/irqchip/irq-bcm6345-ext.c new file +4
-0+if (!data->domain) { +kfree (data); +return -ENOMEM ; + }
At this point, you have registered a bunch of chained handlers with data structures that you have freed. What could possibly go wrong?
Quoted 11 lines
drivers/irqchip/irq-bcm6345-ext.c new file +11
-0+ +return 0 ; +} + +static int __init bcm6345_ext_intc_of_init (struct device_node *node, +struct device_node *parent) +{ +int num_irqs, ret = -EINVAL ; +unsigned i; +void __iomem *base; +int irqs[MAX_IRQS ] = {0 };
drivers/irqchip/irq-bcm6345-ext.c line 239
Quoted 10 lines
drivers/irqchip/irq-bcm6345-ext.c new file +10
-0+u32 shift; +bool toggle_clear_on_ack = false; + + num_irqs =of_irq_count (node); + +if (!num_irqs || num_irqs >MAX_IRQS ) +return -EINVAL ; + +if (of_property_read_u32 (node,"brcm,field-width" , &shift)) + shift =4 ;
Why this default? Given that it is a new driver without any backward compatibility requirement, either make the property mandatory or get rid of it.
drivers/irqchip/irq-bcm6345-ext.c line 243
Quoted 4 lines
drivers/irqchip/irq-bcm6345-ext.c new file +4
-0+ +/* On BCM6318 setting CLEAR seems to continuously mask interrupts */ +if (of_device_is_compatible (node,"brcm,bcm6318-ext-intc" )) + toggle_clear_on_ack = true;
Seems? What does the documentation says about this?
Quoted 32 lines
drivers/irqchip/irq-bcm6345-ext.c new file +28
-0+ +for (i =0 ; i < num_irqs; i++) { + irqs[i] =irq_of_parse_and_map (node, i); +if (!irqs[i]) +return -ENOMEM ; + } + + base =of_iomap (node,0 ); +if (!base) +return -ENXIO ; + + ret =bcm6345_ext_intc_init (node, num_irqs, irqs, base, shift, + toggle_clear_on_ack); +if (!ret) +return 0 ; + +iounmap (base); + +for (i =0 ; i < num_irqs; i++) +irq_dispose_mapping (irqs[i]); + +return ret; +} + +IRQCHIP_DECLARE (bcm6318_ext_intc,"brcm,bcm6318-ext-intc" , + bcm6345_ext_intc_of_init); +IRQCHIP_DECLARE (bcm6345_ext_intc,"brcm,bcm6345-ext-intc" , + bcm6345_ext_intc_of_init);Signature · 1 line
2.20.1
Thanks,
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
This is supposed to be v3…
Sorry for that. Should I resend?
Quoted 24 lines · Álvaro Fernández Rojas
This interrupt controller is present on bcm63xx SoCs in order to generate interrupts based on GPIO status changes.
v3: pass
dt_binding_check.
v2: fix documentation title typo.Álvaro Fernández Rojas (2):
dt-bindings: interrupt-controller: document BCM6345 external interrupt
controller
irqchip: add support for BCM6345 external interrupt controller.../brcm,bcm6345-ext-intc.yaml | 78 +++++ drivers/irqchip/Kconfig | 4 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-bcm6345-ext.c | 271 ++++++++++++++++++ 4 files changed, 354 insertions(+)create mode 100644
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yamlcreate mode 100644drivers/irqchip/irq-bcm6345-ext.cSignature · 1 line
2.20.1
Quoted 3 lines · Álvaro Fernández Rojas
This is supposed to be v3…
Sorry for that. Should I resend?
No, please. 3 versions in less than 12 hours in the middle of a merge window is bad enough.
Thanks,
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
Hi all,
Apparently these patches were flagged as “Not Applicable” without an explanation. Why?
https://patchwork.kernel.org/project/linux-mips/patch/[email protected]/
https://patchwork.kernel.org/project/linux-mips/patch/[email protected]/
Best regards,
Álvaro.
Quoted 24 lines · Álvaro Fernández Rojas
This interrupt controller is present on bcm63xx SoCs in order to generate interrupts based on GPIO status changes.
v3: pass
dt_binding_check.
v2: fix documentation title typo.Álvaro Fernández Rojas (2):
dt-bindings: interrupt-controller: document BCM6345 external interrupt
controller
irqchip: add support for BCM6345 external interrupt controller.../brcm,bcm6345-ext-intc.yaml | 78 +++++ drivers/irqchip/Kconfig | 4 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-bcm6345-ext.c | 271 ++++++++++++++++++ 4 files changed, 354 insertions(+)create mode 100644
Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yamlcreate mode 100644drivers/irqchip/irq-bcm6345-ext.cSignature · 1 line
2.20.1
Rob Herring
maintainerQuoted 5 lines · Álvaro Fernández Rojas
Hi all,
Apparently these patches were flagged as “Not Applicable” without an explanation. Why?
https://patchwork.kernel.org/project/linux-mips/patch/[email protected]/
https://patchwork.kernel.org/project/linux-mips/patch/[email protected]/
They aren't applied by the MIPS maintainers would be my guess.