perf report: Support sorting by a given event in group
v7 cover perf report: Support sorting by a given event in group
When performing "perf report --group", it shows the event group information together. By default, the output is sorted by the first event in group. It would be nice for user to select any event for sorting.
The patch 1/3 introduces a new option "--group-sort-idx" to sort the output by the event at the index n in event group.
The patch 2/3 creates a new key K_RELOAD to reload the browser.
The patch 3/3 supports hotkeys in browser to select a event to sort.
v7:
---
v6 was posted two months ago and all comments were fixed.
v7 just rebases to perf/core, no other change.
Jin Yao (3):
perf report: Change sort order by a specified event in group perf report: Support a new key to reload the browser
perf report: support hotkey to let user select any event for sorting
tools/perf/Documentation/perf-report.txt | 5 ++ tools/perf/builtin-report.c | 16 +++- tools/perf/ui/browsers/hists.c | 29 ++++++- tools/perf/ui/hist.c | 104 +++++++++++++++++++---- tools/perf/ui/keysyms.h | 1 + tools/perf/util/hist.h | 1 + tools/perf/util/symbol_conf.h | 1 + 7 files changed, 138 insertions(+), 19 deletions(-)
Signature · 1 line
2.17.1
PATCH v7 1/3 perf report: Change sort order by a specified event in group
When performing "perf report --group", it shows the event group information together. By default, the output is sorted by the first event in group.
It would be nice for user to select any event for sorting. This patch introduces a new option "--group-sort-idx" to sort the output by the event at the index n in event group.
For example,
Before:
# perf report --group --stdio
# To display the perf.data header info, please use --header/--header-only options.
#
#
# Total Lost Samples: 0
#
# Samples: 12K of events 'cpu/instructions,period=2000003/, cpu/cpu-cycles,period=200003/, BR_MISP_RETIRED.ALL_BRANCHES:pp, cpu/event=0xc0,umask=1,cmask=1, # Event count (approx.): 6451235635
#
# Overhead Command Shared Object Symbol
# ................................ ......... ....................... ...................................
#
92.19% 98.68% 0.00% 93.30% mgen mgen [.] LOOP1
3.12% 0.29% 0.00% 0.16% gsd-color libglib-2.0.so.0.5600.4 [.] 0x0000000000049515
1.56% 0.03% 0.00% 0.04% gsd-color libglib-2.0.so.0.5600.4 [.] 0x00000000000494b7
1.56% 0.01% 0.00% 0.00% gsd-color libglib-2.0.so.0.5600.4 [.] 0x00000000000494ce
1.56% 0.00% 0.00% 0.00% mgen [kernel.kallsyms] [k] task_tick_fair
0.00% 0.15% 0.00% 0.04% perf [kernel.kallsyms] [k] smp_call_function_single
0.00% 0.13% 0.00% 6.08% swapper [kernel.kallsyms] [k] intel_idle
0.00% 0.03% 0.00% 0.00% gsd-color libglib-2.0.so.0.5600.4 [.] g_main_context_check
0.00% 0.03% 0.00% 0.00% swapper [kernel.kallsyms] [k] apic_timer_interrupt
...After:
# perf report --group --stdio --group-sort-idx 3
# To display the perf.data header info, please use --header/--header-only options.
#
#
# Total Lost Samples: 0
#
# Samples: 12K of events 'cpu/instructions,period=2000003/, cpu/cpu-cycles,period=200003/, BR_MISP_RETIRED.ALL_BRANCHES:pp, cpu/event=0xc0,umask=1,cmask=1, # Event count (approx.): 6451235635
#
# Overhead Command Shared Object Symbol
# ................................ ......... ....................... ...................................
#
92.19% 98.68% 0.00% 93.30% mgen mgen [.] LOOP1
0.00% 0.13% 0.00% 6.08% swapper [kernel.kallsyms] [k] intel_idle
3.12% 0.29% 0.00% 0.16% gsd-color libglib-2.0.so.0.5600.4 [.] 0x0000000000049515
0.00% 0.00% 0.00% 0.06% swapper [kernel.kallsyms] [k] hrtimer_start_range_ns
1.56% 0.03% 0.00% 0.04% gsd-color libglib-2.0.so.0.5600.4 [.] 0x00000000000494b7
0.00% 0.15% 0.00% 0.04% perf [kernel.kallsyms] [k] smp_call_function_single
0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] update_curr
0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] apic_timer_interrupt
0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] native_apic_msr_eoi_write
0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] __update_load_avg_se
0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] scheduler_tickNow the output is sorted by the fourth event in group.
v7:
---
Rebase to latest perf/core, no other change.
v6:
---
No change.
v5:
---
No change in v5.
v4 has been ACKed by Jiri.
v4:
---
1. Update Documentation/perf-report.txt to mention '--group-sort-idx' support multiple groups with different amount of events and it should be used on grouped events.
2. Update __hpp__group_sort_idx(), just return when the idx is out of limit.
3. Return failure on symbol_conf.group_sort_idx && !session->evlist->nr_groups. So now we don't need to use together with --group.
v3:
---
Refine the code in __hpp__group_sort_idx().
Before:
for (i = 1; i < nr_members; i++) {
if (i == idx) {
ret = field_cmp(fields_a[i], fields_b[i]);
if (ret)
goto out;
}}
After:
if (idx >= 1 && idx < nr_members) {
ret = field_cmp(fields_a[idx], fields_b[idx]);
if (ret)
goto out;}
v2:
---
No change
--- tools/perf/Documentation/perf-report.txt | 5 ++ tools/perf/builtin-report.c | 10 +++ tools/perf/ui/hist.c | 104 +++++++++++++++++++---- tools/perf/util/symbol_conf.h | 1 + 4 files changed, 105 insertions(+), 15 deletions(-)
tools/perf/Documentation/perf-report.txt +5 -0
@@ -377,6 +377,11 @@ OPTIONS Show event group information together. It forces group output also if there are no groups defined in data file. +--group-sort-idx:: + Sort the output by the event at the index n in group. If n is invalid, + sort by the first event. It can support multiple groups with different + amount of events. WARNING: This should be used on grouped events. + --demangle:: Demangle symbol names to human readable form. It's enabled by default, disable with --no-demangle.
tools/perf/builtin-report.c +10 -0
@@ -1216,6 +1216,10 @@ int cmd_report(int argc, const char **argv) "Show a column with the sum of periods"),OPT_BOOLEAN_SET (0 ,"group" , &symbol_conf.event_group, &report.group_set,"Show event group information together" ), +OPT_INTEGER (0 ,"group-sort-idx" , &symbol_conf.group_sort_idx, +"Sort the output by the event at the index n in group. " +"If n is invalid, sort by the first event. " +"WARNING: should be used on grouped events." ),OPT_CALLBACK_NOOPT ('b' ,"branch-stack" , &branch_mode,"" ,"use branch records for per branch histogram filling" , parse_branch_mode),
@@ -1358,6 +1362,12 @@ int cmd_report(int argc, const char **argv)setup_forced_leader (&report, session->evlist); +if (symbol_conf.group_sort_idx && !session->evlist->nr_groups) { +parse_options_usage (NULL , options,"group-sort-idx" ,0 ); + ret = -EINVAL ; + goto error; + } +if (itrace_synth_opts.last_branch) has_br_stack = true;
tools/perf/ui/hist.c +89 -15
126 lines not on this page · raw message
tools/perf/util/symbol_conf.h +1 -0
@@ -73,6 +73,7 @@ struct symbol_conf {const char *symfs;int res_sample;int pad_output_len_dso; +int group_sort_idx; };extern struct symbol_conf symbol_conf;
Signature · 1 line
2.17.1
Re: [PATCH v7 1/3] perf report: Change sort order by a specified event in group
Em Thu, Feb 20, 2020 at 09:36:14AM +0800, Jin Yao escreveu:
Quoted 10 lines
When performing "perf report --group", it shows the event group information together. By default, the output is sorted by the first event in group.
It would be nice for user to select any event for sorting. This patch introduces a new option "--group-sort-idx" to sort the output by the event at the index n in event group.
For example,
Before:
Tested and applied, I also did the following simplifications, to try and follow naming conventions and use less lines to do the same thing:
tools/perf/ui/hist.c +16 -27
@@ -151,44 +151,35 @@ static int field_cmp(u64 field_a, u64 field_b)return 0 ; } -static int pair_fields_alloc (struct hist_entry *a,struct hist_entry *b, -hpp_field_fn get_field,int nr_members, -u64 **fields_a,u64 **fields_b) +static int hist_entry__new_pair (struct hist_entry *a,struct hist_entry *b, +hpp_field_fn get_field,int nr_members, +u64 **fields_a,u64 **fields_b) { -struct evsel *evsel; +u64 *fa =calloc (nr_members,sizeof (*fa)), + *fb =calloc (nr_members,sizeof (*fb));struct hist_entry *pair; -u64 *fa, *fb; -int ret =-1 ; - - fa =calloc (nr_members,sizeof (*fa)); - fb =calloc (nr_members,sizeof (*fb));if (!fa || !fb) - goto out; + goto out_free;list_for_each_entry (pair, &a->pairs.head, pairs.node) { - evsel =hists_to_evsel (pair->hists); +struct evsel *evsel =hists_to_evsel (pair->hists); fa[perf_evsel__group_idx (evsel)] =get_field (pair); }list_for_each_entry (pair, &b->pairs.head, pairs.node) { - evsel =hists_to_evsel (pair->hists); +struct evsel *evsel =hists_to_evsel (pair->hists); fb[perf_evsel__group_idx (evsel)] =get_field (pair); } *fields_a = fa; *fields_b = fb; - ret =0 ; - -out: -if (ret !=0 ) { -free (fa); -free (fb); - *fields_a =NULL ; - *fields_b =NULL ; - } - -return ret; +return 0 ; +out_free: +free (fa); +free (fb); + *fields_a = *fields_b =NULL ; +return -1 ; } static int __hpp__group_sort_idx(struct hist_entry *a, struct hist_entry *b,
@@ -206,8 +197,7 @@ static int __hpp__group_sort_idx(struct hist_entry *a, struct hist_entry *b,if (idx <1 || idx >= nr_members)return cmp; - ret =pair_fields_alloc (a, b, get_field, nr_members, - &fields_a, &fields_b); + ret =hist_entry__new_pair (a, b, get_field, nr_members, &fields_a, &fields_b);if (ret) { ret = cmp; goto out;
@@ -254,8 +244,7 @@ static int __hpp__sort(struct hist_entry *a, struct hist_entry *b,return ret; nr_members = evsel->core.nr_members; - i =pair_fields_alloc (a, b, get_field, nr_members, - &fields_a, &fields_b); + i =hist_entry__new_pair (a, b, get_field, nr_members, &fields_a, &fields_b);if (i) goto out;
Re: [PATCH v7 1/3] perf report: Change sort order by a specified event in group
Quoted 90 lines · Arnaldo Carvalho de Melo
Em Thu, Feb 20, 2020 at 09:36:14AM +0800, Jin Yao escreveu:
Quoted 10 lines
When performing "perf report --group", it shows the event group information together. By default, the output is sorted by the first event in group.
It would be nice for user to select any event for sorting. This patch introduces a new option "--group-sort-idx" to sort the output by the event at the index n in event group.
For example,
Before:
Tested and applied, I also did the following simplifications, to try and follow naming conventions and use less lines to do the same thing:
tools/perf/ui/hist.c +15
-25@@ -151,44 +151,35 @@ static int field_cmp(u64 field_a, u64 field_b)return 0 ; } -static int pair_fields_alloc (struct hist_entry *a,struct hist_entry *b, -hpp_field_fn get_field,int nr_members, -u64 **fields_a,u64 **fields_b) +static int hist_entry__new_pair (struct hist_entry *a,struct hist_entry *b, +hpp_field_fn get_field,int nr_members, +u64 **fields_a,u64 **fields_b) { -struct evsel *evsel; +u64 *fa =calloc (nr_members,sizeof (*fa)), + *fb =calloc (nr_members,sizeof (*fb));struct hist_entry *pair; -u64 *fa, *fb; -int ret =-1 ; - - fa =calloc (nr_members,sizeof (*fa)); - fb =calloc (nr_members,sizeof (*fb));if (!fa || !fb) - goto out; + goto out_free;list_for_each_entry (pair, &a->pairs.head, pairs.node) { - evsel =hists_to_evsel (pair->hists); +struct evsel *evsel =hists_to_evsel (pair->hists); fa[perf_evsel__group_idx (evsel)] =get_field (pair); }list_for_each_entry (pair, &b->pairs.head, pairs.node) { - evsel =hists_to_evsel (pair->hists); +struct evsel *evsel =hists_to_evsel (pair->hists); fb[perf_evsel__group_idx (evsel)] =get_field (pair); } *fields_a = fa; *fields_b = fb; - ret =0 ; - -out: -if (ret !=0 ) { -free (fa); -free (fb); - *fields_a =NULL ; - *fields_b =NULL ; - } - -return ret; +return 0 ; +out_free: +free (fa); +free (fb); + *fields_a = *fields_b =NULL ; +return -1 ; } static int __hpp__group_sort_idx(struct hist_entry *a, struct hist_entry *b,@@ -206,8 +197,7 @@ static int __hpp__group_sort_idx(struct hist_entry *a, struct hist_entry *b,if (idx <1 || idx >= nr_members)return cmp; - ret =pair_fields_alloc (a, b, get_field, nr_members, - &fields_a, &fields_b); + ret =hist_entry__new_pair (a, b, get_field, nr_members, &fields_a, &fields_b);if (ret) { ret = cmp; goto out;
tools/perf/ui/hist.c static int __hpp__sort(struct hist_entry *a, struct hist_entry *b, · line 250
Quoted 9 lines
tools/perf/ui/hist.c +1
-2@@ -254,8 +244,7 @@ static int __hpp__sort(struct hist_entry *a, struct hist_entry *b,return ret; nr_members = evsel->core.nr_members; - i =pair_fields_alloc (a, b, get_field, nr_members, - &fields_a, &fields_b); + i =hist_entry__new_pair (a, b, get_field, nr_members, &fields_a, &fields_b);if (i) goto out;
Thanks for refining the patch!
Thanks
Jin Yao
[tip: perf/urgent] perf report: Allow specifying event to be used as sort key in --group output
In reply to Jin YaoThe following commit has been merged into the perf/urgent branch of tip:
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: 429a5f9d89fc52256b2a59cd1277afbfafb739b3 Gitweb: https://git.kernel.org/tip/429a5f9d89fc52256b2a59cd1277afbfafb739b3 Author: Jin Yao <[email protected]> AuthorDate: Thu, 20 Feb 2020 09:36:14 +08:00 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitterDate: Tue, 24 Mar 2020 09:37:27 -03:00
perf report: Allow specifying event to be used as sort key in --group output
When performing "perf report --group", it shows the event group information together. By default, the output is sorted by the first event in group.
It would be nice for user to select any event for sorting. This patch introduces a new option "--group-sort-idx" to sort the output by the event at the index n in event group.
For example,
Before:
# perf report --group --stdio
# To display the perf.data header info, please use --header/--header-only options.
#
#
# Total Lost Samples: 0
#
# Samples: 12K of events 'cpu/instructions,period=2000003/, cpu/cpu-cycles,period=200003/, BR_MISP_RETIRED.ALL_BRANCHES:pp, cpu/event=0xc0,umask=1,cmask=1, # Event count (approx.): 6451235635
#
# Overhead Command Shared Object Symbol
# ................................ ......... ....................... ...................................
#
92.19% 98.68% 0.00% 93.30% mgen mgen [.] LOOP1
3.12% 0.29% 0.00% 0.16% gsd-color libglib-2.0.so.0.5600.4 [.] 0x0000000000049515
1.56% 0.03% 0.00% 0.04% gsd-color libglib-2.0.so.0.5600.4 [.] 0x00000000000494b7
1.56% 0.01% 0.00% 0.00% gsd-color libglib-2.0.so.0.5600.4 [.] 0x00000000000494ce
1.56% 0.00% 0.00% 0.00% mgen [kernel.kallsyms] [k] task_tick_fair
0.00% 0.15% 0.00% 0.04% perf [kernel.kallsyms] [k] smp_call_function_single
0.00% 0.13% 0.00% 6.08% swapper [kernel.kallsyms] [k] intel_idle
0.00% 0.03% 0.00% 0.00% gsd-color libglib-2.0.so.0.5600.4 [.] g_main_context_check
0.00% 0.03% 0.00% 0.00% swapper [kernel.kallsyms] [k] apic_timer_interrupt
...After:
# perf report --group --stdio --group-sort-idx 3
# To display the perf.data header info, please use --header/--header-only options.
#
#
# Total Lost Samples: 0
#
# Samples: 12K of events 'cpu/instructions,period=2000003/, cpu/cpu-cycles,period=200003/, BR_MISP_RETIRED.ALL_BRANCHES:pp, cpu/event=0xc0,umask=1,cmask=1, # Event count (approx.): 6451235635
#
# Overhead Command Shared Object Symbol
# ................................ ......... ....................... ...................................
#
92.19% 98.68% 0.00% 93.30% mgen mgen [.] LOOP1
0.00% 0.13% 0.00% 6.08% swapper [kernel.kallsyms] [k] intel_idle
3.12% 0.29% 0.00% 0.16% gsd-color libglib-2.0.so.0.5600.4 [.] 0x0000000000049515
0.00% 0.00% 0.00% 0.06% swapper [kernel.kallsyms] [k] hrtimer_start_range_ns
1.56% 0.03% 0.00% 0.04% gsd-color libglib-2.0.so.0.5600.4 [.] 0x00000000000494b7
0.00% 0.15% 0.00% 0.04% perf [kernel.kallsyms] [k] smp_call_function_single
0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] update_curr
0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] apic_timer_interrupt
0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] native_apic_msr_eoi_write
0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] __update_load_avg_se
0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] scheduler_tickNow the output is sorted by the fourth event in group.
v7:
---
Rebase to latest perf/core, no other change.
v4:
---
1. Update Documentation/perf-report.txt to mention '--group-sort-idx' support multiple groups with different amount of events and it should be used on grouped events.
2. Update __hpp__group_sort_idx(), just return when the idx is out of limit.
3. Return failure on symbol_conf.group_sort_idx && !session->evlist->nr_groups. So now we don't need to use together with --group.
v3:
---
Refine the code in __hpp__group_sort_idx().
Before:
for (i = 1; i < nr_members; i++) {
if (i == idx) {
ret = field_cmp(fields_a[i], fields_b[i]);
if (ret)
goto out;
}}
After:
if (idx >= 1 && idx < nr_members) {
ret = field_cmp(fields_a[idx], fields_b[idx]);
if (ret)
goto out;}
--- tools/perf/Documentation/perf-report.txt | 5 +- tools/perf/builtin-report.c | 10 ++- tools/perf/ui/hist.c | 93 +++++++++++++++++++---- tools/perf/util/symbol_conf.h | 1 +- 4 files changed, 94 insertions(+), 15 deletions(-)
tools/perf/Documentation/perf-report.txt +5 -0
@@ -377,6 +377,11 @@ OPTIONS Show event group information together. It forces group output also if there are no groups defined in data file. +--group-sort-idx:: + Sort the output by the event at the index n in group. If n is invalid, + sort by the first event. It can support multiple groups with different + amount of events. WARNING: This should be used on grouped events. + --demangle:: Demangle symbol names to human readable form. It's enabled by default, disable with --no-demangle.
tools/perf/builtin-report.c +10 -0
@@ -1227,6 +1227,10 @@ int cmd_report(int argc, const char **argv) "Show a column with the sum of periods"),OPT_BOOLEAN_SET (0 ,"group" , &symbol_conf.event_group, &report.group_set,"Show event group information together" ), +OPT_INTEGER (0 ,"group-sort-idx" , &symbol_conf.group_sort_idx, +"Sort the output by the event at the index n in group. " +"If n is invalid, sort by the first event. " +"WARNING: should be used on grouped events." ),OPT_CALLBACK_NOOPT ('b' ,"branch-stack" , &branch_mode,"" ,"use branch records for per branch histogram filling" , parse_branch_mode),
@@ -1369,6 +1373,12 @@ repeat:setup_forced_leader (&report, session->evlist); +if (symbol_conf.group_sort_idx && !session->evlist->nr_groups) { +parse_options_usage (NULL , options,"group-sort-idx" ,0 ); + ret = -EINVAL ; + goto error; + } +if (itrace_synth_opts.last_branch) has_br_stack = true;
tools/perf/ui/hist.c +78 -15
115 lines not on this page · raw message
tools/perf/util/symbol_conf.h +1 -0
@@ -73,6 +73,7 @@ struct symbol_conf {const char *symfs;int res_sample;int pad_output_len_dso; +int group_sort_idx; };extern struct symbol_conf symbol_conf;
PATCH v7 2/3 perf report: Support a new key to reload the browser
In reply to Jin YaoSometimes we may need to reload the browser to update the output since some options are changed.
This patch creates a new key K_RELOAD. Once the __cmd_report() returns K_RELOAD, it would repeat the whole process, such as, read samples from data file, sort the data and display in the browser.
v7:
---
Rebase to perf/core, no other change.
v6:
---
No change.
v5:
---
1. Fix the 'make NO_SLANG=1' error. Define K_RELOAD in util/hist.h.
2. Skip setup_sorting() in repeat path if last key is K_RELOAD.
v4:
---
Need to quit in perf_evsel_menu__run if key is K_RELOAD.
v3:
---
No change.
v2:
---
This is a new patch created in v2.
--- tools/perf/builtin-report.c | 6 +++--- tools/perf/ui/browsers/hists.c | 1 + tools/perf/ui/keysyms.h | 1 + tools/perf/util/hist.h | 1 + 4 files changed, 6 insertions(+), 3 deletions(-)
tools/perf/builtin-report.c +3 -3
@@ -635,7 +635,7 @@ static int report__browse_hists(struct report *rep)* Usually "ret" is the last pressed key, and we only * care if the key notifies us to switch data file. */ -if (ret !=K_SWITCH_INPUT_DATA ) +if (ret !=K_SWITCH_INPUT_DATA && ret !=K_RELOAD ) ret =0 ;break ;case 2 :
@@ -1469,7 +1469,7 @@ int cmd_report(int argc, const char **argv) sort_order = sort_tmp; } -if ((last_key !=K_SWITCH_INPUT_DATA ) && +if ((last_key !=K_SWITCH_INPUT_DATA && last_key !=K_RELOAD ) && (setup_sorting (session->evlist) <0 )) {if (sort_order)parse_options_usage (report_usage, options,"s" ,1 );
@@ -1548,7 +1548,7 @@ int cmd_report(int argc, const char **argv)sort__setup_elide (stdout); ret =__cmd_report (&report); -if (ret ==K_SWITCH_INPUT_DATA ) { +if (ret ==K_SWITCH_INPUT_DATA || ret ==K_RELOAD ) {perf_session__delete (session); last_key =K_SWITCH_INPUT_DATA ; goto repeat;
tools/perf/ui/browsers/hists.c +1 -0
@@ -3440,6 +3440,7 @@ static int perf_evsel_menu__run(struct evsel_menu *menu, pos =perf_evsel__prev (pos); goto browse_hists;case K_SWITCH_INPUT_DATA : +case K_RELOAD :case 'q' :case CTRL ('c' ): goto out;
tools/perf/ui/keysyms.h +1 -0
@@ -25,5 +25,6 @@#define K_ERROR -2#define K_RESIZE -3#define K_SWITCH_INPUT_DATA -4 +#define K_RELOAD -5#endif /* _PERF_KEYSYMS_H_ */
tools/perf/util/hist.h +1 -0
@@ -536,6 +536,7 @@ static inline int block_hists_tui_browse(struct block_hist *bh __maybe_unused,#define K_LEFT -1000#define K_RIGHT -2000#define K_SWITCH_INPUT_DATA -3000 +#define K_RELOAD -4000#endif unsigned int hists__sort_list_width (struct hists *hists);
Signature · 1 line
2.17.1
Re: [PATCH v7 2/3] perf report: Support a new key to reload the browser
Em Thu, Feb 20, 2020 at 09:36:15AM +0800, Jin Yao escreveu:
Quoted 63 lines
Sometimes we may need to reload the browser to update the output since some options are changed.
This patch creates a new key
K_RELOAD. Once the__cmd_report()returnsK_RELOAD, it would repeat the whole process, such as, read samples from data file, sort the data and display in the browser.v7:
---
Rebase to perf/core, no other change.v6:
---
No change.v5:
---
1. Fix the 'make NO_SLANG=1' error. DefineK_RELOADinutil/hist.h.
2. Skipsetup_sorting()in repeat path if last key isK_RELOAD.v4:
---
Need to quit inperf_evsel_menu__runif key isK_RELOAD.v3:
---
No change.v2:
---
This is a new patch created in v2.Signed-off-by Jin Yao <[email protected]>--- tools/perf/builtin-report.c | 6 +++--- tools/perf/ui/browsers/hists.c | 1 + tools/perf/ui/keysyms.h | 1 + tools/perf/util/hist.h | 1 + 4 files changed, 6 insertions(+), 3 deletions(-)tools/perf/builtin-report.c +2
-2@@ -635,7 +635,7 @@ static int report__browse_hists(struct report *rep)* Usually "ret" is the last pressed key, and we only * care if the key notifies us to switch data file. */ -if (ret !=K_SWITCH_INPUT_DATA ) +if (ret !=K_SWITCH_INPUT_DATA && ret !=K_RELOAD ) ret =0 ;break ;case 2 :@@ -1469,7 +1469,7 @@ int cmd_report(int argc, const char **argv) sort_order = sort_tmp; } -if ((last_key !=K_SWITCH_INPUT_DATA ) && +if ((last_key !=K_SWITCH_INPUT_DATA && last_key !=K_RELOAD ) && (setup_sorting (session->evlist) <0 )) {if (sort_order)parse_options_usage (report_usage, options,"s" ,1 );
tools/perf/builtin-report.c int cmd_report(int argc, const char **argv) · line 1553
Quoted 7 lines
tools/perf/builtin-report.c +1
-1@@ -1548,7 +1548,7 @@ int cmd_report(int argc, const char **argv)sort__setup_elide (stdout); ret =__cmd_report (&report); -if (ret ==K_SWITCH_INPUT_DATA ) { +if (ret ==K_SWITCH_INPUT_DATA || ret ==K_RELOAD ) {perf_session__delete (session); last_key =K_SWITCH_INPUT_DATA ;
Are you sure this shouldn't be:
last_key = ret;
?
I'm applying it to test now anyway,
- Arnaldo
Quoted 39 lines
tools/perf/builtin-report.c +0
-0goto repeat;tools/perf/ui/browsers/hists.c +1
-0@@ -3440,6 +3440,7 @@ static int perf_evsel_menu__run(struct evsel_menu *menu, pos =perf_evsel__prev (pos); goto browse_hists;case K_SWITCH_INPUT_DATA : +case K_RELOAD :case 'q' :case CTRL ('c' ): goto out;tools/perf/ui/keysyms.h +1
-0@@ -25,5 +25,6 @@#define K_ERROR -2#define K_RESIZE -3#define K_SWITCH_INPUT_DATA -4 +#define K_RELOAD -5#endif /* _PERF_KEYSYMS_H_ */ tools/perf/util/hist.h +1
-0@@ -536,6 +536,7 @@ static inline int block_hists_tui_browse(struct block_hist *bh __maybe_unused,#define K_LEFT -1000#define K_RIGHT -2000#define K_SWITCH_INPUT_DATA -3000 +#define K_RELOAD -4000#endif unsigned int hists__sort_list_width (struct hists *hists);Signature · 1 line
2.17.1
Signature · 1 line
- Arnaldo
Re: [PATCH v7 2/3] perf report: Support a new key to reload the browser
Quoted 74 lines · Arnaldo Carvalho de Melo
Em Thu, Feb 20, 2020 at 09:36:15AM +0800, Jin Yao escreveu:
Quoted 63 lines
Sometimes we may need to reload the browser to update the output since some options are changed.
This patch creates a new key
K_RELOAD. Once the__cmd_report()returnsK_RELOAD, it would repeat the whole process, such as, read samples from data file, sort the data and display in the browser.v7:
---
Rebase to perf/core, no other change.v6:
---
No change.v5:
---
1. Fix the 'make NO_SLANG=1' error. DefineK_RELOADinutil/hist.h.
2. Skipsetup_sorting()in repeat path if last key isK_RELOAD.v4:
---
Need to quit inperf_evsel_menu__runif key isK_RELOAD.v3:
---
No change.v2:
---
This is a new patch created in v2.Signed-off-by Jin Yao <[email protected]>--- tools/perf/builtin-report.c | 6 +++--- tools/perf/ui/browsers/hists.c | 1 + tools/perf/ui/keysyms.h | 1 + tools/perf/util/hist.h | 1 + 4 files changed, 6 insertions(+), 3 deletions(-)tools/perf/builtin-report.c +2
-2@@ -635,7 +635,7 @@ static int report__browse_hists(struct report *rep)* Usually "ret" is the last pressed key, and we only * care if the key notifies us to switch data file. */ -if (ret !=K_SWITCH_INPUT_DATA ) +if (ret !=K_SWITCH_INPUT_DATA && ret !=K_RELOAD ) ret =0 ;break ;case 2 :@@ -1469,7 +1469,7 @@ int cmd_report(int argc, const char **argv) sort_order = sort_tmp; } -if ((last_key !=K_SWITCH_INPUT_DATA ) && +if ((last_key !=K_SWITCH_INPUT_DATA && last_key !=K_RELOAD ) && (setup_sorting (session->evlist) <0 )) {if (sort_order)parse_options_usage (report_usage, options,"s" ,1 );tools/perf/builtin-report.c int cmd_report(int argc, const char **argv) · line 1553
Quoted 7 lines
tools/perf/builtin-report.c +1
-1@@ -1548,7 +1548,7 @@ int cmd_report(int argc, const char **argv)sort__setup_elide (stdout); ret =__cmd_report (&report); -if (ret ==K_SWITCH_INPUT_DATA ) { +if (ret ==K_SWITCH_INPUT_DATA || ret ==K_RELOAD ) {perf_session__delete (session); last_key =K_SWITCH_INPUT_DATA ;Are you sure this shouldn't be:
Quoted 4 lines
last_key = ret;?
Yes, it should not be. We can reuse original flow for processing K_SWITCH_INPUT_DATA.
Quoted 4 lines
I'm applying it to test now anyway,
- Arnaldo
Thanks!
Thanks
Jin Yao
Quoted 40 lines
Quoted 39 lines
tools/perf/builtin-report.c +0
-0goto repeat;tools/perf/ui/browsers/hists.c +1
-0@@ -3440,6 +3440,7 @@ static int perf_evsel_menu__run(struct evsel_menu *menu, pos =perf_evsel__prev (pos); goto browse_hists;case K_SWITCH_INPUT_DATA : +case K_RELOAD :case 'q' :case CTRL ('c' ): goto out;tools/perf/ui/keysyms.h +1
-0@@ -25,5 +25,6 @@#define K_ERROR -2#define K_RESIZE -3#define K_SWITCH_INPUT_DATA -4 +#define K_RELOAD -5#endif /* _PERF_KEYSYMS_H_ */ tools/perf/util/hist.h +1
-0@@ -536,6 +536,7 @@ static inline int block_hists_tui_browse(struct block_hist *bh __maybe_unused,#define K_LEFT -1000#define K_RIGHT -2000#define K_SWITCH_INPUT_DATA -3000 +#define K_RELOAD -4000#endif unsigned int hists__sort_list_width (struct hists *hists);Signature · 1 line
2.17.1
[tip: perf/urgent] perf report: Support a new key to reload the browser
In reply to Jin YaoThe following commit has been merged into the perf/urgent branch of tip:
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: 5e3b810aac49e960c80529e2c9aa8c101c5848ce Gitweb: https://git.kernel.org/tip/5e3b810aac49e960c80529e2c9aa8c101c5848ce Author: Jin Yao <[email protected]> AuthorDate: Thu, 20 Feb 2020 09:36:15 +08:00 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitterDate: Tue, 24 Mar 2020 09:37:27 -03:00
perf report: Support a new key to reload the browser
Sometimes we may need to reload the browser to update the output since some options are changed.
This patch creates a new key K_RELOAD. Once the __cmd_report() returns K_RELOAD, it would repeat the whole process, such as, read samples from data file, sort the data and display in the browser.
v5:
---
1. Fix the 'make NO_SLANG=1' error. Define K_RELOAD in util/hist.h.
2. Skip setup_sorting() in repeat path if last key is K_RELOAD.
v4:
---
Need to quit in perf_evsel_menu__run if key is K_RELOAD.
--- tools/perf/builtin-report.c | 6 +++--- tools/perf/ui/browsers/hists.c | 1 + tools/perf/ui/keysyms.h | 1 + tools/perf/util/hist.h | 1 + 4 files changed, 6 insertions(+), 3 deletions(-)
tools/perf/builtin-report.c +3 -3
@@ -635,7 +635,7 @@ static int report__browse_hists(struct report *rep)* Usually "ret" is the last pressed key, and we only * care if the key notifies us to switch data file. */ -if (ret !=K_SWITCH_INPUT_DATA ) +if (ret !=K_SWITCH_INPUT_DATA && ret !=K_RELOAD ) ret =0 ;break ;case 2 :
@@ -1480,7 +1480,7 @@ repeat: sort_order = sort_tmp; } -if ((last_key !=K_SWITCH_INPUT_DATA ) && +if ((last_key !=K_SWITCH_INPUT_DATA && last_key !=K_RELOAD ) && (setup_sorting (session->evlist) <0 )) {if (sort_order)parse_options_usage (report_usage, options,"s" ,1 );
@@ -1559,7 +1559,7 @@ repeat:sort__setup_elide (stdout); ret =__cmd_report (&report); -if (ret ==K_SWITCH_INPUT_DATA ) { +if (ret ==K_SWITCH_INPUT_DATA || ret ==K_RELOAD ) {perf_session__delete (session); last_key =K_SWITCH_INPUT_DATA ; goto repeat;
tools/perf/ui/browsers/hists.c +1 -0
@@ -3495,6 +3495,7 @@ browse_hists: pos =perf_evsel__prev (pos); goto browse_hists;case K_SWITCH_INPUT_DATA : +case K_RELOAD :case 'q' :case CTRL ('c' ): goto out;
tools/perf/ui/keysyms.h +1 -0
@@ -25,5 +25,6 @@#define K_ERROR -2#define K_RESIZE -3#define K_SWITCH_INPUT_DATA -4 +#define K_RELOAD -5#endif /* _PERF_KEYSYMS_H_ */
tools/perf/util/hist.h +1 -0
@@ -536,6 +536,7 @@ static inline int block_hists_tui_browse(struct block_hist *bh __maybe_unused,#define K_LEFT -1000#define K_RIGHT -2000#define K_SWITCH_INPUT_DATA -3000 +#define K_RELOAD -4000#endif unsigned int hists__sort_list_width (struct hists *hists);
PATCH v7 3/3 perf report: support hotkey to let user select any event for sorting
In reply to Jin YaoWhen performing "perf report --group", it shows the event group information together. In previous patch, we have supported a new option "--group-sort-idx" to sort the output by the event at the index n in event group.
It would be nice if we can use a hotkey in browser to select a event to sort.
For example,
# perf report --group
Samples: 12K of events 'cpu/instructions,period=2000003/, cpu/cpu-cycles,period=200003/, ...
Overhead Command Shared Object Symbol 92.19% 98.68% 0.00% 93.30% mgen mgen [.] LOOP1 3.12% 0.29% 0.00% 0.16% gsd-color libglib-2.0.so.0.5600.4 [.] 0x0000000000049515 1.56% 0.03% 0.00% 0.04% gsd-color libglib-2.0.so.0.5600.4 [.] 0x00000000000494b7 1.56% 0.01% 0.00% 0.00% gsd-color libglib-2.0.so.0.5600.4 [.] 0x00000000000494ce 1.56% 0.00% 0.00% 0.00% mgen [kernel.kallsyms] [k] task_tick_fair 0.00% 0.15% 0.00% 0.04% perf [kernel.kallsyms] [k] smp_call_function_single 0.00% 0.13% 0.00% 6.08% swapper [kernel.kallsyms] [k] intel_idle 0.00% 0.03% 0.00% 0.00% gsd-color libglib-2.0.so.0.5600.4 [.] g_main_context_check 0.00% 0.03% 0.00% 0.00% swapper [kernel.kallsyms] [k] apic_timer_interrupt 0.00% 0.03% 0.00% 0.00% swapper [kernel.kallsyms] [k] check_preempt_curr
When user press hotkey '3' (event index, starting from 0), it indicates to sort output by the forth event in group.
Samples: 12K of events 'cpu/instructions,period=2000003/, cpu/cpu-cycles,period=200003/, ...
Overhead Command Shared Object Symbol 92.19% 98.68% 0.00% 93.30% mgen mgen [.] LOOP1 0.00% 0.13% 0.00% 6.08% swapper [kernel.kallsyms] [k] intel_idle 3.12% 0.29% 0.00% 0.16% gsd-color libglib-2.0.so.0.5600.4 [.] 0x0000000000049515 0.00% 0.00% 0.00% 0.06% swapper [kernel.kallsyms] [k] hrtimer_start_range_ns 1.56% 0.03% 0.00% 0.04% gsd-color libglib-2.0.so.0.5600.4 [.] 0x00000000000494b7 0.00% 0.15% 0.00% 0.04% perf [kernel.kallsyms] [k] smp_call_function_single 0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] update_curr 0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] apic_timer_interrupt 0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] native_apic_msr_eoi_write 0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] __update_load_avg_se
v7:
---
Rebase to perf/core, no other change.
v6:
---
Jiri provided a good improvement to eliminate unneeded refresh. This improvement is added to v6.
v5:
---
No change
v4:
---
No change
v3:
---
No change
v2:
---
1. Report warning at helpline when index is invalid.
2. Report warning at helpline when it's not group event.
3. Use "case '0' ... '9'" to refine the code
4. Split K_RELOAD implementation to another patch.
--- tools/perf/ui/browsers/hists.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-)
tools/perf/ui/browsers/hists.c +27 -1
@@ -2964,7 +2964,8 @@ static int perf_evsel__hists_browse(struct evsel *evsel, int nr_events,"s Switch to another data file in PWD\n" "t Zoom into current Thread\n" "V Verbose (DSO names in callchains, etc)\n" -"/ Filter symbol by name" ; +"/ Filter symbol by name\n" +"0-9 Sort by event n in group" ;static const char top_help[] =HIST_BROWSER_HELP_COMMON "P Print histograms to perf.hist.N\n" "t Zoom into current Thread\n"
@@ -3025,6 +3026,31 @@ static int perf_evsel__hists_browse(struct evsel *evsel, int nr_events,* go to the next or previous */ goto out_free_stack; + case '0' ... '9': +if (!symbol_conf.event_group || + evsel->core.nr_members <2 ) { +snprintf (buf,sizeof (buf), +"Sort by index only available with group events!" ); + helpline = buf; +continue ; + } + +if (key -'0' == symbol_conf.group_sort_idx) +continue ; + + symbol_conf.group_sort_idx = key -'0' ; + +if (symbol_conf.group_sort_idx >= evsel->core.nr_members) { +snprintf (buf,sizeof (buf), +"Max event group index to sort is %d (index from 0 to %d)" , + evsel->core.nr_members -1 , + evsel->core.nr_members -1 ); + helpline = buf; +continue ; + } + + key =K_RELOAD ; + goto out_free_stack;case 'a' :if (!hists__has (hists, sym)) { ui_browser__warning(&browser->b, delay_secs * 2,
Signature · 1 line
2.17.1
[tip: perf/urgent] perf report/top TUI: Support hotkeys to let user select any event for sorting
The following commit has been merged into the perf/urgent branch of tip:
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: dbddf17474411f5725fc76fc7e507410f0d4077f Gitweb: https://git.kernel.org/tip/dbddf17474411f5725fc76fc7e507410f0d4077f Author: Jin Yao <[email protected]> AuthorDate: Thu, 20 Feb 2020 09:36:16 +08:00 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitterDate: Tue, 24 Mar 2020 09:37:27 -03:00
perf report/top TUI: Support hotkeys to let user select any event for sorting
When performing "perf report --group", it shows the event group information together. In previous patch, we have supported a new option "--group-sort-idx" to sort the output by the event at the index n in event group.
It would be nice if we can use a hotkey in browser to select a event to sort.
For example,
# perf report --group
Samples: 12K of events 'cpu/instructions,period=2000003/, cpu/cpu-cycles,period=200003/, ...
Overhead Command Shared Object Symbol 92.19% 98.68% 0.00% 93.30% mgen mgen [.] LOOP1 3.12% 0.29% 0.00% 0.16% gsd-color libglib-2.0.so.0.5600.4 [.] 0x0000000000049515 1.56% 0.03% 0.00% 0.04% gsd-color libglib-2.0.so.0.5600.4 [.] 0x00000000000494b7 1.56% 0.01% 0.00% 0.00% gsd-color libglib-2.0.so.0.5600.4 [.] 0x00000000000494ce 1.56% 0.00% 0.00% 0.00% mgen [kernel.kallsyms] [k] task_tick_fair 0.00% 0.15% 0.00% 0.04% perf [kernel.kallsyms] [k] smp_call_function_single 0.00% 0.13% 0.00% 6.08% swapper [kernel.kallsyms] [k] intel_idle 0.00% 0.03% 0.00% 0.00% gsd-color libglib-2.0.so.0.5600.4 [.] g_main_context_check 0.00% 0.03% 0.00% 0.00% swapper [kernel.kallsyms] [k] apic_timer_interrupt 0.00% 0.03% 0.00% 0.00% swapper [kernel.kallsyms] [k] check_preempt_curr
When user press hotkey '3' (event index, starting from 0), it indicates to sort output by the forth event in group.
Samples: 12K of events 'cpu/instructions,period=2000003/, cpu/cpu-cycles,period=200003/, ...
Overhead Command Shared Object Symbol 92.19% 98.68% 0.00% 93.30% mgen mgen [.] LOOP1 0.00% 0.13% 0.00% 6.08% swapper [kernel.kallsyms] [k] intel_idle 3.12% 0.29% 0.00% 0.16% gsd-color libglib-2.0.so.0.5600.4 [.] 0x0000000000049515 0.00% 0.00% 0.00% 0.06% swapper [kernel.kallsyms] [k] hrtimer_start_range_ns 1.56% 0.03% 0.00% 0.04% gsd-color libglib-2.0.so.0.5600.4 [.] 0x00000000000494b7 0.00% 0.15% 0.00% 0.04% perf [kernel.kallsyms] [k] smp_call_function_single 0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] update_curr 0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] apic_timer_interrupt 0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] native_apic_msr_eoi_write 0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] __update_load_avg_se
v6:
---
Jiri provided a good improvement to eliminate unneeded refresh. This improvement is added to v6.
v2:
---
1. Report warning at helpline when index is invalid.
2. Report warning at helpline when it's not group event.
3. Use "case '0' ... '9'" to refine the code
4. Split K_RELOAD implementation to another patch.
--- tools/perf/ui/browsers/hists.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-)
tools/perf/ui/browsers/hists.c +27 -1
@@ -2992,7 +2992,8 @@ static int perf_evsel__hists_browse(struct evsel *evsel, int nr_events,"s Switch to another data file in PWD\n" "t Zoom into current Thread\n" "V Verbose (DSO names in callchains, etc)\n" -"/ Filter symbol by name" ; +"/ Filter symbol by name\n" +"0-9 Sort by event n in group" ;static const char top_help[] =HIST_BROWSER_HELP_COMMON "P Print histograms to perf.hist.N\n" "t Zoom into current Thread\n"
@@ -3053,6 +3054,31 @@ do_hotkey: // key came straight from options ui__popup_menu()* go to the next or previous */ goto out_free_stack; + case '0' ... '9': +if (!symbol_conf.event_group || + evsel->core.nr_members <2 ) { +snprintf (buf,sizeof (buf), +"Sort by index only available with group events!" ); + helpline = buf; +continue ; + } + +if (key -'0' == symbol_conf.group_sort_idx) +continue ; + + symbol_conf.group_sort_idx = key -'0' ; + +if (symbol_conf.group_sort_idx >= evsel->core.nr_members) { +snprintf (buf,sizeof (buf), +"Max event group index to sort is %d (index from 0 to %d)" , + evsel->core.nr_members -1 , + evsel->core.nr_members -1 ); + helpline = buf; +continue ; + } + + key =K_RELOAD ; + goto out_free_stack;case 'a' :if (!hists__has (hists, sym)) { ui_browser__warning(&browser->b, delay_secs * 2,
Arnaldo Carvalho de Melo
AppliedEm Thu, Feb 20, 2020 at 09:36:13AM +0800, Jin Yao escreveu:
Quoted 11 lines
When performing "perf report --group", it shows the event group information together. By default, the output is sorted by the first event in group. It would be nice for user to select any event for sorting.
The patch 1/3 introduces a new option "--group-sort-idx" to sort the output by the event at the index n in event group.
The patch 2/3 creates a new key
K_RELOADto reload the browser.The patch 3/3 supports hotkeys in browser to select a event to sort.
Thanks, applied.
- Arnaldo
Quoted 23 lines
v7:
---
v6 was posted two months ago and all comments were fixed.v7 just rebases to perf/core, no other change.
Jin Yao (3):
perf report: Change sort order by a specified event in group perf report: Support a new key to reload the browser
perf report: support hotkey to let user select any event for sortingtools/perf/Documentation/perf-report.txt | 5 ++ tools/perf/builtin-report.c | 16 +++- tools/perf/ui/browsers/hists.c | 29 ++++++- tools/perf/ui/hist.c | 104 +++++++++++++++++++---- tools/perf/ui/keysyms.h | 1 + tools/perf/util/hist.h | 1 + tools/perf/util/symbol_conf.h | 1 + 7 files changed, 138 insertions(+), 19 deletions(-)Signature · 1 line
2.17.1
Signature · 1 line
- Arnaldo
Em Wed, Mar 18, 2020 at 04:01:16PM -0300, Arnaldo Carvalho de Melo escreveu:
Quoted 8 lines
Em Thu, Feb 20, 2020 at 09:36:13AM +0800, Jin Yao escreveu:
Quoted 7 lines
When performing "perf report --group", it shows the event group information together. By default, the output is sorted by the first event in group. It would be nice for user to select any event for sorting.
The patch 1/3 introduces a new option "--group-sort-idx" to sort the output by the event at the index n in event group.
Quoted 6 lines
Quoted 4 lines
The patch 2/3 creates a new key
K_RELOADto reload the browser.The patch 3/3 supports hotkeys in browser to select a event to sort.
Thanks, applied.
Doesn't work with 'perf top', should, investigating,
- Arnaldo
Quoted 29 lines
- Arnaldo
Quoted 23 lines
v7:
---
v6 was posted two months ago and all comments were fixed.v7 just rebases to perf/core, no other change.
Jin Yao (3):
perf report: Change sort order by a specified event in group perf report: Support a new key to reload the browser
perf report: support hotkey to let user select any event for sortingtools/perf/Documentation/perf-report.txt | 5 ++ tools/perf/builtin-report.c | 16 +++- tools/perf/ui/browsers/hists.c | 29 ++++++- tools/perf/ui/hist.c | 104 +++++++++++++++++++---- tools/perf/ui/keysyms.h | 1 + tools/perf/util/hist.h | 1 + tools/perf/util/symbol_conf.h | 1 + 7 files changed, 138 insertions(+), 19 deletions(-)Signature · 1 line
2.17.1Signature · 1 line
- Arnaldo
Signature · 1 line
- Arnaldo
Em Wed, Mar 18, 2020 at 04:03:25PM -0300, Arnaldo Carvalho de Melo escreveu:
Quoted 9 lines
Em Wed, Mar 18, 2020 at 04:01:16PM -0300, Arnaldo Carvalho de Melo escreveu:
Quoted 8 lines
Em Thu, Feb 20, 2020 at 09:36:13AM +0800, Jin Yao escreveu:
Quoted 7 lines
When performing "perf report --group", it shows the event group information together. By default, the output is sorted by the first event in group. It would be nice for user to select any event for sorting.
The patch 1/3 introduces a new option "--group-sort-idx" to sort the output by the event at the index n in event group.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
The patch 2/3 creates a new key
K_RELOADto reload the browser.The patch 3/3 supports hotkeys in browser to select a event to sort.
Thanks, applied.
Doesn't work with 'perf top', should, investigating,
So needs a bit of work, but is doable and would be a great addition, since we do support:
# perf top --group -e instructions,cycles,cache-misses
And we should strive to make 'perf top' to be a perf.data-less, dynamic version of 'perf record + perf report'.
Can you please take a look at supporting this? And that --group-sort-idx too,
I'll push my perf/core branch after a few tests,
Thanks,
- Arnaldo
Quoted 27 lines · Arnaldo Carvalho de Melo
Em Wed, Mar 18, 2020 at 04:03:25PM -0300, Arnaldo Carvalho de Melo escreveu:
Quoted 9 lines
Em Wed, Mar 18, 2020 at 04:01:16PM -0300, Arnaldo Carvalho de Melo escreveu:
Quoted 8 lines
Em Thu, Feb 20, 2020 at 09:36:13AM +0800, Jin Yao escreveu:
Quoted 7 lines
When performing "perf report --group", it shows the event group information together. By default, the output is sorted by the first event in group. It would be nice for user to select any event for sorting.
The patch 1/3 introduces a new option "--group-sort-idx" to sort the output by the event at the index n in event group.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
The patch 2/3 creates a new key
K_RELOADto reload the browser.The patch 3/3 supports hotkeys in browser to select a event to sort.
Thanks, applied.
Doesn't work with 'perf top', should, investigating,
So needs a bit of work, but is doable and would be a great addition, since we do support:
# perf top --group -e instructions,cycles,cache-missesAnd we should strive to make 'perf top' to be a perf.data-less, dynamic version of 'perf record + perf report'.
Quoted 9 lines
Can you please take a look at supporting this? And that --group-sort-idx too,
I'll push my perf/core branch after a few tests,
Thanks,
- Arnaldo
I will check that.
Thanks
Jin Yao