ext3: fix build warning if !quota

PATCH Applied Jerome Pinot 2 participants 4 messages Oct 1, 2005 – Oct 2, 2005 Kernel janitors

Share & tools

Jerome Pinot

author

2005-10-01 15:42 UTC #0 lore raw

PATCH 1/1 ext3: fix build warning if !quota

Hi,
Posted this on lkml and to Andrew Morton for -rc2 but doesn't get it fixed :-(
Hope a better welcome here for a so trivial fix:
sbi is not used if quota is not defined. This leads to a uselessvariable after preprocessing and a build warning. Thanks to apply.

Signed-off-by Jerome Pinot <[email protected]>

------8<------diff -Naur a/fs/ext3/super.c b/fs/ext3/super.c--- a/fs/ext3/super.c 2005-09-29 00:28:16.000000000 +0000+++ b/fs/ext3/super.c 2005-09-29 02:18:22.000000000 +0000@@ -513,7 +513,9 @@ static int ext3_show_options(struct seq_file *seq, struct vfsmount *vfs) { struct super_block *sb = vfs->mnt_sb;+#if defined(CONFIG_QUOTA) struct ext3_sb_info *sbi = EXT3_SB(sb);+#endif
if (test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_JOURNAL_DATA) seq_puts(seq, ",data=journal"); ------8<------
Regards,
--Jerome Pinothttp://ngc891.blogdns.net/

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Jerome Pinot

author

2005-10-01 16:20 UTC #1 lore raw

Quoted 1 line

There is a problem with your mailer setup, if you can't manage to> include the patch inline, please attach it (it is considered bad, but> at least your patch can be applied).

I really think I'm doomed with this one.
Here is the patch (sorry for the list)
------8<------diff -Naur a/fs/ext3/super.c b/fs/ext3/super.c--- a/fs/ext3/super.c 2005-09-29 00:28:16.000000000 +0000+++ b/fs/ext3/super.c 2005-09-29 02:18:22.000000000 +0000@@ -513,7 +513,9 @@ static int ext3_show_options(struct seq_file *seq, struct vfsmount *vfs) { struct super_block *sb = vfs->mnt_sb;+#if defined(CONFIG_QUOTA) struct ext3_sb_info *sbi = EXT3_SB(sb);+#endif
if (test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_JOURNAL_DATA) seq_puts(seq, ",data=journal");------8<------
You can get it too from here:http://lkml.org/lkml/diff/2005/9/28/341/1 I'll work on my patch submission process...
Thanks
--Jerome Pinothttp://ngc891.blogdns.net/

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Alexey Dobriyan

2005-10-01 16:36 UTC #2 lore raw

In reply to Jerome Pinot

Quoted 1 line · Jerome Pinot

Posted this on lkml and to Andrew Morton for -rc2 but doesn't get it fixed :-(

Uhh... Who stripped almost all newlines from the patch?

Quoted 1 line

Hope a better welcome here for a so trivial fix:

Sure. For MUA testing send a patch to youself, the apply it.

Quoted 5 lines

sbi is not used if quota is not defined. This leads to a uselessvariable after preprocessing and a build warning. Thanks to apply.
Signed-off-by Jerome Pinot <[email protected]>
------8<------diff -Naur a/fs/ext3/super.c b/fs/ext3/super.c--- a/fs/ext3/super.c 2005-09-29 00:28:16.000000000 +0000+++ b/fs/ext3/super.c 2005-09-29 02:18:22.000000000 +0000@@ -513,7 +513,9 @@ static int ext3_show_options(struct seq_file *seq, struct vfsmount *vfs) { struct super_block *sb = vfs->mnt_sb;+#if defined(CONFIG_QUOTA) struct ext3_sb_info *sbi = EXT3_SB(sb);+#endif
if (test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_JOURNAL_DATA) seq_puts(seq, ",data=journal"); ------8<------

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Alexey Dobriyan

Applied

2005-10-02 11:40 UTC #3 lore raw

In reply to Jerome Pinot

Quoted 1 line · Jerome Pinot

You can get it too from here:http://lkml.org/lkml/diff/2005/9/28/341/1

Applied. Awaiting you Signed-off-by line.

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors