Skip to contentSkip to conversation

arm64: tegra: correct Tegra132 I2C alias

PATCH Applied Krzysztof Kozlowski 3 participants 3 messages Apr 1, 2024 – Apr 26, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: tegra: correct Tegra132 I2C alias

There is no such device as "as3722@40", because its name is "pmic". Use phandles for aliases to fix relying on full node path. This corrects aliases for RTC devices and also fixes dtc W=1 warning:

tegra132-norrin.dts:12.3-36: Warning (alias_paths): /aliases:rtc0: aliases property is not a valid node (/i2c@7000d000/as3722@40)

Fixes 0f279ebdf3ce ("arm64: tegra: Add NVIDIA Tegra132 Norrin support")
---
 arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 4 ++--
 arch/arm64/boot/dts/nvidia/tegra132.dtsi       | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/nvidia/tegra132-norrin.dts +2 -2
index 14d58859bb55..683ac124523b 100644
@@ -9,8 +9,8 @@ / {
 	compatible = "nvidia,norrin", "nvidia,tegra132", "nvidia,tegra124";
 
 	aliases {
-		rtc0 = "/i2c@7000d000/as3722@40";
-		rtc1 = "/rtc@7000e000";
+		rtc0 = &as3722;
+		rtc1 = &tegra_rtc;
 		serial0 = &uarta;
 	};
 
arch/arm64/boot/dts/nvidia/tegra132.dtsi +1 -1
index 7e24a212c7e4..5bcccfef3f7f 100644
@@ -572,7 +572,7 @@ spi@7000de00 {
 		status = "disabled";
 	};
 
-	rtc@7000e000 {
+	tegra_rtc: rtc@7000e000 {
 		compatible = "nvidia,tegra124-rtc", "nvidia,tegra20-rtc";
 		reg = <0x0 0x7000e000 0x0 0x100>;
 		interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 34 lines · Krzysztof Kozlowski

There is no such device as "as3722@40", because its name is "pmic". Use phandles for aliases to fix relying on full node path. This corrects aliases for RTC devices and also fixes dtc W=1 warning:

tegra132-norrin.dts:12.3-36: Warning (alias_paths): /aliases:rtc0: aliases property is not a valid node (/i2c@7000d000/as3722@40)

Fixes 0f279ebdf3ce ("arm64: tegra: Add NVIDIA Tegra132 Norrin support")
---
  arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 4 ++--
  arch/arm64/boot/dts/nvidia/tegra132.dtsi       | 2 +-
  2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/nvidia/tegra132-norrin.dts +2 -2
index 14d58859bb55..683ac124523b 100644
@@ -9,8 +9,8 @@ / {
  	compatible = "nvidia,norrin", "nvidia,tegra132", "nvidia,tegra124";
 
  	aliases {
-		rtc0 = "/i2c@7000d000/as3722@40";
-		rtc1 = "/rtc@7000e000";
+		rtc0 = &as3722;
+		rtc1 = &tegra_rtc;
  		serial0 = &uarta;
  	};
 
arch/arm64/boot/dts/nvidia/tegra132.dtsi +0 -0
index 7e24a212c7e4..5bcccfef3f7f 100644

arch/arm64/boot/dts/nvidia/tegra132.dtsi spi@7000de00 { · line 578

Quoted 8 lines
arch/arm64/boot/dts/nvidia/tegra132.dtsi +1 -1
@@ -572,7 +572,7 @@ spi@7000de00 {
  		status = "disabled";
  	};
 
-	rtc@7000e000 {
+	tegra_rtc: rtc@7000e000 {
  		compatible = "nvidia,tegra124-rtc", "nvidia,tegra20-rtc";
  		reg = <0x0 0x7000e000 0x0 0x100>;
  		interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;

Thanks!
Jon

Signature · 1 line
nvpublic
#2 lore raw
In reply to Krzysztof Kozlowski

From: Thierry Reding <[email protected]>

Quoted 8 lines · Krzysztof Kozlowski

There is no such device as "as3722@40", because its name is "pmic". Use phandles for aliases to fix relying on full node path. This corrects aliases for RTC devices and also fixes dtc W=1 warning:

tegra132-norrin.dts:12.3-36: Warning (alias_paths): /aliases:rtc0: aliases property is not a valid node (/i2c@7000d000/as3722@40)

[...]

Applied, thanks!

[1/1] arm64: tegra: correct Tegra132 I2C alias
(no commit info)

Best regards,

Signature · 1 line
Thierry Reding <[email protected]>