Skip to contentSkip to conversation

2.4.2-ac calls FS truncate w/o BKL

DISCUSSION Chris Mason 2 participants 2 messages Mar 9, 2001

lore
Share & tools
lore
#0 lore raw

The added vmtruncate calls in the ac series trigger calls to the FS truncate without the BKL held. Easy enough to fix on the reiserfs side, but if other filesystems care we might want to change vmtruncate to grab the lock before calling truncate (and update the Locking doc ;-)

-chris

#1 lore raw
Quoted 5 lines · Chris Mason

The added vmtruncate calls in the ac series trigger calls to the FS truncate without the BKL held. Easy enough to fix on the reiserfs side, but if other filesystems care we might want to change vmtruncate to grab the lock before calling truncate (and update the Locking doc ;-)

Grr... Thanks for spotting - it's my fault. No, I don't think that we should move BKL into filesystems right now. Should move it into vmtruncate(), though...

Alan, could you put lock_kernel()/unlock_kernel() around the call of ->truncate() in vmtruncate()?
Thanks,
Al