Skip to contentSkip to conversation

drivers: char: mem: Make /dev/mem an optional device

PATCH In review Rob Ward 2 participants 3 messages Dec 3, 2014 Char and misc drivers

lore
Share & tools
lore

Rob Ward

author
#0 lore raw

PATCH 1/1 drivers: char: mem: Make /dev/mem an optional device

Quoted 1 line

From ecd3ac31f6be2372d2beac0cc4831e74aeae75d2 Mon Sep 17 00:00:00 2001

From: Rob Ward <[email protected]>
Date: Wed, 5 Nov 2014 19:13:53 +0000
Subject: [PATCH] drivers: char: mem: Make /dev/mem an optional device

Adds Kconfig option CONFIG_DEVMEM that allows the
/dev/mem device to be disabled.

Option defaults to /dev/mem enabled.

---
 drivers/char/Kconfig |  9 +++++++++
 drivers/char/mem.c   | 19 ++++++++++++++++++-
 2 files changed, 27 insertions(+), 1 deletion(-)
drivers/char/Kconfig +9 -0
index efefd12..a4af822 100644
@@ -6,6 +6,15 @@ menu "Character devices"
 
 source "drivers/tty/Kconfig"
 
+config DEVMEM
+	bool "/dev/mem virtual device support"
+	default y
+	help
+	  Say Y here if you want to support the /dev/mem device.
+	  The /dev/mem device is used to access areas of physical
+	  memory.
+	  When in doubt, say "Y".
+
 config DEVKMEM
 	bool "/dev/kmem virtual device support"
 	default y
drivers/char/mem.c +18 -1
index 524b707..feadc87 100644
@@ -92,6 +92,7 @@ void __weak unxlate_dev_mem_ptr(unsigned long phys, void *addr)
  * This funcion reads the *physical* memory. The f_pos points directly to the
  * memory location.
  */
+#ifdef CONFIG_DEVMEM
 static ssize_t read_mem(struct file *file, char __user *buf,
 			size_t count, loff_t *ppos)
 {
@@ -216,6 +217,7 @@ static ssize_t write_mem(struct file *file, const char __user *buf,
 	*ppos += written;
 	return written;
 }
+#endif
 
 int __weak phys_mem_access_prot_allowed(struct file *file,
 	unsigned long pfn, unsigned long size, pgprot_t *vma_prot)
@@ -273,6 +275,7 @@ static pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn,
 #endif
 
 #ifndef CONFIG_MMU
+#if defined CONFIG_DEVMEM || defined CONFIG_DEVKMEM
 static unsigned long get_unmapped_area_mem(struct file *file,
 					   unsigned long addr,
 					   unsigned long len,
@@ -283,14 +286,16 @@ static unsigned long get_unmapped_area_mem(struct file *file,
 		return (unsigned long) -EINVAL;
 	return pgoff << PAGE_SHIFT;
 }
-
+#endif
 /* can't do an in-place private mapping if there's no MMU */
 static inline int private_mapping_ok(struct vm_area_struct *vma)
 {
 	return vma->vm_flags & VM_MAYSHARE;
 }
 #else
+#if defined CONFIG_DEVMEM || defined CONFIG_DEVKMEM
 #define get_unmapped_area_mem	NULL
+#endif
 
 static inline int private_mapping_ok(struct vm_area_struct *vma)
 {
@@ -298,6 +303,7 @@ static inline int private_mapping_ok(struct vm_area_struct *vma)
 }
 #endif
 
+#if defined CONFIG_DEVMEM || defined CONFIG_DEVKMEM
 static const struct vm_operations_struct mmap_mem_ops = {
 #ifdef CONFIG_HAVE_IOREMAP_PROT
 	.access = generic_access_phys
@@ -337,6 +343,7 @@ static int mmap_mem(struct file *file, struct vm_area_struct *vma)
 	}
 	return 0;
 }
+#endif
 
 #ifdef CONFIG_DEVKMEM
 static int mmap_kmem(struct file *file, struct vm_area_struct *vma)
@@ -675,6 +682,7 @@ static loff_t null_lseek(struct file *file, loff_t offset, int orig)
  * also note that seeking relative to the "end of file" isn't supported:
  * it has no meaning, so it returns -EINVAL.
  */
+#if defined CONFIG_DEVMEM  || defined CONFIG_DEVKMEM || defined CONFIG_DEVPORT
 static loff_t memory_lseek(struct file *file, loff_t offset, int orig)
 {
 	loff_t ret;
@@ -704,14 +712,20 @@ static int open_port(struct inode *inode, struct file *filp)
 {
 	return capable(CAP_SYS_RAWIO) ? 0 : -EPERM;
 }
+#endif
 
 #define zero_lseek	null_lseek
 #define full_lseek      null_lseek
 #define write_zero	write_null
 #define aio_write_zero	aio_write_null
+#if defined CONFIG_DEVMEM || defined CONFIG_DEVKMEM
 #define open_mem	open_port
+#endif
+#ifdef CONFIG_DEVKMEM
 #define open_kmem	open_mem
+#endif
 
+#ifdef CONFIG_DEVMEM
 static const struct file_operations mem_fops = {
 	.llseek		= memory_lseek,
 	.read		= read_mem,
@@ -720,6 +734,7 @@ static const struct file_operations mem_fops = {
 	.open		= open_mem,
 	.get_unmapped_area = get_unmapped_area_mem,
 };
+#endif
 
 #ifdef CONFIG_DEVKMEM
 static const struct file_operations kmem_fops = {
@@ -782,7 +797,9 @@ static const struct memdev {
 	const struct file_operations *fops;
 	struct backing_dev_info *dev_info;
 } devlist[] = {
+#ifdef CONFIG_DEVMEM
 	 [1] = { "mem", 0, &mem_fops, &directly_mappable_cdev_bdi },
+#endif
 #ifdef CONFIG_DEVKMEM
 	 [2] = { "kmem", 0, &kmem_fops, &directly_mappable_cdev_bdi },
 #endif
Signature · 1 line
2.0.2
maintainer
#1 lore raw
Quoted 4 lines · On Wednesday 03 December 2014 08:21:04 Rob Ward wrote:

From ecd3ac31f6be2372d2beac0cc4831e74aeae75d2 Mon Sep 17 00:00:00 2001
From: Rob Ward <[email protected]>
Date: Wed, 5 Nov 2014 19:13:53 +0000
Subject: [PATCH] drivers: char: mem: Make /dev/mem an optional device

Please leave out these headers from the email. If you use git-send-email, it will work the right way, but for regular email clients you need to remove them manually.

Quoted 4 lines

Adds Kconfig option CONFIG_DEVMEM that allows the
/dev/mem device to be disabled.

Option defaults to /dev/mem enabled.

Please explain the purpose of this. Are you doing this for security considerations, for space savings, or something else.

If you are worried about security, please explain the possible attack vector you are closing, if you want to save kernel text size, show how much you save. It also helps to show a guess of what might break if you turn it off.

Quoted 11 lines
---
 drivers/char/Kconfig |  9 +++++++++
 drivers/char/mem.c   | 19 ++++++++++++++++++-
 2 files changed, 27 insertions(+), 1 deletion(-)
drivers/char/Kconfig +0 -0
index efefd12..a4af822 100644

drivers/char/Kconfig menu "Character devices" · line 11

Quoted 6 lines
drivers/char/Kconfig +3 -0
@@ -6,6 +6,15 @@ menu "Character devices"
 
 source "drivers/tty/Kconfig"
 
+config DEVMEM
+	bool "/dev/mem virtual device support"
+	default y

Should this be

bool "/dev/mem virtual device support" if EXPERT

so normal users don't accidentally disable it?

Quoted 13 lines
drivers/char/mem.c +1 -0
index 524b707..feadc87 100644
@@ -92,6 +92,7 @@ void __weak unxlate_dev_mem_ptr(unsigned long phys, void *addr)
  * This funcion reads the *physical* memory. The f_pos points directly to the
  * memory location.
  */
+#ifdef CONFIG_DEVMEM
 static ssize_t read_mem(struct file *file, char __user *buf,
 			size_t count, loff_t *ppos)
 {

drivers/char/mem.c static ssize_t write_mem(struct file *file, const char __user *buf, · line 220

Quoted 4 lines
drivers/char/mem.c +1 -0
@@ -216,6 +217,7 @@ static ssize_t write_mem(struct file *file, const char __user *buf,
 	*ppos += written;
 	return written;
 }
+#endif

Adding a lot of #ifdef isn't nice, there are better ways to achieve the same.

drivers/char/mem.c static const struct file_operations mem_fops = { · line 737

Quoted 9 lines
drivers/char/mem.c +2 -0
+#ifdef CONFIG_DEVMEM
 static const struct file_operations mem_fops = {
 	.llseek		= memory_lseek,
 	.read		= read_mem,
@@ -720,6 +734,7 @@ static const struct file_operations mem_fops = {
 	.open		= open_mem,
 	.get_unmapped_area = get_unmapped_area_mem,
 };
+#endif

I would probably do it here an leave the mem_fops visible to the compiler but mark it as '__maybe_unused' to avoid the warning when the reference below is not there.

drivers/char/mem.c static const struct memdev { · line 805

Quoted 12 lines
drivers/char/mem.c +2 -0
 #ifdef CONFIG_DEVKMEM
 static const struct file_operations kmem_fops = {
@@ -782,7 +797,9 @@ static const struct memdev {
 	const struct file_operations *fops;
 	struct backing_dev_info *dev_info;
 } devlist[] = {
+#ifdef CONFIG_DEVMEM
 	 [1] = { "mem", 0, &mem_fops, &directly_mappable_cdev_bdi },
+#endif
 #ifdef CONFIG_DEVKMEM
 	 [2] = { "kmem", 0, &kmem_fops, &directly_mappable_cdev_bdi },
 #endif

To keep it in sync with kmem, I would then submit a cleanup patch to do the same for kmem_fops and replace the other #ifdef lines with __maybe_unused statement for kmem_fops.

Arnd

author
#2 lore raw

Hi,

Quoted 9 lines · Arnd Bergmann
Quoted 4 lines · On Wednesday 03 December 2014 08:21:04 Rob Ward wrote:

From ecd3ac31f6be2372d2beac0cc4831e74aeae75d2 Mon Sep 17 00:00:00 2001
From: Rob Ward <[email protected]>
Date: Wed, 5 Nov 2014 19:13:53 +0000
Subject: [PATCH] drivers: char: mem: Make /dev/mem an optional device

Please leave out these headers from the email. If you use git-send-email, it will work the right way, but for regular email clients you need to remove them manually.

Apologies, I will remove them in the future, I really should get send-email setup :-)

Quoted 9 lines
Quoted 5 lines

Adds Kconfig option CONFIG_DEVMEM that allows the
/dev/mem device to be disabled.

Option defaults to /dev/mem enabled.

Please explain the purpose of this. Are you doing this for security considerations, for space savings, or something else.

For the most part as a security consideration but a ever so slightly smaller kernel may be a nice side effect.

Quoted 4 lines

If you are worried about security, please explain the possible attack vector you are closing, if you want to save kernel text size, show how much you save. It also helps to show a guess of what might break if you turn it off.

The aim is to reduce the potential methods of attack, having access to areas of memory via a device makes reading potentially important data from RAM very easy, this change doesn't stop this but does make it harder than opening a file.

Additionally many platforms(MIPS as an example) do not restict the area of RAM that can be accessed at all. /dev/mem works out which areas of memory can be read using the range_is_allowed() function in drivers/char/mem.c which in turn determines what can be read based on the config option CONFIG_STRICT_DEVMEM which if enabled calls devmem_is_allowed implemented per platform.

devmem_is_allowed is not implemented on several platforms and the default is to allow access to any location.

x86 and others do have restrictions implemented, usually based on areas that bios places data etc.

On "secure" and embedded systems access to /dev/mem is not usually needed and so disabling it is a desirable feature and prevents the need to implement custom restrictions.

Quoted 21 lines
Quoted 12 lines
---
 drivers/char/Kconfig |  9 +++++++++
 drivers/char/mem.c   | 19 ++++++++++++++++++-
 2 files changed, 27 insertions(+), 1 deletion(-)
drivers/char/Kconfig +0 -0
index efefd12..a4af822 100644

drivers/char/Kconfig menu "Character devices" · line 11

Quoted 6 lines
drivers/char/Kconfig +3 -0
@@ -6,6 +6,15 @@ menu "Character devices"
 
 source "drivers/tty/Kconfig"
 
+config DEVMEM
+	bool "/dev/mem virtual device support"
+	default y

Should this be

Quoted 3 lines

bool "/dev/mem virtual device support" if EXPERT

so normal users don't accidentally disable it?

It would be nice to keep this in sync with DEVKMEM as well, would a follow up change to implement this for kmem to keep in sync be acceptable?

Quoted 22 lines
Quoted 14 lines
drivers/char/mem.c +1 -0
index 524b707..feadc87 100644
@@ -92,6 +92,7 @@ void __weak unxlate_dev_mem_ptr(unsigned long phys, void *addr)
  * This funcion reads the *physical* memory. The f_pos points directly to the
  * memory location.
  */
+#ifdef CONFIG_DEVMEM
 static ssize_t read_mem(struct file *file, char __user *buf,
 			size_t count, loff_t *ppos)
 {

drivers/char/mem.c static ssize_t write_mem(struct file *file, const char __user *buf, · line 220

Quoted 4 lines
drivers/char/mem.c +1 -0
@@ -216,6 +217,7 @@ static ssize_t write_mem(struct file *file, const char __user *buf,
 	*ppos += written;
 	return written;
 }
+#endif

Adding a lot of #ifdef isn't nice, there are better ways to achieve the same.

Quoted 14 lines

drivers/char/mem.c static const struct file_operations mem_fops = { · line 737

Quoted 9 lines
drivers/char/mem.c +2 -0
+#ifdef CONFIG_DEVMEM
 static const struct file_operations mem_fops = {
 	.llseek		= memory_lseek,
 	.read		= read_mem,
@@ -720,6 +734,7 @@ static const struct file_operations mem_fops = {
 	.open		= open_mem,
 	.get_unmapped_area = get_unmapped_area_mem,
 };
+#endif

I would probably do it here an leave the mem_fops visible to the compiler but mark it as '__maybe_unused' to avoid the warning when the reference below is not there.

I will modify to implement this way.

Quoted 8 lines
Quoted 8 lines
drivers/char/mem.c +1 -0
 #ifdef CONFIG_DEVKMEM
 static const struct file_operations kmem_fops = {
@@ -782,7 +797,9 @@ static const struct memdev {
 	const struct file_operations *fops;
 	struct backing_dev_info *dev_info;
 } devlist[] = {
+#ifdef CONFIG_DEVMEM
 	 [1] = { "mem", 0, &mem_fops, &directly_mappable_cdev_bdi },
Quoted 9 lines

drivers/char/mem.c static const struct memdev { · line 805

Quoted 4 lines
drivers/char/mem.c +1 -0
+#endif
 #ifdef CONFIG_DEVKMEM
 	 [2] = { "kmem", 0, &kmem_fops, &directly_mappable_cdev_bdi },
 #endif

To keep it in sync with kmem, I would then submit a cleanup patch to do the same for kmem_fops and replace the other #ifdef lines with __maybe_unused statement for kmem_fops.

Will do

Quoted 2 lines

Arnd

Cheers,

Rob Ward