Reclassify messages from GuC loader/submission
Subsystems (3)
v4 cover Reclassify messages from GuC loader/submission
Various downgrading, upgrading, or general reorganisation of the messages emitted by the GuC code. As general principles:
* "can't happen" cases (inconsistencies/misconfiguration) are ERRORs
* recoverable (ignored) errors are downgraded to WARNINGs
* important auxiliary messages about failure or mode change are NOTICEs
* anything else (messages for developer rather than sysadmin) is DEBUG
v4:
Resend with added cover letter
Dave Gordon (4):
drm: extra printk() wrapper macros
drm/i915/guc: downgrade some DRM_ERROR() messages to DRM_WARN() drm/i915/guc: revisit GuC loader message levels drm/i915/guc: next version of GuC firmware is 8.11
drivers/gpu/drm/i915/i915_guc_submission.c | 18 ++++++-------- drivers/gpu/drm/i915/i915_params.c | 4 ++-- drivers/gpu/drm/i915/intel_guc_loader.c | 38 +++++++++++++++--------------- include/drm/drmP.h | 26 +++++++++++++++----- 4 files changed, 48 insertions(+), 38 deletions(-)
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 1/4 drm: extra printk() wrapper macros
We had only DRM_INFO() and DRM_ERROR(), whereas the underlying printk() provides several other useful intermediate levels such as NOTICE and WARNING. So this patch fills out the set by providing both regular and once-only macros for each of the levels INFO, NOTICE, and WARNING, using a common underlying macro that does all the token-pasting.
DRM_ERROR is unchanged, as it's not just a printk wrapper.
v2:
Fix whitespace, missing ## (Eric Engestrom)
--- include/drm/drmP.h | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-)
include/drm/drmP.h +20 -6
@@ -163,6 +163,26 @@ void drm_err(const char *format, ...);/** \name Macros to make printk easier */ /*@{*/ +#define _DRM_PRINTK (once, level, fmt, ...) \ + do { \ + printk##once(KERN_##level "[" DRM_NAME "] " fmt, \ + ##__VA_ARGS__); \ + } while (0) + +#define DRM_INFO (fmt, ...) \ + _DRM_PRINTK(, INFO, fmt, ##__VA_ARGS__) +#define DRM_NOTE (fmt, ...) \ + _DRM_PRINTK(, NOTICE, fmt, ##__VA_ARGS__) +#define DRM_WARN (fmt, ...) \ + _DRM_PRINTK(, WARNING, fmt, ##__VA_ARGS__) + +#define DRM_INFO_ONCE (fmt, ...) \ + _DRM_PRINTK(_once, INFO, fmt, ##__VA_ARGS__) +#define DRM_NOTE_ONCE (fmt, ...) \ + _DRM_PRINTK(_once, NOTICE, fmt, ##__VA_ARGS__) +#define DRM_WARN_ONCE (fmt, ...) \ + _DRM_PRINTK(_once, WARNING, fmt, ##__VA_ARGS__) +/** * Error output. *
@@ -188,12 +208,6 @@ void drm_err(const char *format, ...); drm_err(fmt, ##__VA_ARGS__); \ }) -#define DRM_INFO (fmt, ...) \ - printk(KERN_INFO "[" DRM_NAME "] " fmt, ##__VA_ARGS__) - -#define DRM_INFO_ONCE (fmt, ...) \ - printk_once(KERN_INFO "[" DRM_NAME "] " fmt, ##__VA_ARGS__) -/** * Debug output. *
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 2/4 drm/i915/guc: downgrade some DRM_ERROR() messages to DRM_WARN()
In reply to Dave GordonWhere we're going to continue regardless of the problem, rather than fail, then the message should be a WARNing rather than an ERROR.
--- drivers/gpu/drm/i915/i915_guc_submission.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/i915_guc_submission.c +7 -11
@@ -114,10 +114,8 @@ static int host2guc_action(struct intel_guc *guc, u32 *data, u32 len)if (ret != -ETIMEDOUT ) ret = -EIO ; -DRM_ERROR ("GUC: host2guc action 0x%X failed. ret=%d " -"status=0x%08X response=0x%08X\n" , - data[0 ], ret, status, -I915_READ (SOFT_SCRATCH (15 ))); +DRM_WARN ("Action 0x%X failed; ret=%d status=0x%08X response=0x%08X\n" , + data[0 ], ret, status,I915_READ (SOFT_SCRATCH (15 ))); dev_priv->guc.action_fail +=1 ; dev_priv->guc.action_err = ret;
@@ -556,8 +554,8 @@ static int guc_ring_doorbell(struct i915_guc_client *gc)if (db_ret.db_status ==GUC_DOORBELL_DISABLED )break ; -DRM_ERROR ("Cookie mismatch. Expected %d, returned %d\n" , - db_cmp.cookie, db_ret.cookie); +DRM_WARN ("Cookie mismatch. Expected %d, found %d\n" , + db_cmp.cookie, db_ret.cookie);/* update the cookie to newly read cookie from GuC */ db_cmp.cookie = db_ret.cookie;
@@ -745,8 +743,8 @@ static void guc_init_doorbell_hw(struct intel_guc *guc)/* Restore to original value */ err =guc_update_doorbell_id (guc, client, db_id);if (err) -DRM_ERROR ("Failed to restore doorbell to %d, err %d\n" , - db_id, err); +DRM_WARN ("Failed to restore doorbell to %d, err %d\n" , + db_id, err);/* Read back & verify all doorbell registers */ for (i =0 ; i <GUC_MAX_DOORBELLS ; ++i)
@@ -834,8 +832,6 @@ static void guc_init_doorbell_hw(struct intel_guc *guc)return client; err: -DRM_ERROR ("FAILED to create priority %u GuC client!\n" , priority); -guc_client_free (dev_priv, client);return NULL ; }
@@ -1015,7 +1011,7 @@ int i915_guc_submission_enable(struct drm_i915_private *dev_priv)GUC_CTX_PRIORITY_KMD_NORMAL , dev_priv->kernel_context);if (!client) { -DRM_ERROR ("Failed to create execbuf guc_client\n" ); +DRM_ERROR ("Failed to create normal GuC client!\n" );return -ENOMEM ; }
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 3/4 drm/i915/guc: revisit GuC loader message levels
In reply to Dave GordonSome downgraded from DRM_ERROR() to DRM_WARN() or DRM_NOTE(), a few upgraded from DRM_INFO() to DRM_NOTE() or DRM_WARN(), and one eliminated completely.
v2: different permutation of levels :)
v3: convert a couple of "this shouldn't happen" messages to WARN()
--- drivers/gpu/drm/i915/intel_guc_loader.c | 34 ++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-)
drivers/gpu/drm/i915/intel_guc_loader.c +17 -17
@@ -152,12 +152,14 @@ static u32 get_gttype(struct drm_i915_private *dev_priv)static u32 get_core_family (struct drm_i915_private *dev_priv) { -switch (INTEL_INFO (dev_priv)->gen) { +u32 gen =INTEL_GEN (dev_priv); + +switch (gen) {case 9 :return GFXCORE_FAMILY_GEN9 ;default : -DRM_ERROR ("GUC: unsupported core family\n" ); +WARN (1 ,"GEN%d does not support GuC operation!\n" , gen);return GFXCORE_FAMILY_UNKNOWN ; } }
@@ -447,7 +449,7 @@ int intel_guc_setup(struct drm_device *dev) goto fail; }else if (*fw_path =='\0' ) {/* Device has a GuC but we don't know what f/w to load? */ -DRM_INFO ("No GuC firmware known for this platform\n" ); +WARN (1 ,"No GuC firmware known for this platform!\n" ); err = -ENODEV ; goto fail; }
@@ -485,10 +487,8 @@ int intel_guc_setup(struct drm_device *dev)* that the state and timing are fairly predictable */ err =i915_reset_guc (dev_priv); -if (err) { -DRM_ERROR ("GuC reset failed: %d\n" , err); +if (err) goto fail; - } err =guc_ucode_xfer (dev_priv);if (!err)
@@ -546,15 +546,15 @@ int intel_guc_setup(struct drm_device *dev)else if (err ==0 )DRM_INFO ("GuC firmware load skipped\n" );else if (ret != -EIO ) -DRM_INFO ("GuC firmware load failed: %d\n" , err); +DRM_NOTE ("GuC firmware load failed: %d\n" , err);else -DRM_ERROR ("GuC firmware load failed: %d\n" , err); +DRM_WARN ("GuC firmware load failed: %d\n" , err);if (i915.enable_guc_submission) {if (fw_path ==NULL )DRM_INFO ("GuC submission without firmware not supported\n" );if (ret ==0 ) -DRM_INFO ("Falling back from GuC submission to execlist mode\n" ); +DRM_NOTE ("Falling back from GuC submission to execlist mode\n" );else DRM_ERROR ("GuC init failed: %d\n" , ret); }
@@ -585,7 +585,7 @@ static void guc_fw_fetch(struct drm_device *dev, struct intel_guc_fw *guc_fw)/* Check the size of the blob before examining buffer contents */ if (fw->size <sizeof (struct guc_css_header )) { -DRM_ERROR ("Firmware header is missing\n" ); +DRM_NOTE ("Firmware header is missing\n" ); goto fail; }
@@ -597,7 +597,7 @@ static void guc_fw_fetch(struct drm_device *dev, struct intel_guc_fw *guc_fw) css->key_size_dw - css->exponent_size_dw) * sizeof(u32);if (guc_fw->header_size !=sizeof (struct guc_css_header )) { -DRM_ERROR ("CSS header definition mismatch\n" ); +DRM_NOTE ("CSS header definition mismatch\n" ); goto fail; }
@@ -607,7 +607,7 @@ static void guc_fw_fetch(struct drm_device *dev, struct intel_guc_fw *guc_fw)/* now RSA */ if (css->key_size_dw !=UOS_RSA_SCRATCH_MAX_COUNT ) { -DRM_ERROR ("RSA key size is bad\n" ); +DRM_NOTE ("RSA key size is bad\n" ); goto fail; } guc_fw->rsa_offset = guc_fw->ucode_offset + guc_fw->ucode_size;
@@ -616,14 +616,14 @@ static void guc_fw_fetch(struct drm_device *dev, struct intel_guc_fw *guc_fw)/* At least, it should have header, uCode and RSA. Size of all three. */ size = guc_fw->header_size + guc_fw->ucode_size + guc_fw->rsa_size;if (fw->size < size) { -DRM_ERROR ("Missing firmware components\n" ); +DRM_NOTE ("Missing firmware components\n" ); goto fail; }/* Header and uCode will be loaded to WOPCM. Size of the two. */ size = guc_fw->header_size + guc_fw->ucode_size;if (size >guc_wopcm_size (to_i915 (dev))) { -DRM_ERROR ("Firmware is too large to fit in WOPCM\n" ); +DRM_NOTE ("Firmware is too large to fit in WOPCM\n" ); goto fail; }
@@ -638,7 +638,7 @@ static void guc_fw_fetch(struct drm_device *dev, struct intel_guc_fw *guc_fw)if (guc_fw->guc_fw_major_found != guc_fw->guc_fw_major_wanted || guc_fw->guc_fw_minor_found < guc_fw->guc_fw_minor_wanted) { -DRM_ERROR ("GuC firmware version %d.%d, required %d.%d\n" , +DRM_NOTE ("GuC firmware version %d.%d, required %d.%d\n" , guc_fw->guc_fw_major_found, guc_fw->guc_fw_minor_found, guc_fw->guc_fw_major_wanted, guc_fw->guc_fw_minor_wanted); err = -ENOEXEC ;
@@ -668,10 +668,10 @@ static void guc_fw_fetch(struct drm_device *dev, struct intel_guc_fw *guc_fw)return ; fail: +DRM_WARN ("Failed to fetch valid GuC firmware from %s (error %d)\n" , + guc_fw->guc_fw_path, err);DRM_DEBUG_DRIVER ("GuC fw fetch status FAIL; err %d, fw %p, obj %p\n" , err, fw, guc_fw->guc_fw_obj); -DRM_ERROR ("Failed to fetch GuC firmware from %s (error %d)\n" , - guc_fw->guc_fw_path, err);mutex_lock (&dev->struct_mutex); obj = guc_fw->guc_fw_obj;
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 4/4 NOMERGE: next version of GuC firmware is 8.11
In reply to Dave GordonUpdate GuC firmware version to 8.11, and re-enable GuC loading and submission by default on suitable platforms, since it's Intel's Plan of Record that GuC submission shall be used where available.
--- drivers/gpu/drm/i915/i915_params.c | 4 ++-- drivers/gpu/drm/i915/intel_guc_loader.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_params.c +2 -2
@@ -55,8 +55,8 @@ struct i915_params i915 __read_mostly = { .verbose_state_checks = 1, .nuclear_pageflip = 0, .edp_vswing = 0, - .enable_guc_loading = 0, - .enable_guc_submission = 0, + .enable_guc_loading = -1, + .enable_guc_submission = -1, .guc_log_level = -1, .enable_dp_mst = true, .inject_load_failure = 0,
drivers/gpu/drm/i915/intel_guc_loader.c +2 -2
@@ -59,8 +59,8 @@* */ -#define SKL_FW_MAJOR 6 -#define SKL_FW_MINOR 1 +#define SKL_FW_MAJOR 8 +#define SKL_FW_MINOR 11#define BXT_FW_MAJOR 8#define BXT_FW_MINOR 7
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Ro.CI.BAT: failure for Reclassify messages from GuC loader/submission (rev3)
In reply to Dave Gordon== Series Details ==
== Series Details ==
Series: Reclassify messages from GuC loader/submission (rev3)
URL : https://patchwork.freedesktop.org/series/10918/
State : failure
== Summary ==
Series 10918v3 Reclassify messages from GuC loader/submission
http://patchwork.freedesktop.org/api/1.0/series/10918/revisions/3/mbox
Test gem_exec_suspend:
Subgroup basic-s3:
dmesg-warn -> PASS (ro-bdw-i7-5600u)
Test kms_cursor_legacy:
Subgroup basic-cursor-vs-flip-varying-size:
pass -> FAIL (ro-ilk1-i5-650)
Subgroup basic-flip-vs-cursor-legacy:
fail -> PASS (ro-bdw-i5-5250u)
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-b-frame-sequence:
fail -> PASS (ro-ivb2-i7-3770)
Subgroup suspend-read-crc-pipe-a:
dmesg-warn -> SKIP (ro-bdw-i5-5250u)
Subgroup suspend-read-crc-pipe-b:
skip -> DMESG-WARN (ro-bdw-i5-5250u)
Subgroup suspend-read-crc-pipe-c:
skip -> DMESG-WARN (ro-bdw-i5-5250u)ro-bdw-i5-5250u total:240 pass:219 dwarn:3 dfail:0 fail:1 skip:17 ro-bdw-i7-5557U total:240 pass:220 dwarn:1 dfail:0 fail:0 skip:19 ro-bdw-i7-5600u total:240 pass:207 dwarn:0 dfail:0 fail:1 skip:32 ro-bsw-n3050 total:240 pass:194 dwarn:0 dfail:0 fail:4 skip:42 ro-byt-n2820 total:240 pass:197 dwarn:0 dfail:0 fail:3 skip:40 ro-hsw-i3-4010u total:240 pass:214 dwarn:0 dfail:0 fail:0 skip:26 ro-hsw-i7-4770r total:240 pass:185 dwarn:0 dfail:0 fail:0 skip:55 ro-ilk1-i5-650 total:235 pass:173 dwarn:0 dfail:0 fail:2 skip:60 ro-ivb-i7-3770 total:240 pass:205 dwarn:0 dfail:0 fail:0 skip:35 ro-ivb2-i7-3770 total:240 pass:209 dwarn:0 dfail:0 fail:0 skip:31 ro-skl3-i5-6260u total:240 pass:222 dwarn:0 dfail:0 fail:4 skip:14
Results at /archive/results/CI_IGT_test/RO_Patchwork_1841/
4a26251 drm-intel-nightly: 2016y-08m-11d-16h-12m-42s UTC integration manifest 773b608 NOMERGE: next version of GuC firmware is 8.11
e3208ac drm/i915/guc: revisit GuC loader message levels
3dc113a drm/i915/guc: downgrade some DRM_ERROR() messages to DRM_WARN() 6cd71c4 drm: extra printk() wrapper macros
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Ro.CI.BAT: failure for Reclassify messages from GuC loader/submission (rev3)
Quoted 11 lines · Patchwork
== Series Details ==
Series: Reclassify messages from GuC loader/submission (rev3)
URL : https://patchwork.freedesktop.org/series/10918/
State : failure== Summary ==
Series 10918v3 Reclassify messages from GuC loader/submission
http://patchwork.freedesktop.org/api/1.0/series/10918/revisions/3/mbox
Quoted 6 lines
Test
gem_exec_suspend:Subgroup basic-s3: dmesg-warn -> PASS (ro-bdw-i7-5600u) Test kms_cursor_legacy: Subgroup basic-cursor-vs-flip-varying-size: pass -> FAIL (ro-ilk1-i5-650)
https://bugs.freedesktop.org/show_bug.cgi?id=96701
[ILK/BSW/APL] [BAT] kms_cursor_legacy some subtest fail with WARNING: page flip 1 was delayed, missed 23 frames etc.
Quoted 11 lines
Subgroup basic-flip-vs-cursor-legacy:
fail -> PASS (ro-bdw-i5-5250u)
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-b-frame-sequence:
fail -> PASS (ro-ivb2-i7-3770)
Subgroup suspend-read-crc-pipe-a:
dmesg-warn -> SKIP (ro-bdw-i5-5250u)
Subgroup suspend-read-crc-pipe-b:
skip -> DMESG-WARN (ro-bdw-i5-5250u)
Subgroup suspend-read-crc-pipe-c:
skip -> DMESG-WARN (ro-bdw-i5-5250u)Both of these are
https://bugs.freedesktop.org/show_bug.cgi?id=96614
[BAT BDW] *ERROR* failed to enable link training/failed to start channel equalization
Quoted 12 lines
ro-bdw-i5-5250u total:240 pass:219 dwarn:3 dfail:0 fail:1 skip:17 ro-bdw-i7-5557U total:240 pass:220 dwarn:1 dfail:0 fail:0 skip:19 ro-bdw-i7-5600u total:240 pass:207 dwarn:0 dfail:0 fail:1 skip:32 ro-bsw-n3050 total:240 pass:194 dwarn:0 dfail:0 fail:4 skip:42 ro-byt-n2820 total:240 pass:197 dwarn:0 dfail:0 fail:3 skip:40 ro-hsw-i3-4010u total:240 pass:214 dwarn:0 dfail:0 fail:0 skip:26 ro-hsw-i7-4770r total:240 pass:185 dwarn:0 dfail:0 fail:0 skip:55 ro-ilk1-i5-650 total:235 pass:173 dwarn:0 dfail:0 fail:2 skip:60 ro-ivb-i7-3770 total:240 pass:205 dwarn:0 dfail:0 fail:0 skip:35 ro-ivb2-i7-3770 total:240 pass:209 dwarn:0 dfail:0 fail:0 skip:31 ro-skl3-i5-6260u total:240 pass:222 dwarn:0 dfail:0 fail:4 skip:14
Quoted 7 lines
Results at /archive/results/CI_IGT_test/RO_Patchwork_1841/
4a26251 drm-intel-nightly: 2016y-08m-11d-16h-12m-42s UTC integration manifest 773b608 NOMERGE: next version of GuC firmware is 8.11
e3208ac drm/i915/guc: revisit GuC loader message levels
3dc113a drm/i915/guc: downgrade someDRM_ERROR()messages toDRM_WARN()6cd71c4 drm: extraprintk()wrapper macros
So ready for merging :)
.Dave.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Jani Nikula
maintainerRe: ✗ Ro.CI.BAT: failure for Reclassify messages from GuC loader/submission (rev3)
Quoted 74 lines · Tvrtko Ursulin
Quoted 73 lines · Tvrtko Ursulin
Quoted 72 lines · Dave Gordon
Quoted 11 lines · Patchwork
== Series Details ==
Series: Reclassify messages from GuC loader/submission (rev3)
URL : https://patchwork.freedesktop.org/series/10918/
State : failure== Summary ==
Series 10918v3 Reclassify messages from GuC loader/submission
http://patchwork.freedesktop.org/api/1.0/series/10918/revisions/3/mboxQuoted 6 lines
Test
gem_exec_suspend:Subgroup basic-s3: dmesg-warn -> PASS (ro-bdw-i7-5600u) Test kms_cursor_legacy: Subgroup basic-cursor-vs-flip-varying-size: pass -> FAIL (ro-ilk1-i5-650)https://bugs.freedesktop.org/show_bug.cgi?id=96701
[ILK/BSW/APL] [BAT]kms_cursor_legacysome subtest fail with WARNING:
page flip 1 was delayed, missed 23 frames etc.Quoted 11 lines
Subgroup basic-flip-vs-cursor-legacy: fail -> PASS (ro-bdw-i5-5250u) Test kms_pipe_crc_basic: Subgroup read-crc-pipe-b-frame-sequence: fail -> PASS (ro-ivb2-i7-3770) Subgroup suspend-read-crc-pipe-a: dmesg-warn -> SKIP (ro-bdw-i5-5250u) Subgroup suspend-read-crc-pipe-b: skip -> DMESG-WARN (ro-bdw-i5-5250u) Subgroup suspend-read-crc-pipe-c: skip -> DMESG-WARN (ro-bdw-i5-5250u)Both of these are
https://bugs.freedesktop.org/show_bug.cgi?id=96614
[BAT BDW] *ERROR* failed to enable link training/failed to start channel equalizationQuoted 31 lines
ro-bdw-i5-5250u total:240 pass:219 dwarn:3 dfail:0 fail:1
skip:17
ro-bdw-i7-5557U total:240 pass:220 dwarn:1 dfail:0 fail:0
skip:19
ro-bdw-i7-5600u total:240 pass:207 dwarn:0 dfail:0 fail:1
skip:32
ro-bsw-n3050 total:240 pass:194 dwarn:0 dfail:0 fail:4
skip:42
ro-byt-n2820 total:240 pass:197 dwarn:0 dfail:0 fail:3
skip:40
ro-hsw-i3-4010u total:240 pass:214 dwarn:0 dfail:0 fail:0
skip:26
ro-hsw-i7-4770r total:240 pass:185 dwarn:0 dfail:0 fail:0
skip:55
ro-ilk1-i5-650 total:235 pass:173 dwarn:0 dfail:0 fail:2
skip:60
ro-ivb-i7-3770 total:240 pass:205 dwarn:0 dfail:0 fail:0
skip:35
ro-ivb2-i7-3770 total:240 pass:209 dwarn:0 dfail:0 fail:0
skip:31
ro-skl3-i5-6260u total:240 pass:222 dwarn:0 dfail:0 fail:4
skip:14Results at /archive/results/CI_IGT_test/RO_Patchwork_1841/
4a26251 drm-intel-nightly: 2016y-08m-11d-16h-12m-42s UTC integration manifest
773b608 NOMERGE: next version of GuC firmware is 8.11 e3208ac drm/i915/guc: revisit GuC loader message levels 3dc113a drm/i915/guc: downgrade someDRM_ERROR()messages toDRM_WARN()6cd71c4 drm: extraprintk()wrapper macros
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
So ready for merging :)
Merged to dinq, thanks for patches and review!
I've merged the wrong (old) series. :(
So now those three patches need to be removed from dinq. Am I allowed to just pull back the head and force push? Or push reverts?
No force pushes. Either revert and push the right ones, or, if the diff is reasonable, come up with fixes that have the same end result.
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx