auxdisplay: ht16k33: Make ht16k33_fb_fix and ht16k33_fb_var constant
Subsystems (2)
PATCH 1/1 auxdisplay: ht16k33: Make ht16k33_fb_fix and ht16k33_fb_var constant
The static structures ht16k33_fb_fix and ht16k33_fb_var, of types fb_fix_screeninfo and fb_var_screeninfo respectively, are not used except to be copied into other variables. Hence make both of them constant to prevent unintended modification.
Issue found with
Coccinelle.
--- drivers/auxdisplay/ht16k33.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/auxdisplay/ht16k33.c +2 -2
@@ -74,7 +74,7 @@ struct ht16k33_priv {struct ht16k33_fbdev fbdev; }; -static struct fb_fix_screeninfo ht16k33_fb_fix = { +static const struct fb_fix_screeninfo ht16k33_fb_fix = { .id =DRIVER_NAME , .type =FB_TYPE_PACKED_PIXELS , .visual =FB_VISUAL_MONO10 ,
@@ -85,7 +85,7 @@ static struct fb_fix_screeninfo ht16k33_fb_fix = { .accel = FB_ACCEL_NONE, }; -static struct fb_var_screeninfo ht16k33_fb_var = { +static const struct fb_var_screeninfo ht16k33_fb_var = { .xres =HT16K33_MATRIX_LED_MAX_ROWS , .yres =HT16K33_MATRIX_LED_MAX_COLS , .xres_virtual =HT16K33_MATRIX_LED_MAX_ROWS ,
Signature · 1 line
2.19.1
Quoted 7 lines · Nishka Dasgupta
The static structures
ht16k33_fb_fixandht16k33_fb_var, of typesfb_fix_screeninfoandfb_var_screeninforespectively, are not used except to be copied into other variables. Hence make both of them constant to prevent unintended modification.
Issue found with
Coccinelle.
Thanks Nishka, picking it up.
Cheers,
Miguel
Robin van der Gracht
maintainerQuoted 26 lines · Nishka Dasgupta
The static structures
ht16k33_fb_fixandht16k33_fb_var, of typesfb_fix_screeninfoandfb_var_screeninforespectively, are not used except to be copied into other variables. Hence make both of them constant to prevent unintended modification.
Issue found with
Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>--- drivers/auxdisplay/ht16k33.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/auxdisplay/ht16k33.c +1
-1@@ -74,7 +74,7 @@ struct ht16k33_priv {struct ht16k33_fbdev fbdev; }; -static struct fb_fix_screeninfo ht16k33_fb_fix = { +static const struct fb_fix_screeninfo ht16k33_fb_fix = { .id =DRIVER_NAME , .type =FB_TYPE_PACKED_PIXELS , .visual =FB_VISUAL_MONO10 ,
drivers/auxdisplay/ht16k33.c static struct fb_fix_screeninfo ht16k33_fb_fix = { · line 91
Quoted 8 lines
drivers/auxdisplay/ht16k33.c +1
-1@@ -85,7 +85,7 @@ static struct fb_fix_screeninfo ht16k33_fb_fix = { .accel = FB_ACCEL_NONE, }; -static struct fb_var_screeninfo ht16k33_fb_var = { +static const struct fb_var_screeninfo ht16k33_fb_var = { .xres =HT16K33_MATRIX_LED_MAX_ROWS , .yres =HT16K33_MATRIX_LED_MAX_COLS , .xres_virtual =HT16K33_MATRIX_LED_MAX_ROWS ,
ACK
Robin