Makefile: Remove version from /usr/share/makedumpfile
Subsystems (3)
PATCH 1/1 Makefile: Remove version from /usr/share/makedumpfile
Version specific paths doesn't make sense at /usr/share/makedumpfile. This assumes you will have only one version installed which on a normal system it makes sense and devs can always specify different DESTDIR per versions.
--- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Makefile +3 -3
@@ -130,6 +130,6 @@ install: install -m 755 -t ${DESTDIR}/usr/sbin makedumpfile $(VPATH)makedumpfile-R.pl install -m 644 -t ${DESTDIR}/usr/share/man/man8 makedumpfile.8 install -m 644 -t ${DESTDIR}/usr/share/man/man5 makedumpfile.conf.5 - mkdir -p ${DESTDIR}/usr/share/makedumpfile-${VERSION}/eppic_scripts - install -m 644 -D $(VPATH)makedumpfile.conf ${DESTDIR}/usr/share/makedumpfile-${VERSION}/makedumpfile.conf.sample - install -m 644 -t ${DESTDIR}/usr/share/makedumpfile-${VERSION}/eppic_scripts/ $(VPATH)eppic_scripts/* + mkdir -p ${DESTDIR}/usr/share/makedumpfile/eppic_scripts + install -m 644 -D $(VPATH)makedumpfile.conf ${DESTDIR}/usr/share/makedumpfile/makedumpfile.conf.sample + install -m 644 -t ${DESTDIR}/usr/share/makedumpfile/eppic_scripts/ $(VPATH)eppic_scripts/*
Signature · 7 lines
2.38.1 _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
Quoted 8 lines · Leonidas Spyropoulos
Version specific paths doesn't make sense at
/usr/share/makedumpfile. This assumes you will have only one version installed which on a normal system it makes sense and devs can always specify different DESTDIR per versions.Fixes #10Signed-off-by Leonidas Spyropoulos <[email protected]>
Thanks for the patch.
I agree.
The patch [1] introduced the directory with ${VERSION}, but makedumpfile has backward compatibility and the directory does not have any data that has version restraint, so I don't see any reason. Also I didn't find any discussion in the list archive.
I will merge this a few days later if no objection.
Thanks,
Kazu
[1] https://github.com/makedumpfile/makedumpfile/commit/41e1ccfcd57736047a5c52d8096fbcaa255146ec
Quoted 9 lines
--- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)Makefile +0
-0
Makefile install: · line 135
Quoted 9 lines
Makefile +3
-3@@ -130,6 +130,6 @@ install: install -m 755 -t ${DESTDIR}/usr/sbin makedumpfile $(VPATH)makedumpfile-R.pl install -m 644 -t ${DESTDIR}/usr/share/man/man8 makedumpfile.8 install -m 644 -t ${DESTDIR}/usr/share/man/man5 makedumpfile.conf.5 - mkdir -p ${DESTDIR}/usr/share/makedumpfile-${VERSION}/eppic_scripts - install -m 644 -D $(VPATH)makedumpfile.conf ${DESTDIR}/usr/share/makedumpfile-${VERSION}/makedumpfile.conf.sample - install -m 644 -t ${DESTDIR}/usr/share/makedumpfile-${VERSION}/eppic_scripts/ $(VPATH)eppic_scripts/* + mkdir -p ${DESTDIR}/usr/share/makedumpfile/eppic_scripts + install -m 644 -D $(VPATH)makedumpfile.conf ${DESTDIR}/usr/share/makedumpfile/makedumpfile.conf.sample + install -m 644 -t ${DESTDIR}/usr/share/makedumpfile/eppic_scripts/ $(VPATH)eppic_scripts/*
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
HAGIO KAZUHITO(萩尾 一仁)
AppliedQuoted 12 lines · HAGIO KAZUHITO(萩尾 一仁)
Quoted 8 lines · Leonidas Spyropoulos
Version specific paths doesn't make sense at
/usr/share/makedumpfile. This assumes you will have only one version installed which on a normal system it makes sense and devs can always specify different DESTDIR per versions.Fixes #10Signed-off-by Leonidas Spyropoulos <[email protected]>Thanks for the patch.
Quoted 8 lines
I agree.
The patch [1] introduced the directory with ${VERSION}, but makedumpfile has backward compatibility and the directory does not have any data that has version restraint, so I don't see any reason. Also I didn't find any discussion in the list archive.
I will merge this a few days later if no objection.
Applied.
https://github.com/makedumpfile/makedumpfile/commit/f1d84a5d69d81bc7a89aefae504be88df1e50693
Thanks,
Kazu
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec