Skip to contentSkip to conversation

net: dsa: lantiq_gswip: Exclude RMII from modes that report 1 GbE

PATCH Applied Aleksander Jan Bajkowski 3 participants 3 messages Jan 7, 2021 – Jan 8, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: dsa: lantiq_gswip: Exclude RMII from modes that report 1 GbE

Exclude RMII from modes that report 1 GbE support. Reduced MII supports up to 100 MbE.

Fixes 14fceff ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
---
 drivers/net/dsa/lantiq_gswip.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/net/dsa/lantiq_gswip.c +4 -3
index 4b36d89bec06..662e68a0e7e6 100644
@@ -1436,11 +1436,12 @@ static void gswip_phylink_validate(struct dsa_switch *ds, int port,
 	phylink_set(mask, Pause);
 	phylink_set(mask, Asym_Pause);
 
-	/* With the exclusion of MII and Reverse MII, we support Gigabit,
-	 * including Half duplex
+	/* With the exclusion of MII, Reverse MII and Reduced MII, we
+	 * support Gigabit, including Half duplex
 	 */
 	if (state->interface != PHY_INTERFACE_MODE_MII &&
-	    state->interface != PHY_INTERFACE_MODE_REVMII) {
+	    state->interface != PHY_INTERFACE_MODE_REVMII &&
+	    state->interface != PHY_INTERFACE_MODE_RMII) {
 		phylink_set(mask, 1000baseT_Full);
 		phylink_set(mask, 1000baseT_Half);
 	}
Signature · 1 line
2.20.1
maintainer Applied
#2 lore raw
Quoted 5 lines · On Thu, 7 Jan 2021 12:00:44 -0800 Florian Fainelli wrote:
Quoted 4 lines · Aleksander Jan Bajkowski

Exclude RMII from modes that report 1 GbE support. Reduced MII supports up to 100 MbE.

Fixes 14fceff ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")

Please make sure that the hash is at least 12 chars in the future.

Quoted 3 lines
Quoted 1 line

Applied, thanks!