Skip to contentSkip to conversation

mpc83xx: New board support SIMPC8313

PATCH New Ron Madrid 2 participants 2 messages Nov 10, 2008

lore
Share & tools
lore

Ron Madrid

author
#0 lore raw

PATCH 1/1 mpc83xx: New board support SIMPC8313

Kim,

Thank you for the feedback. I am in the process of implementing the appropriate changes, however I have a couple of questions/ concerns about your review.

Quoted 5 lines

...NAND...Configuring for SIMPC8313 board...
In file included from simpc8313.c:32:
/home/kim/git/u-boot/include/ns16550.h:108:2: error: #error "Please define NS16550 registers size."

I have this line in my board config file:
#define CFG_NS16550_REG_SIZE 1
So I don't know where this error would come from as I did not see it when I performed my builds

Quoted 4 lines
Quoted 1 line

+Ron Madrid <[email protected]>

hmm..I'm not sure if this email address is acceptable.

What are acceptable email addresses if this one in fact is not?

#1 lore raw

PATCH 1/1 mpc83xx: New board support SIMPC8313

Quoted 9 lines · On Mon, 10 Nov 2008 13:45:53 -0800 (PST) Ron Madrid <[email protected]>…
Quoted 4 lines

...NAND...Configuring for SIMPC8313 board...
In file included from simpc8313.c:32:
/home/kim/git/u-boot/include/ns16550.h:108:2: error: #error "Please define NS16550 registers size."

I have this line in my board config file:
#define CFG_NS16550_REG_SIZE 1
So I don't know where this error would come from as I did not see it when I performed my builds

your tree is not up to date as of at least this commit:

commit 6d0f6bcf337c5261c08fabe12982178c2c489d76

Author: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
Date:   Thu Oct 16 15:01:15 2008 +0200

rename CFG_ macros to CONFIG_SYS

which changed what ns16550 is expecting from CFG_NS16550_REG_SIZE to CONFIG_SYS_NS16550_REG_SIZE.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

+Ron Madrid <[email protected]>

hmm..I'm not sure if this email address is acceptable.

What are acceptable email addresses if this one in fact is not?

I would think ones that are more likely to be directly associated with a human being that is familiar with u-boot, e.g.:

Ron Madrid <[email protected]>

:)

Kim