Skip to contentSkip to conversation

efi/tpm: Fix the issue where the CC platforms event log header can't be correctly identified

PATCH In review [email protected] 4 participants 4 messages Jul 12, 2025 – Jul 15, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v6 1/1 efi/tpm: Fix the issue where the CC platforms event log header can't be correctly identified

From: Ge Yang <[email protected]>

Since commit d228814b1913 ("efi/libstub: Add get_event_log() support for CC platforms") reuses TPM2 support code for the CC platforms, when launching a TDX virtual machine with coco measurement enabled, the following error log is generated:

[Firmware Bug]: Failed to parse event in TPM Final Events Log

Call Trace:
efi_config_parse_tables()
  efi_tpm_eventlog_init()
    tpm2_calc_event_log_size()
      __calc_tpm2_event_size()

The pcr_idx value in the Intel TDX log header is 1, causing the function __calc_tpm2_event_size() to fail to recognize the log header, ultimately leading to the "Failed to parse event in TPM Final Events Log" error.

Intel misread the spec and wrongly sets pcrIndex to 1 in the header and since they did this, we fear others might, so we're relaxing the header check. There's no danger of this causing problems because we check for the TCG_SPECID_SIG signature as the next thing.

Fixes d228814b1913 ("efi/libstub: Add get_event_log() support for CC platforms")

---

V6:
- improve commit message suggested by James

V5:
- remove the pcr_index check without adding any replacement checks suggested by James and Sathyanarayanan

V4:
- remove cc_platform_has(CC_ATTR_GUEST_STATE_ENCRYPT) suggested by Ard

V3:
- fix build error

V2:
- limit the fix for CC only suggested by Jarkko and Sathyanarayanan

 include/linux/tpm_eventlog.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
include/linux/tpm_eventlog.h +1 -2
index 891368e..05c0ae5 100644
@@ -202,8 +202,7 @@ static __always_inline u32 __calc_tpm2_event_size(struct tcg_pcr_event2_head *ev
 	event_type = event->event_type;
 
 	/* Verify that it's the log header */
-	if (event_header->pcr_idx != 0 ||
-	    event_header->event_type != NO_ACTION ||
+	if (event_header->event_type != NO_ACTION ||
 	    memcmp(event_header->digest, zero_digest, sizeof(zero_digest))) {
 		size = 0;
 		goto out;
Signature · 1 line
2.7.4
maintainer Reviewed-by on v6 1/1
#1 lore raw
Quoted 20 lines · On Sat, 12 Jul 2025 at 13:41, <[email protected]> wrote:

From: Ge Yang <[email protected]>

Since commit d228814b1913 ("efi/libstub: Add get_event_log() support for CC platforms") reuses TPM2 support code for the CC platforms, when launching a TDX virtual machine with coco measurement enabled, the following error log is generated:

[Firmware Bug]: Failed to parse event in TPM Final Events Log

Call Trace:
efi_config_parse_tables()
  efi_tpm_eventlog_init()
    tpm2_calc_event_log_size()
      __calc_tpm2_event_size()

The pcr_idx value in the Intel TDX log header is 1, causing the function __calc_tpm2_event_size() to fail to recognize the log header, ultimately leading to the "Failed to parse event in TPM Final Events Log" error.

Quoted 8 lines

Intel misread the spec and wrongly sets pcrIndex to 1 in the header and since they did this, we fear others might, so we're relaxing the header check. There's no danger of this causing problems because we check for the TCG_SPECID_SIG signature as the next thing.

Fixes d228814b1913 ("efi/libstub: Add get_event_log() support for CC platforms")
Quoted 37 lines

---

V6:
- improve commit message suggested by James

V5:
- remove the pcr_index check without adding any replacement checks suggested by James and Sathyanarayanan

V4:
- remove cc_platform_has(CC_ATTR_GUEST_STATE_ENCRYPT) suggested by Ard

V3:
- fix build error

V2:
- limit the fix for CC only suggested by Jarkko and Sathyanarayanan

 include/linux/tpm_eventlog.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
include/linux/tpm_eventlog.h +1 -3
index 891368e..05c0ae5 100644
@@ -202,8 +202,7 @@ static __always_inline u32 __calc_tpm2_event_size(struct tcg_pcr_event2_head *ev
        event_type = event->event_type;
 
        /* Verify that it's the log header */
-       if (event_header->pcr_idx != 0 ||
-           event_header->event_type != NO_ACTION ||
+       if (event_header->event_type != NO_ACTION ||
            memcmp(event_header->digest, zero_digest, sizeof(zero_digest))) {
                size = 0;
                goto out;
--

2.7.4

Reviewed-by on v6 1/1
#2 lore raw
In reply to [email protected]
Quoted 24 lines · On 7/11/25 8:24 PM, [email protected] wrote:

From: Ge Yang <[email protected]>

Since commit d228814b1913 ("efi/libstub: Add get_event_log() support for CC platforms") reuses TPM2 support code for the CC platforms, when launching a TDX virtual machine with coco measurement enabled, the following error log is generated:

[Firmware Bug]: Failed to parse event in TPM Final Events Log

Call Trace:
efi_config_parse_tables()
   efi_tpm_eventlog_init()
     tpm2_calc_event_log_size()
       __calc_tpm2_event_size()

The pcr_idx value in the Intel TDX log header is 1, causing the function __calc_tpm2_event_size() to fail to recognize the log header, ultimately leading to the "Failed to parse event in TPM Final Events Log" error.

Intel misread the spec and wrongly sets pcrIndex to 1 in the header and since they did this, we fear others might, so we're relaxing the header check. There's no danger of this causing problems because we check for the TCG_SPECID_SIG signature as the next thing.

Quoted 4 lines
Fixes d228814b1913 ("efi/libstub: Add get_event_log() support for CC platforms")

---

Quoted 33 lines

V6:
- improve commit message suggested by James

V5:
- remove the pcr_index check without adding any replacement checks suggested by James and Sathyanarayanan

V4:
- remove cc_platform_has(CC_ATTR_GUEST_STATE_ENCRYPT) suggested by Ard

V3:
- fix build error

V2:
- limit the fix for CC only suggested by Jarkko and Sathyanarayanan

  include/linux/tpm_eventlog.h | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
include/linux/tpm_eventlog.h +1 -2
index 891368e..05c0ae5 100644
@@ -202,8 +202,7 @@ static __always_inline u32 __calc_tpm2_event_size(struct tcg_pcr_event2_head *ev
  	event_type = event->event_type;
 
  	/* Verify that it's the log header */
-	if (event_header->pcr_idx != 0 ||
-	    event_header->event_type != NO_ACTION ||
+	if (event_header->event_type != NO_ACTION ||
  	    memcmp(event_header->digest, zero_digest, sizeof(zero_digest))) {
  		size = 0;
  		goto out;
Signature · 2 lines
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
Reviewed-by on v6 1/1
#3 lore raw
In reply to [email protected]
Quoted 25 lines · On Sat, 2025-07-12 at 11:24 +0800, [email protected] wrote:

From: Ge Yang <[email protected]>

Since commit d228814b1913 ("efi/libstub: Add get_event_log() support for CC platforms") reuses TPM2 support code for the CC platforms, when launching a TDX virtual machine with coco measurement enabled, the following error log is generated:

[Firmware Bug]: Failed to parse event in TPM Final Events Log

Call Trace:

efi_config_parse_tables()
  efi_tpm_eventlog_init()
    tpm2_calc_event_log_size()
      __calc_tpm2_event_size()

The pcr_idx value in the Intel TDX log header is 1, causing the function __calc_tpm2_event_size() to fail to recognize the log header, ultimately leading to the "Failed to parse event in TPM Final Events Log" error.

Intel misread the spec and wrongly sets pcrIndex to 1 in the header and since they did this, we fear others might, so we're relaxing the header check. There's no danger of this causing problems because we check for the TCG_SPECID_SIG signature as the next thing.

Quoted 4 lines
Fixes d228814b1913 ("efi/libstub: Add get_event_log() support for CC

platforms")