lapi/syscalls: Add epoll_create for aarch64.in
Hi,
Quoted 60 lines
Quoted 7 lines · zhaogongyi
Hi,
Quoted 2 lines
On Wed, Oct 27, 2021 at 5:28 AM zhaogongyi
Quoted 18 lines
Quoted 18 lines
Quoted 5 lines · wrote:
Hi,
Quoted 2 lines
On Tue, Oct 26, 2021 at 9:49 AM Zhao Gongyi
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines · wrote:
Add
epoll_createfor aarch64.in and modify the value ofepoll_ctlfor aarch64.in. Otherwise, the testcase epoll_create01/epoll_create02 will fail.Signed-off-by Zhao Gongyi <[email protected]>--- include/lapi/syscalls/aarch64.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Quoted 14 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
include/lapi/syscalls/aarch64.in +0
-0@@ -19,7 +19,6 @@ getcwd 17Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
include/lapi/syscalls/aarch64.in rt_tgsigqueueinfo 240
Quoted 8 lines
include/lapi/syscalls/aarch64.in +0
-1lookup_dcookie 18 eventfd2 19 epoll_create1 20 -epoll_ctl 21 epoll_pwait 22 dup 23 dup3 24@@ -243,6 +242,8 @@ rt_tgsigqueueinfo 240
perf_event_openQuoted 8 lines
Quoted 8 lines
241
Quoted 7 lines
Quoted 6 lines
include/lapi/syscalls/aarch64.in rt_tgsigqueueinfo 240 · line 245
Quoted 4 lines
include/lapi/syscalls/aarch64.in +2
-0accept4 242 recvmmsg 243 +epoll_create 250 +epoll_ctl 251These values are for 32 bit only syscalls. Won't this break 64 bit?
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Yes, these values are for 32 bit only syscalls, the syscall
epoll_createisnot support for 64bit arm64.
Right, adding
epoll_createis OK, but changingepoll_ctlwould break 64bit if there were any users of__NR_epoll_ctl.If we do not consider the running of 32bit program on arm64, we need
Quoted 9 lines
to remove
__NR_epoll_ctl.Quoted 2 lines
And the testcase using
__NR_epoll_ctlwill fail, is it a problem to beresolved?
There are no testcases currently using
__NR_epoll_ctl, but to avoid this potential issues in future, we can remove it. Existing testcases use libcepoll_ctl().
All right! I will modify the patch later.
Thanks!
Quoted 30 lines
Quoted 30 lines
Quoted 29 lines
Quoted 4 lines
Reference to man 2
epoll_create, we can see thatepoll_create/epoll_create1 are supported If only we include the header file
sys/epoll.h.Quoted 2 lines
Is it better that we call
epoll_createreplace to syscall
__NR_epoll_createsince some plateform not support it?I think so. We already use
epoll_create()in other tests, so this looks like simplest solution for all arches.Quoted 16 lines
Thanks for you review!
Quoted 11 lines
Quoted 11 lines
include/lapi/syscalls/aarch64.in +0
-1wait4 260 prlimit64 261 fanotify_init 262 --2.17.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp