Skip to contentSkip to conversation

cpufreq: intel_pstate: Fix missing return statement

PATCH Applied Zhang Rui 2 participants 2 messages Sep 28, 2020 – Sep 30, 2020

Subsystems (2)
lore
Share & tools
lore

Zhang Rui

author
#0 lore raw

PATCH 1/1 cpufreq: intel_pstate: Fix missing return statement

From 1027ed2cacb0b50676eb52dd0089076d951033d7 Mon Sep 17 00:00:00 2001
From: Zhang Rui <[email protected]>
Date: Mon, 28 Sep 2020 11:33:42 +0800
Subject: [PATCH] cpufreq: intel_pstate: Fix missing return statement

Fix missing return statement when writing "off" to intel_pstate status sysfs I/F.

Fixes 55671ea3257a ("cpufreq: intel_pstate: Free memory only when turning off")
---
 drivers/cpufreq/intel_pstate.c | 1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/intel_pstate.c +1 -0
index a827b000ef51..9a515c460a00 100644
@@ -2781,6 +2781,7 @@ static int intel_pstate_update_status(const char *buf, size_t size)
 
 		cpufreq_unregister_driver(intel_pstate_driver);
 		intel_pstate_driver_cleanup();
+		return 0;
 	}
 
 	if (size == 6 && !strncmp(buf, "active", size)) {
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw
Quoted 20 lines · Zhang Rui

From 1027ed2cacb0b50676eb52dd0089076d951033d7 Mon Sep 17 00:00:00 2001
From: Zhang Rui <[email protected]>
Date: Mon, 28 Sep 2020 11:33:42 +0800
Subject: [PATCH] cpufreq: intel_pstate: Fix missing return statement

Fix missing return statement when writing "off" to intel_pstate status sysfs I/F.

Fixes 55671ea3257a ("cpufreq: intel_pstate: Free memory only when turning off")
---
 drivers/cpufreq/intel_pstate.c | 1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/intel_pstate.c +0 -0
index a827b000ef51..9a515c460a00 100644

drivers/cpufreq/intel_pstate.c static int intel_pstate_update_status(const char *buf, size_t size)

Quoted 8 lines
drivers/cpufreq/intel_pstate.c +1 -1
@@ -2781,6 +2781,7 @@ static int intel_pstate_update_status(const char *buf, size_t size)
 
                cpufreq_unregister_driver(intel_pstate_driver);
                intel_pstate_driver_cleanup();
+               return 0;
        }
 
        if (size == 6 && !strncmp(buf, "active", size)) {
--

Applied as a 5.9-rc fix, thanks!