Skip to contentSkip to conversation

fs/ceph: don't return a value from void function

PATCH In review [email protected] 2 participants 2 messages Aug 2, 2019 Ceph client

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/ceph: don't return a value from void function

From: John Hubbard <[email protected]>

This fixes a build warning to that effect.

---

Hi,

I ran into this while working on unrelated changes, to convert ceph over to put_user_page().

This patch is against the latest linux.git.

thanks,
John Hubbard
NVIDIA

 fs/ceph/debugfs.c | 1 -
 1 file changed, 1 deletion(-)
fs/ceph/debugfs.c +0 -1
index 2eb88ed22993..facb387c2735 100644
@@ -294,7 +294,6 @@ void ceph_fs_debugfs_init(struct ceph_fs_client *fsc)
 
 void ceph_fs_debugfs_init(struct ceph_fs_client *fsc)
 {
-	return 0;
 }
 
 void ceph_fs_debugfs_cleanup(struct ceph_fs_client *fsc)
Signature · 1 line
2.22.0
#1 lore raw
Quoted 27 lines · On Thu, 2019-08-01 at 18:06 -0700, [email protected] wrote:

From: John Hubbard <[email protected]>

This fixes a build warning to that effect.

---

Hi,

I ran into this while working on unrelated changes, to convert ceph over to put_user_page().

This patch is against the latest linux.git.

thanks,
John Hubbard
NVIDIA

 fs/ceph/debugfs.c | 1 -
 1 file changed, 1 deletion(-)
fs/ceph/debugfs.c +0 -0
index 2eb88ed22993..facb387c2735 100644

fs/ceph/debugfs.c void ceph_fs_debugfs_init(struct ceph_fs_client *fsc) · line 299

Quoted 7 lines
fs/ceph/debugfs.c +0 -1
@@ -294,7 +294,6 @@ void ceph_fs_debugfs_init(struct ceph_fs_client *fsc)
 
 void ceph_fs_debugfs_init(struct ceph_fs_client *fsc)
 {
-	return 0;
 }
 
 void ceph_fs_debugfs_cleanup(struct ceph_fs_client *fsc)

Thanks. Merged into ceph-client/testing branch, we'll see about getting this to Linus before v5.3 ships.

Signature · 1 line
Jeff Layton <[email protected]>