Skip to contentSkip to conversation

net/iavf: fix info get

PATCH Applied Qiming Yang 3 participants 3 messages Apr 17, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/iavf: fix info get

iavf driver reset the dev_info structure. This action will clear the setting in core library. This patch fix that issue.

Fixes 69dd4c3d0898 ("net/avf: enable queue and device")
---
 drivers/net/iavf/iavf_ethdev.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/iavf/iavf_ethdev.c +0 -1
index 846e604..7825cbc 100644
@@ -498,7 +498,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 {
 	struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 
-	memset(dev_info, 0, sizeof(*dev_info));
 	dev_info->max_rx_queues = vf->vsi_res->num_queue_pairs;
 	dev_info->max_tx_queues = vf->vsi_res->num_queue_pairs;
 	dev_info->min_rx_bufsize = IAVF_BUF_SIZE_MIN;
Signature · 1 line
2.9.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Qiming Yang

iavf driver reset the dev_info structure. This action will clear the setting in core library. This patch fix that issue.

Fixes 69dd4c3d0898 ("net/avf: enable queue and device")

"Cc: [email protected]" is supposed to be part of the commitlog.

See
http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported

Quoted 20 lines
---
 drivers/net/iavf/iavf_ethdev.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/iavf/iavf_ethdev.c +0 -1
index 846e604..7825cbc 100644
@@ -498,7 +498,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct
 rte_eth_dev_info *dev_info)
 {
        struct iavf_info *vf =
 IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 
-       memset(dev_info, 0, sizeof(*dev_info));
        dev_info->max_rx_queues = vf->vsi_res->num_queue_pairs;
        dev_info->max_tx_queues = vf->vsi_res->num_queue_pairs;
        dev_info->min_rx_bufsize = IAVF_BUF_SIZE_MIN;
Quoted 4 lines

--
2.9.5

Signature · 1 line
David Marchand
Applied
#2 lore raw
Quoted 9 lines · David Marchand
Quoted 5 lines · Qiming Yang

iavf driver reset the dev_info structure. This action will clear the setting in core library. This patch fix that issue.

Fixes 69dd4c3d0898 ("net/avf: enable queue and device")

"Cc: [email protected]" is supposed to be part of the commitlog.

Quoted 8 lines

See
http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported

Quoted 1 line

Applied to dpdk-next-net/master, thanks.