APM82xxx: Add SRAM support
PATCH 6/8 APM82xxx: Add SRAM support
From: Tirumala Marri <[email protected]>
This patch adds L2Cache/SRAM and OCM register definitions.
--- arch/powerpc/include/asm/ppc4xx-isram.h | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-)
arch/powerpc/include/asm/ppc4xx-isram.h +5 -3
@@ -25,7 +25,8 @@/* * Internal SRAM */ -#if defined(CONFIG_440EPX ) || defined(CONFIG_440GRX ) +#if defined(CONFIG_440EPX ) || defined(CONFIG_440GRX ) ||\ + defined(CONFIG_APM82XXX )#define ISRAM0_DCR_BASE 0x380#else #define ISRAM0_DCR_BASE 0x020
@@ -42,7 +43,8 @@#define ISRAM0_REVID (ISRAM0_DCR_BASE+0x09)/* SRAM bus revision id reg */ #define ISRAM0_DPC (ISRAM0_DCR_BASE+0x0a)/* SRAM data parity check reg */ -#if defined(CONFIG_460EX ) || defined(CONFIG_460GT ) +#if defined(CONFIG_460EX ) || defined(CONFIG_460GT ) ||\ + defined(CONFIG_APM82XXX )#define ISRAM1_DCR_BASE 0x0B0#define ISRAM1_SB0CR (ISRAM1_DCR_BASE+0x00)/* SRAM1 bank config 0*/ #define ISRAM1_BEAR (ISRAM1_DCR_BASE+0x04)/* SRAM1 bus error addr reg */
@@ -60,7 +62,7 @@#if defined (CONFIG_440GX ) || \ defined(CONFIG_440SP ) || defined(CONFIG_440SPE ) || \ defined(CONFIG_460EX ) || defined(CONFIG_460GT ) || \ - defined(CONFIG_460SX ) + defined(CONFIG_460SX ) || defined(CONFIG_APM82XXX )#define L2_CACHE_BASE 0x030#define L2_CACHE_CFG (L2_CACHE_BASE+0x00)/* L2 Cache Config */ #define L2_CACHE_CMD (L2_CACHE_BASE+0x01)/* L2 Cache Command */
Signature · 1 line
1.6.1.rc3
PATCH 6/8 APM82xxx: Add SRAM support
Hello.
Quoted 5 lines · tmarri at apm.com
From: Tirumala Marri <[email protected]>
This patch adds L2Cache/SRAM and OCM register definitions.
Signed-off-by Tirumala R Marri <[email protected]>
[...]
arch/powerpc/include/asm/ppc4xx-isram.h line 28
Quoted 10 lines
arch/powerpc/include/asm/ppc4xx-isram.h +1
-1@@ -25,7 +25,8 @@/* * Internal SRAM */ -#if defined(CONFIG_440EPX ) || defined(CONFIG_440GRX ) +#if defined(CONFIG_440EPX) || defined(CONFIG_440GRX) ||\
Please add space before \ to keep the style consistent.
arch/powerpc/include/asm/ppc4xx-isram.h line 46
Quoted 10 lines
arch/powerpc/include/asm/ppc4xx-isram.h +2
-1+ defined(CONFIG_APM82XXX)#define ISRAM0_DCR_BASE 0x380#else #define ISRAM0_DCR_BASE 0x020@@ -42,7 +43,8 @@#define ISRAM0_REVID (ISRAM0_DCR_BASE+0x09)/* SRAM bus revision id reg */ #define ISRAM0_DPC (ISRAM0_DCR_BASE+0x0a)/* SRAM data parity check reg */ -#if defined(CONFIG_460EX ) || defined(CONFIG_460GT ) +#if defined(CONFIG_460EX) || defined(CONFIG_460GT) ||\
Same here...
arch/powerpc/include/asm/ppc4xx-isram.h line 50
Quoted 4 lines
arch/powerpc/include/asm/ppc4xx-isram.h +1
-0+ defined(CONFIG_APM82XXX)#define ISRAM1_DCR_BASE 0x0B0#define ISRAM1_SB0CR (ISRAM1_DCR_BASE+0x00)/* SRAM1 bank config 0*/ #define ISRAM1_BEAR (ISRAM1_DCR_BASE+0x04)/* SRAM1 bus error addr reg */
WBR, Sergei
PATCH 6/8 APM82xxx: Add SRAM support
Quoted 5 lines
Quoted 2 lines
Signed-off-by Tirumala R Marri <[email protected]>[...]
Review
Quoted 1 line
(quoted diff) +0
-0
b/arch/powerpc/include/asm/ppc4xx-isram.h
Quoted 11 lines
arch/powerpc/include/asm/ppc4xx-isram.h line 28
Quoted 9 lines
index d6d17ac..b723401 100644
arch/powerpc/include/asm/ppc4xx-isram.h +1
-1@@ -25,7 +25,8 @@/* * Internal SRAM */ -#if defined(CONFIG_440EPX ) || defined(CONFIG_440GRX ) +#if defined(CONFIG_440EPX) || defined(CONFIG_440GRX) ||\Please add space before \ to keep the style consistent.
[Marri] Sure will do
Quoted 7 lines
arch/powerpc/include/asm/ppc4xx-isram.h line 43
Quoted 7 lines
arch/powerpc/include/asm/ppc4xx-isram.h +1
-0+ defined(CONFIG_APM82XXX)#define ISRAM0_DCR_BASE 0x380#else #define ISRAM0_DCR_BASE 0x020@@ -42,7 +43,8 @@#define ISRAM0_REVID (ISRAM0_DCR_BASE+0x09)/* SRAM bus
revision id
Quoted 8 lines
reg */
arch/powerpc/include/asm/ppc4xx-isram.h line 44
Quoted 1 line
arch/powerpc/include/asm/ppc4xx-isram.h +0
-0#define ISRAM0_DPC (ISRAM0_DCR_BASE+0x0a)/* SRAM data parity check reg */
arch/powerpc/include/asm/ppc4xx-isram.h line 46
Quoted 3 lines
arch/powerpc/include/asm/ppc4xx-isram.h +1
-1-#if defined(CONFIG_460EX ) || defined(CONFIG_460GT ) +#if defined(CONFIG_460EX) || defined(CONFIG_460GT) ||\Same here...
[Marri] Ok
Quoted 4 lines
arch/powerpc/include/asm/ppc4xx-isram.h
Quoted 4 lines
arch/powerpc/include/asm/ppc4xx-isram.h +1
-0+ defined(CONFIG_APM82XXX)#define ISRAM1_DCR_BASE 0x0B0#define ISRAM1_SB0CR (ISRAM1_DCR_BASE+0x00)/* SRAM1 bank
config
Quoted 2 lines
0*/
Quoted 1 line
arch/powerpc/include/asm/ppc4xx-isram.h +0
-0#define ISRAM1_BEAR (ISRAM1_DCR_BASE+0x04)/* SRAM1 bus error
addr
Quoted 1 line
reg */
Regards,
Marri