add support for sending RFC8335 PROBE
Subsystems (2)
v4 cover add support for sending RFC8335 PROBE
The popular utility ping has several severe limitations such as the inability to query specific interfaces on a node and requiring bidirectional connectivity between the probing and the probed interfaces. RFC8335 attempts to solve these limitations by creating the new utility PROBE which is a specialized ICMP message that makes use of the ICMP Extension Structure outlined in RFC4884.
This patchset adds definitions for the ICMP Extended Echo Request and Reply (PROBE) types for both IPv4 and IPv6. It also expands the list of supported ICMP messages to accommodate PROBEs.
Changes since v1:
- Switch to correct base tree
Changes since v2:
- Switch to net-next tree 67c70b5eb2bf7d0496fcb62d308dc3096bc11553
Changes since v3:
- Reorder patches to add defines first
Andreas Roeseler (3):
icmp: define PROBE message types
ICMPv6: define PROBE message types
net: add support for sending RFC8335 PROBE
include/uapi/linux/icmp.h | 3 +++ include/uapi/linux/icmpv6.h | 6 ++++++ net/ipv4/ping.c | 4 +++- 3 files changed, 12 insertions(+), 1 deletion(-)
Signature · 1 line
2.29.2
PATCH v4 1/3 icmp: define PROBE message types
The types of ICMP Extended Echo Request and ICMP Extended Echo Reply are defined in sections 2 and 3 of RFC8335.
---
Changes since v1:
- Switch to correct base tree
Changes since v2:
- Switch to net-next tree 67c70b5eb2bf7d0496fcb62d308dc3096bc11553
Changes since v3:
- Reorder patches to add defines first
--- include/uapi/linux/icmp.h | 3 +++ 1 file changed, 3 insertions(+)
include/uapi/linux/icmp.h +3 -0
@@ -66,6 +66,9 @@#define ICMP_EXC_TTL 0/* TTL count exceeded */ #define ICMP_EXC_FRAGTIME 1/* Fragment Reass time exceeded */ +/* Codes for EXT_ECHO (Probe) */ +#define ICMP_EXT_ECHO 42 +#define ICMP_EXT_ECHOREPLY 43struct icmphdr {__u8 type;
Signature · 1 line
2.29.2
PATCH v4 2/3 ICMPv6: define PROBE message types
In reply to Andreas RoeselerThe types of ICMPV6 Extended Echo Request and ICMPV6 Extended Echo Reply are defined in sections 2 and 3 of RFC8335.
---
Changes since v1:
- Switch to correct base tree
Changes since v2:
- Switch to net-next tree 67c70b5eb2bf7d0496fcb62d308dc3096bc11553
Changes since v3:
- Reorder patches to add defines first
--- include/uapi/linux/icmpv6.h | 6 ++++++ 1 file changed, 6 insertions(+)
include/uapi/linux/icmpv6.h +6 -0
@@ -140,6 +140,12 @@ struct icmp6hdr {#define ICMPV6_UNK_OPTION 2#define ICMPV6_HDR_INCOMP 3 +/* +* Codes for EXT_ECHO (Probe) +*/ +#define ICMPV6_EXT_ECHO_REQUEST 160 +#define ICMPV6_EXT_ECHO_REPLY 161 +/* * constants for (set|get)sockopt */
Signature · 1 line
2.29.2
PATCH v4 3/3 net: add support for sending RFC8335 PROBE
In reply to Andreas RoeselerModifying the ping_supported function to support probe message types allows the user to send probe requests through the existing framework for sending ping requests.
---
Changes since v1:
- Switch to correct base tree
Changes since v2:
- Switch to net-next tree 67c70b5eb2bf7d0496fcb62d308dc3096bc11553
Changes since v3:
- Reorder patches add defines first
--- net/ipv4/ping.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
net/ipv4/ping.c +3 -1
@@ -453,7 +453,9 @@ EXPORT_SYMBOL_GPL(ping_bind);static inline int ping_supported (int family,int type,int code) {return (family ==AF_INET && type ==ICMP_ECHO && code ==0 ) || - (family ==AF_INET6 && type ==ICMPV6_ECHO_REQUEST && code ==0 ); + (family ==AF_INET && type ==ICMP_EXT_ECHO && code ==0 ) || + (family ==AF_INET6 && type ==ICMPV6_ECHO_REQUEST && code ==0 ) || + (family ==AF_INET6 && type ==ICMPV6_EXT_ECHO_REQUEST && code ==0 ); }/*
Signature · 1 line
2.29.2
Quoted 11 lines · Andreas Roeseler
The popular utility ping has several severe limitations such as the inability to query specific interfaces on a node and requiring bidirectional connectivity between the probing and the probed interfaces. RFC8335 attempts to solve these limitations by creating the new utility PROBE which is a specialized ICMP message that makes use of the ICMP Extension Structure outlined in RFC4884.
This patchset adds definitions for the ICMP Extended Echo Request and Reply (PROBE) types for both IPv4 and IPv6. It also expands the list of supported ICMP messages to accommodate PROBEs.
You are updating the send, but what about the response side?
Quoted 8 lines · David Ahern
Quoted 7 lines · Andreas Roeseler
The popular utility ping has several severe limitations such as the inability to query specific interfaces on a node and requiring bidirectional connectivity between the probing and the probed interfaces. RFC8335 attempts to solve these limitations by creating the new utility PROBE which is a specialized ICMP message that makes use of the ICMP Extension Structure outlined in RFC4884.
Quoted 7 lines
Quoted 4 lines
This patchset adds definitions for the ICMP Extended Echo Request and Reply (PROBE) types for both IPv4 and IPv6. It also expands the list of supported ICMP messages to accommodate PROBEs.
You are updating the send, but what about the response side?
you also are not setting 'ICMP Extension Structure'. From:
https://tools.ietf.org/html/rfc8335
o ICMP Extension Structure: The ICMP Extension Structure identifies the probed interface.
Section 7 of [RFC4884] defines the ICMP Extension Structure. As per RFC 4884, the Extension Structure contains exactly one Extension Header followed by one or more objects. When applied to the ICMP Extended Echo Request message, the ICMP Extension Structure MUST contain exactly one instance of the Interface Identification Object (see Section 2.1).
Quoted 29 lines · David Ahern
Quoted 11 lines · David Ahern
Quoted 10 lines · Andreas Roeseler
The popular utility ping has several severe limitations such as the
inability to query specific interfaces on a node and requiring bidirectional connectivity between the probing and the probed interfaces. RFC8335 attempts to solve these limitations by creating the
new utility PROBE which is a specialized ICMP message that makes use of
the ICMP Extension Structure outlined in RFC4884.Quoted 9 lines
Quoted 6 lines
This patchset adds definitions for the ICMP Extended Echo Request and
Reply (PROBE) types for both IPv4 and IPv6. It also expands the list of
supported ICMP messages to accommodate PROBEs.You are updating the send, but what about the response side?
you also are not setting 'ICMP Extension Structure'. From:
https://tools.ietf.org/html/rfc8335o ICMP Extension Structure: The ICMP Extension Structure identifies
the probed interface.
Quoted 8 lines
Section 7 of [RFC4884] defines the ICMP Extension Structure. As per
RFC 4884, the Extension Structure contains exactly one Extension Header followed by one or more objects. When applied to the ICMP Extended Echo Request message, the ICMP Extension Structure MUST contain exactly one instance of the Interface Identification Object
(see Section 2.1).
I am currently finishing testing and polishing the response side and hope to be sendding out v1 of the patch in the upcoming few weeks.
As for the 'ICMP Extension Structure', I have been working with the iputils package to add a command to send PROBE messages, and the changes included in this patchset are all that are necessary to be able to send PROBEs using the existing ping framework.
Quoted 39 lines · Andreas Roeseler
Quoted 29 lines · David Ahern
Quoted 11 lines · David Ahern
Quoted 10 lines · Andreas Roeseler
The popular utility ping has several severe limitations such as the
inability to query specific interfaces on a node and requiring bidirectional connectivity between the probing and the probed interfaces. RFC8335 attempts to solve these limitations by creating the
new utility PROBE which is a specialized ICMP message that makes use of
the ICMP Extension Structure outlined in RFC4884.Quoted 9 lines
Quoted 6 lines
This patchset adds definitions for the ICMP Extended Echo Request and
Reply (PROBE) types for both IPv4 and IPv6. It also expands the list of
supported ICMP messages to accommodate PROBEs.You are updating the send, but what about the response side?
you also are not setting 'ICMP Extension Structure'. From:
https://tools.ietf.org/html/rfc8335o ICMP Extension Structure: The ICMP Extension Structure identifies
the probed interface.Quoted 8 lines
Section 7 of [RFC4884] defines the ICMP Extension Structure. As per
RFC 4884, the Extension Structure contains exactly one Extension Header followed by one or more objects. When applied to the ICMP Extended Echo Request message, the ICMP Extension Structure MUST contain exactly one instance of the Interface Identification Object
(see Section 2.1).
Quoted 2 lines
I am currently finishing testing and polishing the response side and hope to be sendding out v1 of the patch in the upcoming few weeks.
send the response side with the request side -- 1 set of patches for the entire feature.
Quoted 6 lines
As for the 'ICMP Extension Structure', I have been working with the iputils package to add a command to send PROBE messages, and the changes included in this patchset are all that are necessary to be able to send PROBEs using the existing ping framework.
right.